dubbo-go-pixiu icon indicating copy to clipboard operation
dubbo-go-pixiu copied to clipboard

Published 20 hours ago • verified publisher icon apache

develop分支上，代码重复（完全一模一样代码）

Open drama10096 opened this issue 2 years ago • 4 comments

在pkg/adapter/dubboregistry/registry/listener.go里面有

type Listener interface { Close() WatchAndHandle() }

在pkg/remote/zookeeper/client.go也有

type Listener interface { Close() WatchAndHandle() }

drama10096 avatar Jun 15 '22 15:06 drama10096

refactor needed [WIP]

MasterKenway avatar Jun 16 '22 22:06 MasterKenway

@drama10096 May u refactor it?

mark4z avatar Jun 24 '22 08:06 mark4z

how about move thie listener.go refactor to dir : "pkg/adapter/dubboregistry/listener.go"? so we can remove the Listener interface defined in "pkg/remote/zookeeper/client.go"

SunnyBoy-WYH avatar Jun 30 '22 10:06 SunnyBoy-WYH

@drama10096 社区已经记录了这个优化项，接下来会根据项目计划去推进重构优化代码，欢迎加入社区，有什么最新进展会在群里同步大家。

PhilYue avatar Aug 12 '22 09:08 PhilYue

先暂时关闭了，之后会计划小重构迭代

PhilYue avatar Sep 18 '22 09:09 PhilYue