dubbo-admin icon indicating copy to clipboard operation
dubbo-admin copied to clipboard

为啥新版本的dubbo控制台把ProviderService的四个方法给去掉了

Open qq664042 opened this issue 4 years ago • 4 comments

  • [ ] I have searched the issues of this repository and believe that this is not a duplicate.
  • [ ] I have checked the REAMDE of this repository and believe that this is not a duplicate.

Environment

  • Dubbo version: 0.3.0-SNAPSHOT
  • Registry center detail (type and version): zookeeper
  • Operating System version: win7
  • Java version: jdk8

Steps to reproduce this issue

  1. 为啥把org.apache.dubbo.admin.service.ProviderService的四个enableProvider、disableProvider、doublingProvider、halvingProvider给去掉了?
  2. 有替代方法吗?

Pls. provide [GitHub address] to reproduce this issue.

Expected Result

What do you expected from the above steps?

Actual Result

What actually happens?

If there is an exception, please attach the exception trace:

Just put your stack trace here!

qq664042 avatar Feb 01 '21 08:02 qq664042

您这边需要这几个方法有什么用途吗? 我看了下提交,这几个方法在2年前就已经去掉了,历史代码在这里: https://github.com/apache/dubbo-admin/blob/1177f83544ae0394cdb719336dd17bf5cb8f46f0/dubbo-admin-backend/src/main/java/org/apache/dubbo/admin/service/impl/ProviderServiceImpl.java 我们可以发起一个讨论, 如果讨论结果是这些方法有必要的话,我们把它恢复.

KeRan213539 avatar Feb 07 '21 09:02 KeRan213539

这些方法是不是有bug, 还是啥的,提供之后呢,再就可以外部控制,特别是灰度发布的时候要用到的啊

qq664042 avatar Feb 20 '21 07:02 qq664042

这些方法是不是有bug, 还是啥的,提供之后呢,再就可以外部控制,特别是灰度发布的时候要用到的啊

非常抱歉. 不太清楚之前移除的原因. 我们会把相关功能加回, 不过这需要一些时间, 因为现在dubbo提供了应用级服务注册, 我们需要重新设计一下相关功能

KeRan213539 avatar Feb 25 '21 01:02 KeRan213539

可以在动态配置中禁用服务,也可以达到类似的效果。

---
configVersion: v2.7
scope: application
key: demo-provider
enabled: true
configs:
- addresses: ["10.20.153.10:20880"]
  side: provider
  parameters:
    disabled: true
...

相关文档 https://dubbo.apache.org/zh/docs/advanced/config-rule/ 。

haoyann avatar Nov 25 '21 08:11 haoyann