druid icon indicating copy to clipboard operation
druid copied to clipboard

feat: log total bytes gathered when max scatter-gather bytes limit is reached

Open TessaIO opened this issue 2 weeks ago • 1 comments

Fixes #18840.

Description

log total bytes gathered when max scatter-gather bytes limit is reached

Release note


log total bytes gathered when max scatter-gather bytes limit is reached

This PR has:

  • [x] been self-reviewed.
    • [ ] using the concurrency checklist (Remove this item if the PR doesn't have any relation to concurrency.)
  • [x] added documentation for new or modified features or behaviors.
  • [x] a release note entry in the PR description.
  • [x] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • [x] added or updated version, license, or notice information in licenses.yaml
  • [x] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • [x] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • [x] added integration tests.
  • [x] been tested in a test Druid cluster.

TessaIO avatar Dec 12 '25 17:12 TessaIO

@abhishekrb19 thanks for the suggestion, I think it would be cleaner if the test coverage is addressed in a separate PR as this one is solely focused on improving the logs. wdyt?

TessaIO avatar Dec 13 '25 17:12 TessaIO

@abhishekrb19 thanks for the review, updated!

TessaIO avatar Dec 16 '25 23:12 TessaIO

@abhishekrb19 done

TessaIO avatar Dec 17 '25 00:12 TessaIO