druid icon indicating copy to clipboard operation
druid copied to clipboard
verified publisher icon apache

[BugFix] Fix CacheKeyBuilder to correctly handle empty Cacheable keys

Open hongkunxu opened this issue 4 months ago • 3 comments

This PR fixes a bug in CacheKeyBuilder.appendCacheable where null or empty Cacheable objects were not properly marked as invalid.

  • appendCacheable now marks keys that serialize to EMPTY_BYTES as invalid.
  • Ensures that build() returns null for invalid keys instead of producing a misleading byte array.

Could some committer help to review this PR? cc @agile @trotter @mcroydon @StFS

hongkunxu avatar Aug 18 '25 17:08 hongkunxu

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the [email protected] list. Thank you for your contributions.

github-actions[bot] avatar Oct 26 '25 00:10 github-actions[bot]

Hi @FrankChen021 , Could you please tell me why not merge this PR?

hongkunxu avatar Nov 12 '25 02:11 hongkunxu

close and repen to trigger the CI @hongkunxu

FrankChen021 avatar Nov 12 '25 02:11 FrankChen021