druid icon indicating copy to clipboard operation
druid copied to clipboard

Prioritize query stats in RequestLogLine.getNativeQueryLine

Open Zeyu-Chen-SFDC opened this issue 4 months ago • 0 comments

Description

This change switches the order of query vs stats in getNativeQueryLine to keep it consistent with getSqlQueryLine.

It happens on non-trivial occasions when a long list of intervals.segments in the query object exceeds the max cut-off of whichever logging system is deployed by the user and makes the stats unavailable for subsequent log searches. In those situations, we prefer to have the more important stats logged first and sacrifice the list of intervals.

The same change should be applied to the order of fields in the native query object, moving intervals to the last. However, that's a bigger change.

Release note


Key changed/added classes in this PR
  • RequestLogLine

This PR has:

  • [x] been self-reviewed.
    • [ ] using the concurrency checklist (Remove this item if the PR doesn't have any relation to concurrency.)
  • [ ] added documentation for new or modified features or behaviors.
  • [ ] a release note entry in the PR description.
  • [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • [ ] added or updated version, license, or notice information in licenses.yaml
  • [x] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • [ ] added integration tests.
  • [ ] been tested in a test Druid cluster.

Zeyu-Chen-SFDC avatar Oct 10 '24 22:10 Zeyu-Chen-SFDC