druid icon indicating copy to clipboard operation
druid copied to clipboard

Handling nil selector column in vector math processors

Open sreemanamala opened this issue 1 year ago • 0 comments

Description

Currently If a segment does not have a column, then an math expression processor triggered on that segment involving that column is resulting in a Unable to vectorize expression exception. This PR aims to fix these by defaulting the input type to double type.


Key changed/added classes in this PR
  • VectorMathProcessors
  • Function
  • VectorExprSanityTest

This PR has:

  • [x] been self-reviewed.
    • [ ] using the concurrency checklist (Remove this item if the PR doesn't have any relation to concurrency.)
  • [ ] added documentation for new or modified features or behaviors.
  • [ ] a release note entry in the PR description.
  • [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • [ ] added or updated version, license, or notice information in licenses.yaml
  • [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • [ ] added integration tests.
  • [ ] been tested in a test Druid cluster.

sreemanamala avatar Mar 15 '24 01:03 sreemanamala