druid icon indicating copy to clipboard operation
druid copied to clipboard

Make WindowFrames more specific

Open kgyrtkirk opened this issue 1 year ago • 1 comments

this patch changes the WindowFrame internals / representation a bit; introduces a dedicated frametype for rows, groups, unbounded - so that later if we decide to add better ranges support it will less likely need a bigger refactor

it also changes how its represented in the native query:

-      frame: { peerType: "ROWS", lowUnbounded: true, lowOffset: 0, uppUnbounded: true, uppOffset: 0 }
+      frame: { type: unbounded }
-       frame: { peerType: "ROWS", lowUnbounded: false, lowOffset: 0, uppUnbounded: false, uppOffset: 2 }
+      frame: { type: rows, lowerOffset: 0, upperOffset: 2 }
-      frame: { peerType: "RANGE", lowUnbounded: true, lowOffset: 0, uppUnbounded: false, uppOffset: 0, orderBy: [{ column: l1, direction: ASC }] }
+      frame: { type: group, upperOffset: 0, orderBy: [{ column: l1, direction: ASC }] }

right now the current patch has some unrelated changes as its built on top of: #15365

kgyrtkirk avatar Jan 11 '24 17:01 kgyrtkirk

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the [email protected] list. Thank you for your contributions.

github-actions[bot] avatar Mar 12 '24 00:03 github-actions[bot]

This pull request/issue has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

github-actions[bot] avatar Apr 09 '24 00:04 github-actions[bot]

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the [email protected] list. Thank you for your contributions.

github-actions[bot] avatar Jun 09 '24 00:06 github-actions[bot]

This pull request/issue has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

github-actions[bot] avatar Jul 08 '24 00:07 github-actions[bot]