drill icon indicating copy to clipboard operation
drill copied to clipboard

CVE-2020-8908 in Guava v.28.2-jre, should upgrade to v.30.1.1

Open ssainz opened this issue 3 years ago • 8 comments

Describe the bug CVE-2020-8908 in Guava v.28.2-jre, should upgrade to v.30.1.1

To Reproduce Please check vulnerability section in : https://github.com/google/guava/issues/4011

Expected behavior Upgrading to v30.1.1 will mitigate this vulnerability.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: all
  • Browser all
  • Version all

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context Add any other context about the problem here.

ssainz avatar Jun 14 '21 16:06 ssainz

@ssainz Hello, It seems to be resolved. #2202

luocooong avatar Jun 17 '21 11:06 luocooong

Unless there is any objection, I'm going to close this as it should be resolved in Drill 1.19.

cgivre avatar Jun 17 '21 18:06 cgivre

Hello there @luocooong , @cgivre - defect not fixed. Please check this line:

https://github.com/apache/drill/blob/master/pom.xml#L49

shared guava still refers to guava 28.2 , thus, CVE-2020-8908 remains in Drill 1.19.

ssainz avatar Jun 18 '21 12:06 ssainz

@ssainz YES. Thanks for the reminder. @vdiravka has already started the process of updating Drill shaded Guava.

luocooong avatar Jun 19 '21 11:06 luocooong

Can this be closed?

pjfanning avatar Jun 17 '22 19:06 pjfanning

Can this be closed?

I think this is still valid, but not sure. @vdiravka do you know the current status?

cgivre avatar Jun 17 '22 20:06 cgivre

Hi - the shared guava seems is still 28.2, then not fixed yet ~ https://github.com/apache/drill/blob/master/pom.xml#L52

<shaded.guava.version>28.2-jre</shaded.guava.version>

ssainz avatar Jun 18 '22 15:06 ssainz

https://github.com/google/guava/issues/4011 affects a deprecated method and it only affects Drill if it Drill uses the deprecated method in the shaded org.apache.drill.shaded.guava.com.google.common.io.Files class. I see no evidence that Drill uses this method.

pjfanning avatar Jun 18 '22 16:06 pjfanning