doris icon indicating copy to clipboard operation
doris copied to clipboard

[fix](inverted index) fix incorrect variable usage in phrase query building

Open zzzxl1993 opened this issue 1 month ago • 9 comments

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • [x] Regression test
    • [ ] Unit Test
    • [ ] Manual test (add detailed scripts or steps below)
    • [ ] No need to test or manual test. Explain why:
      • [ ] This is a refactor/code format and no logic has been changed.
      • [ ] Previous test can cover this change.
      • [ ] No code files have been changed.
      • [ ] Other reason
  • Behavior changed:

    • [x] No.
    • [ ] Yes.
  • Does this need documentation?

    • [x] No.
    • [ ] Yes.

Check List (For Reviewer who merge this PR)

  • [ ] Confirm the release note
  • [ ] Confirm test cases
  • [ ] Confirm document
  • [ ] Add branch pick label

zzzxl1993 avatar Dec 11 '25 07:12 zzzxl1993

Thank you for your contribution to Apache Doris. Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

hello-stephen avatar Dec 11 '25 07:12 hello-stephen

run buildall

zzzxl1993 avatar Dec 11 '25 07:12 zzzxl1993

run buildall

zzzxl1993 avatar Dec 11 '25 07:12 zzzxl1993

run buildall

zzzxl1993 avatar Dec 11 '25 09:12 zzzxl1993

TPC-H: Total hot run time: 36248 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d8acd2f619d57925cf652dd28f3406de60732018, data reload: false

------ Round 1 ----------------------------------
q1	17657	4200	4055	4055
q2	2066	365	240	240
q3	10128	1324	757	757
q4	10211	846	318	318
q5	7754	2137	1894	1894
q6	222	169	135	135
q7	1022	862	719	719
q8	9354	1460	1111	1111
q9	7224	5334	5398	5334
q10	6864	2395	1957	1957
q11	517	321	289	289
q12	725	744	585	585
q13	17816	3664	3026	3026
q14	290	282	285	282
q15	600	514	507	507
q16	947	905	887	887
q17	752	861	469	469
q18	7555	7727	7648	7648
q19	1598	1040	621	621
q20	402	411	269	269
q21	4524	4096	4183	4096
q22	1106	1049	1097	1049
Total cold run time: 109334 ms
Total hot run time: 36248 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4412	4263	4231	4231
q2	336	419	319	319
q3	2489	2828	2470	2470
q4	1421	1886	1447	1447
q5	4557	4486	4390	4390
q6	219	173	136	136
q7	2001	1981	1785	1785
q8	2676	2530	2530	2530
q9	7392	7376	6882	6882
q10	2936	3229	2673	2673
q11	559	483	478	478
q12	621	699	567	567
q13	3256	3826	2986	2986
q14	280	271	252	252
q15	526	493	483	483
q16	859	871	825	825
q17	1104	1259	1355	1259
q18	7388	7149	7028	7028
q19	831	817	818	817
q20	1876	1990	1826	1826
q21	4587	4273	4137	4137
q22	1089	1018	974	974
Total cold run time: 51415 ms
Total hot run time: 48495 ms

doris-robot avatar Dec 11 '25 09:12 doris-robot

TPC-DS: Total hot run time: 181419 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d8acd2f619d57925cf652dd28f3406de60732018, data reload: false

query5	5365	628	472	472
query6	324	234	222	222
query7	4226	471	271	271
query8	297	250	253	250
query9	8760	2546	2564	2546
query10	555	381	316	316
query11	15241	14769	14515	14515
query12	184	116	110	110
query13	1262	506	379	379
query14	6363	3175	2945	2945
query14_1	2841	2824	2878	2824
query15	211	200	184	184
query16	871	490	488	488
query17	1087	707	607	607
query18	2697	428	336	336
query19	227	217	206	206
query20	121	113	108	108
query21	219	143	110	110
query22	4065	4168	4085	4085
query23	16515	16114	15890	15890
query23_1	16022	16103	16147	16103
query24	7338	1638	1233	1233
query24_1	1246	1203	1239	1203
query25	540	461	407	407
query26	1239	274	166	166
query27	2746	464	300	300
query28	4474	2148	2168	2148
query29	791	538	443	443
query30	313	244	216	216
query31	848	678	627	627
query32	83	66	70	66
query33	527	330	289	289
query34	895	900	533	533
query35	786	819	711	711
query36	859	903	824	824
query37	130	92	74	74
query38	3877	3855	3816	3816
query39	742	726	706	706
query39_1	691	700	712	700
query40	221	137	121	121
query41	69	64	64	64
query42	108	103	102	102
query43	440	447	414	414
query44	1328	755	749	749
query45	188	188	183	183
query46	867	977	623	623
query47	1636	1720	1632	1632
query48	318	329	240	240
query49	626	424	350	350
query50	660	301	222	222
query51	3814	3936	3952	3936
query52	100	108	99	99
query53	318	348	291	291
query54	305	277	275	275
query55	82	83	76	76
query56	308	319	314	314
query57	1137	1148	1083	1083
query58	294	264	258	258
query59	2416	2553	2403	2403
query60	325	332	310	310
query61	185	189	186	186
query62	711	680	623	623
query63	331	295	300	295
query64	5045	1400	1121	1121
query65	4039	3959	3979	3959
query66	1395	464	337	337
query67	15229	15445	14831	14831
query68	5345	1059	750	750
query69	507	355	334	334
query70	1052	1006	1011	1006
query71	369	314	291	291
query72	6229	4936	4922	4922
query73	656	579	304	304
query74	8993	8815	8776	8776
query75	3568	3529	3155	3155
query76	3890	1139	737	737
query77	526	381	276	276
query78	9567	9769	8805	8805
query79	1723	879	624	624
query80	1456	661	560	560
query81	573	267	233	233
query82	400	132	105	105
query83	274	255	241	241
query84	258	110	106	106
query85	948	511	478	478
query86	379	285	277	277
query87	4083	4155	3997	3997
query88	3253	2283	2262	2262
query89	467	418	391	391
query90	1979	168	151	151
query91	174	173	152	152
query92	74	70	68	68
query93	1187	941	562	562
query94	532	311	268	268
query95	571	382	302	302
query96	601	458	208	208
query97	2616	2644	2577	2577
query98	200	196	195	195
query99	1297	1333	1210	1210
Total cold run time: 261420 ms
Total hot run time: 181419 ms

doris-robot avatar Dec 11 '25 09:12 doris-robot

ClickBench: Total hot run time: 27.44 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit d8acd2f619d57925cf652dd28f3406de60732018, data reload: false

query1	0.06	0.05	0.05
query2	0.11	0.05	0.05
query3	0.26	0.09	0.09
query4	1.60	0.10	0.11
query5	0.27	0.26	0.26
query6	1.19	0.63	0.64
query7	0.04	0.03	0.03
query8	0.06	0.04	0.05
query9	0.57	0.51	0.52
query10	0.55	0.56	0.56
query11	0.15	0.10	0.10
query12	0.14	0.11	0.11
query13	0.63	0.62	0.61
query14	0.98	0.99	0.99
query15	0.82	0.80	0.82
query16	0.41	0.40	0.38
query17	1.05	1.05	1.01
query18	0.24	0.22	0.22
query19	1.96	1.86	1.90
query20	0.02	0.01	0.02
query21	15.46	0.29	0.15
query22	4.92	0.06	0.05
query23	15.93	0.29	0.12
query24	0.94	0.39	0.35
query25	0.11	0.11	0.06
query26	0.15	0.14	0.13
query27	0.06	0.07	0.06
query28	3.25	1.26	1.02
query29	12.60	4.00	3.19
query30	0.28	0.15	0.12
query31	2.82	0.64	0.39
query32	3.25	0.56	0.46
query33	3.06	3.01	3.08
query34	16.89	5.27	4.55
query35	4.61	4.52	4.60
query36	0.67	0.49	0.50
query37	0.10	0.06	0.06
query38	0.08	0.04	0.04
query39	0.04	0.03	0.04
query40	0.16	0.15	0.14
query41	0.10	0.03	0.02
query42	0.04	0.03	0.03
query43	0.05	0.04	0.04
Total cold run time: 96.68 s
Total hot run time: 27.44 s

doris-robot avatar Dec 11 '25 10:12 doris-robot

BE UT Coverage Report

Increment line coverage 50.00% (3/6) :tada:

Increment coverage report Complete coverage report

Category Coverage
Function Coverage 53.42% (18822/35237)
Line Coverage 39.16% (174034/444390)
Region Coverage 33.81% (134751/398591)
Branch Coverage 34.74% (57982/166879)

hello-stephen avatar Dec 11 '25 16:12 hello-stephen

BE Regression && UT Coverage Report

Increment line coverage 83.33% (5/6) :tada:

Increment coverage report Complete coverage report

Category Coverage
Function Coverage 72.29% (24964/34534)
Line Coverage 59.04% (262086/443882)
Region Coverage 53.91% (217424/403307)
Branch Coverage 55.45% (93013/167752)

hello-stephen avatar Dec 11 '25 17:12 hello-stephen

PR approved by at least one committer and no changes requested.

github-actions[bot] avatar Dec 12 '25 04:12 github-actions[bot]

PR approved by anyone and no changes requested.

github-actions[bot] avatar Dec 12 '25 04:12 github-actions[bot]