doris icon indicating copy to clipboard operation
doris copied to clipboard

[fix](skew_join)should make skewExpr and skewValues have same datatype

Open starocean999 opened this issue 2 weeks ago • 7 comments

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • [ ] Regression test
    • [ ] Unit Test
    • [ ] Manual test (add detailed scripts or steps below)
    • [ ] No need to test or manual test. Explain why:
      • [ ] This is a refactor/code format and no logic has been changed.
      • [ ] Previous test can cover this change.
      • [ ] No code files have been changed.
      • [ ] Other reason
  • Behavior changed:

    • [ ] No.
    • [ ] Yes.
  • Does this need documentation?

    • [ ] No.
    • [ ] Yes.

Check List (For Reviewer who merge this PR)

  • [ ] Confirm the release note
  • [ ] Confirm test cases
  • [ ] Confirm document
  • [ ] Add branch pick label

starocean999 avatar Dec 11 '25 06:12 starocean999

run buildall

starocean999 avatar Dec 11 '25 06:12 starocean999

Thank you for your contribution to Apache Doris. Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

Thearas avatar Dec 11 '25 06:12 Thearas

TPC-H: Total hot run time: 34753 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 602cf19743ec03de661376d6b9e3ba1e5fc44321, data reload: false

------ Round 1 ----------------------------------
q1	17596	4281	4081	4081
q2	2073	349	241	241
q3	10161	1283	745	745
q4	10212	794	311	311
q5	7507	2137	1873	1873
q6	184	173	137	137
q7	1020	862	714	714
q8	9346	1401	1092	1092
q9	7000	5326	5244	5244
q10	6849	2377	1954	1954
q11	516	314	299	299
q12	691	731	565	565
q13	17794	3656	2995	2995
q14	287	293	286	286
q15	602	518	512	512
q16	931	899	871	871
q17	716	838	524	524
q18	7890	7135	7019	7019
q19	1120	955	626	626
q20	390	371	246	246
q21	4233	3868	3455	3455
q22	1071	1018	963	963
Total cold run time: 108189 ms
Total hot run time: 34753 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4089	4041	4066	4041
q2	339	423	315	315
q3	2114	2667	2332	2332
q4	1319	1731	1307	1307
q5	4224	4603	4921	4603
q6	218	171	128	128
q7	1987	1946	1842	1842
q8	2635	2503	2546	2503
q9	7590	7503	7509	7503
q10	3048	3306	2851	2851
q11	604	513	504	504
q12	675	905	638	638
q13	3555	3889	3313	3313
q14	303	302	269	269
q15	533	527	522	522
q16	940	959	909	909
q17	1180	1414	1418	1414
q18	7867	7683	7845	7683
q19	886	846	863	846
q20	1886	2004	1823	1823
q21	4589	4202	4164	4164
q22	1128	1055	1016	1016
Total cold run time: 51709 ms
Total hot run time: 50526 ms

doris-robot avatar Dec 11 '25 07:12 doris-robot

TPC-DS: Total hot run time: 181379 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 602cf19743ec03de661376d6b9e3ba1e5fc44321, data reload: false

query5	5217	625	476	476
query6	332	238	224	224
query7	4216	471	270	270
query8	324	248	258	248
query9	8752	2556	2576	2556
query10	575	383	331	331
query11	15352	14847	14562	14562
query12	189	116	118	116
query13	1267	517	402	402
query14	6203	3295	3012	3012
query14_1	2926	2958	2909	2909
query15	211	202	181	181
query16	820	460	466	460
query17	1160	743	608	608
query18	2716	455	354	354
query19	253	235	220	220
query20	125	118	116	116
query21	219	145	115	115
query22	4135	4034	3987	3987
query23	16683	16091	16001	16001
query23_1	16140	16220	15938	15938
query24	7331	1680	1232	1232
query24_1	1251	1253	1214	1214
query25	577	503	460	460
query26	1267	276	162	162
query27	2742	481	320	320
query28	4415	2171	2160	2160
query29	842	568	475	475
query30	332	246	219	219
query31	811	693	619	619
query32	83	69	81	69
query33	557	341	306	306
query34	893	907	569	569
query35	793	844	724	724
query36	861	902	892	892
query37	138	89	76	76
query38	3889	3927	3797	3797
query39	748	739	703	703
query39_1	717	706	699	699
query40	221	135	122	122
query41	70	63	64	63
query42	106	107	108	107
query43	436	429	388	388
query44	1315	749	759	749
query45	193	188	183	183
query46	874	977	611	611
query47	1691	1689	1621	1621
query48	315	334	245	245
query49	627	430	343	343
query50	670	286	226	226
query51	3832	3828	3853	3828
query52	109	108	96	96
query53	324	361	288	288
query54	293	259	253	253
query55	80	76	73	73
query56	286	286	289	286
query57	1158	1138	1085	1085
query58	271	252	253	252
query59	2379	2535	2290	2290
query60	319	318	290	290
query61	198	153	161	153
query62	691	682	638	638
query63	329	295	289	289
query64	4963	1288	991	991
query65	4011	3942	3925	3925
query66	1412	449	321	321
query67	15335	15190	14881	14881
query68	8422	1071	774	774
query69	507	346	315	315
query70	1110	988	1012	988
query71	381	313	287	287
query72	6107	4883	4931	4883
query73	672	567	311	311
query74	8791	8929	8719	8719
query75	3637	3541	3172	3172
query76	4033	1141	789	789
query77	642	397	292	292
query78	9613	9612	8900	8900
query79	1634	871	615	615
query80	713	658	555	555
query81	516	275	246	246
query82	517	127	104	104
query83	261	254	235	235
query84	260	127	102	102
query85	947	522	470	470
query86	341	305	281	281
query87	4046	4016	3969	3969
query88	4141	2299	2333	2299
query89	468	426	390	390
query90	2184	161	158	158
query91	174	171	146	146
query92	83	71	63	63
query93	1486	895	569	569
query94	477	294	271	271
query95	575	374	313	313
query96	608	487	215	215
query97	2576	2624	2572	2572
query98	215	196	187	187
query99	1313	1293	1222	1222
Total cold run time: 265762 ms
Total hot run time: 181379 ms

doris-robot avatar Dec 11 '25 08:12 doris-robot

ClickBench: Total hot run time: 27.46 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 602cf19743ec03de661376d6b9e3ba1e5fc44321, data reload: false

query1	0.06	0.05	0.05
query2	0.11	0.05	0.05
query3	0.25	0.09	0.08
query4	1.61	0.11	0.11
query5	0.26	0.26	0.25
query6	1.16	0.66	0.64
query7	0.04	0.03	0.03
query8	0.06	0.05	0.05
query9	0.59	0.51	0.51
query10	0.56	0.55	0.56
query11	0.17	0.12	0.12
query12	0.16	0.12	0.12
query13	0.63	0.61	0.59
query14	1.00	0.97	0.97
query15	0.81	0.81	0.79
query16	0.42	0.38	0.42
query17	0.96	1.08	0.98
query18	0.24	0.22	0.22
query19	1.89	1.88	1.79
query20	0.02	0.01	0.01
query21	15.44	0.30	0.13
query22	4.53	0.05	0.04
query23	16.03	0.27	0.10
query24	1.71	0.70	0.45
query25	0.12	0.06	0.07
query26	0.15	0.13	0.13
query27	0.08	0.06	0.05
query28	4.07	1.20	1.02
query29	12.59	4.06	3.31
query30	0.27	0.14	0.12
query31	2.81	0.64	0.40
query32	3.23	0.54	0.45
query33	3.08	3.10	3.06
query34	16.91	5.19	4.45
query35	4.54	4.55	4.58
query36	0.69	0.51	0.49
query37	0.11	0.07	0.08
query38	0.07	0.04	0.03
query39	0.05	0.03	0.03
query40	0.17	0.14	0.14
query41	0.08	0.03	0.04
query42	0.05	0.04	0.03
query43	0.04	0.03	0.03
Total cold run time: 97.82 s
Total hot run time: 27.46 s

doris-robot avatar Dec 11 '25 08:12 doris-robot

FE Regression Coverage Report

Increment line coverage 100.00% (5/5) :tada: Increment coverage report Complete coverage report

hello-stephen avatar Dec 11 '25 09:12 hello-stephen

FE Regression Coverage Report

Increment line coverage 100.00% (5/5) :tada: Increment coverage report Complete coverage report

hello-stephen avatar Dec 11 '25 10:12 hello-stephen

PR approved by at least one committer and no changes requested.

github-actions[bot] avatar Dec 12 '25 08:12 github-actions[bot]

PR approved by anyone and no changes requested.

github-actions[bot] avatar Dec 12 '25 08:12 github-actions[bot]