doris icon indicating copy to clipboard operation
doris copied to clipboard

[fix](profile) Fix the issue about load channel profile

Open 0AyanamiRei opened this issue 1 month ago • 2 comments

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #33945

Problem Summary:

In data load, the profile results of the load channel are not displayed, and (even after modifications) the profiles of each channel overwrite each other, resulting in incomplete data display.

Meanwhile, some code change adjustments are also included in this PR.

Release note

None

Check List (For Author)

  • Test

    • [ ] Regression test
    • [ ] Unit Test
    • [ ] Manual test (add detailed scripts or steps below)
    • [ ] No need to test or manual test. Explain why:
      • [ ] This is a refactor/code format and no logic has been changed.
      • [ ] Previous test can cover this change.
      • [ ] No code files have been changed.
      • [ ] Other reason
  • Behavior changed:

    • [ ] No.
    • [ ] Yes.
  • Does this need documentation?

    • [ ] No.
    • [ ] Yes.

Check List (For Reviewer who merge this PR)

  • [ ] Confirm the release note
  • [ ] Confirm test cases
  • [ ] Confirm document
  • [ ] Add branch pick label

0AyanamiRei avatar Dec 08 '25 02:12 0AyanamiRei

Thank you for your contribution to Apache Doris. Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

hello-stephen avatar Dec 08 '25 02:12 hello-stephen

Better add a case to check it.

dataroaring avatar Dec 09 '25 22:12 dataroaring

run buildall

dataroaring avatar Dec 15 '25 02:12 dataroaring

run buildall

0AyanamiRei avatar Dec 16 '25 02:12 0AyanamiRei

TPC-H: Total hot run time: 34808 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 1989d6e91d56e5365e8d45da2c1db60ce52e869d, data reload: false

------ Round 1 ----------------------------------
q1	17614	4161	4033	4033
q2	2003	356	238	238
q3	10221	1312	735	735
q4	10204	798	313	313
q5	7527	2169	1882	1882
q6	187	165	134	134
q7	1017	856	709	709
q8	9354	1431	1108	1108
q9	7124	5289	5261	5261
q10	6848	2406	1990	1990
q11	519	325	297	297
q12	668	713	587	587
q13	17782	3727	3032	3032
q14	289	290	267	267
q15	610	524	518	518
q16	665	677	618	618
q17	693	780	574	574
q18	8067	7376	7225	7225
q19	1117	968	586	586
q20	402	360	247	247
q21	4203	3870	3504	3504
q22	1030	986	950	950
Total cold run time: 108144 ms
Total hot run time: 34808 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4088	4019	4033	4019
q2	325	375	319	319
q3	2122	2668	2326	2326
q4	1322	1773	1259	1259
q5	4236	4536	4781	4536
q6	225	170	138	138
q7	2115	1961	1809	1809
q8	2725	2612	2572	2572
q9	7525	7444	7570	7444
q10	3143	3270	2798	2798
q11	588	509	496	496
q12	680	773	740	740
q13	3524	3980	3357	3357
q14	322	305	262	262
q15	562	499	507	499
q16	658	712	649	649
q17	1204	1422	1490	1422
q18	8110	7790	7380	7380
q19	899	854	910	854
q20	2004	2077	1985	1985
q21	4760	4334	4194	4194
q22	1106	1056	989	989
Total cold run time: 52243 ms
Total hot run time: 50047 ms

doris-robot avatar Dec 16 '25 03:12 doris-robot

TPC-DS: Total hot run time: 176169 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 1989d6e91d56e5365e8d45da2c1db60ce52e869d, data reload: false

query5	4408	620	497	497
query6	339	251	237	237
query7	4227	472	279	279
query8	311	251	253	251
query9	8766	2571	2584	2571
query10	489	374	329	329
query11	15301	14750	14495	14495
query12	188	121	117	117
query13	1269	514	407	407
query14	5898	3268	3048	3048
query14_1	2925	2856	2942	2856
query15	216	209	185	185
query16	939	484	476	476
query17	1176	733	614	614
query18	2530	426	336	336
query19	218	225	203	203
query20	118	112	110	110
query21	215	143	113	113
query22	3918	4004	3972	3972
query23	16533	16155	15959	15959
query23_1	16063	16114	15886	15886
query24	7381	1635	1229	1229
query24_1	1254	1229	1271	1229
query25	594	462	413	413
query26	1256	273	160	160
query27	2744	460	311	311
query28	4447	2137	2123	2123
query29	792	552	433	433
query30	316	241	213	213
query31	812	683	627	627
query32	80	75	67	67
query33	545	341	300	300
query34	900	913	541	541
query35	774	807	739	739
query36	850	911	827	827
query37	123	91	81	81
query38	2908	2880	2884	2880
query39	761	745	712	712
query39_1	695	697	687	687
query40	230	137	122	122
query41	68	62	64	62
query42	109	108	107	107
query43	433	450	394	394
query44	1384	753	749	749
query45	188	186	180	180
query46	882	995	637	637
query47	1637	1677	1595	1595
query48	317	329	249	249
query49	659	439	365	365
query50	669	313	221	221
query51	3889	3813	3873	3813
query52	117	114	102	102
query53	328	355	294	294
query54	285	262	256	256
query55	80	76	72	72
query56	303	306	297	297
query57	1150	1134	1058	1058
query58	270	265	252	252
query59	2409	2457	2365	2365
query60	320	313	304	304
query61	172	188	193	188
query62	713	671	635	635
query63	333	303	314	303
query64	5166	1408	1133	1133
query65	4019	3997	3953	3953
query66	1477	461	357	357
query67	14997	14941	14829	14829
query68	6973	1012	733	733
query69	516	366	331	331
query70	1127	993	1006	993
query71	390	315	301	301
query72	6081	2608	5315	2608
query73	776	734	320	320
query74	8784	8819	8720	8720
query75	3171	3128	2751	2751
query76	3877	1150	752	752
query77	553	411	288	288
query78	9597	9761	8808	8808
query79	1328	898	628	628
query80	1461	649	556	556
query81	555	265	243	243
query82	412	138	110	110
query83	280	262	244	244
query84	255	120	104	104
query85	932	511	470	470
query86	384	300	291	291
query87	2979	3065	2948	2948
query88	3300	2310	2297	2297
query89	458	442	402	402
query90	1948	168	161	161
query91	174	173	143	143
query92	72	70	68	68
query93	1122	935	574	574
query94	539	304	256	256
query95	573	376	308	308
query96	611	477	215	215
query97	2264	2332	2221	2221
query98	211	198	198	198
query99	1280	1274	1213	1213
Total cold run time: 258818 ms
Total hot run time: 176169 ms

doris-robot avatar Dec 16 '25 03:12 doris-robot

ClickBench: Total hot run time: 27.3 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 1989d6e91d56e5365e8d45da2c1db60ce52e869d, data reload: false

query1	0.05	0.05	0.04
query2	0.09	0.05	0.05
query3	0.25	0.09	0.09
query4	1.60	0.11	0.11
query5	0.27	0.26	0.25
query6	1.18	0.65	0.64
query7	0.03	0.03	0.03
query8	0.05	0.05	0.04
query9	0.57	0.51	0.49
query10	0.56	0.56	0.55
query11	0.15	0.11	0.11
query12	0.14	0.12	0.11
query13	0.63	0.60	0.61
query14	0.99	0.98	1.00
query15	0.83	0.80	0.80
query16	0.39	0.40	0.40
query17	0.99	1.07	1.03
query18	0.24	0.22	0.21
query19	1.91	1.80	1.86
query20	0.02	0.01	0.02
query21	15.45	0.28	0.15
query22	4.91	0.04	0.04
query23	16.12	0.29	0.10
query24	1.71	0.59	0.30
query25	0.08	0.06	0.06
query26	0.14	0.12	0.13
query27	0.07	0.06	0.04
query28	3.90	1.23	1.04
query29	12.58	4.01	3.24
query30	0.28	0.14	0.12
query31	2.83	0.65	0.39
query32	3.24	0.57	0.45
query33	3.06	2.99	3.06
query34	16.62	5.26	4.52
query35	4.58	4.58	4.57
query36	0.65	0.51	0.48
query37	0.11	0.07	0.06
query38	0.07	0.04	0.03
query39	0.04	0.03	0.03
query40	0.18	0.14	0.14
query41	0.09	0.03	0.03
query42	0.03	0.03	0.03
query43	0.04	0.04	0.03
Total cold run time: 97.72 s
Total hot run time: 27.3 s

doris-robot avatar Dec 16 '25 03:12 doris-robot

BE UT Coverage Report

Increment line coverage 0.00% (0/3) :tada:

Increment coverage report Complete coverage report

Category Coverage
Function Coverage 53.43% (18845/35271)
Line Coverage 39.21% (174407/444819)
Region Coverage 33.83% (134952/398965)
Branch Coverage 34.77% (58079/167017)

doris-robot avatar Dec 16 '25 04:12 doris-robot

BE Regression && UT Coverage Report

Increment line coverage 100.00% (3/3) :tada:

Increment coverage report Complete coverage report

Category Coverage
Function Coverage 72.29% (24987/34564)
Line Coverage 59.10% (262538/444205)
Region Coverage 54.00% (217922/403594)
Branch Coverage 55.56% (93243/167830)

hello-stephen avatar Dec 16 '25 05:12 hello-stephen

PR approved by at least one committer and no changes requested.

github-actions[bot] avatar Dec 16 '25 09:12 github-actions[bot]

PR approved by anyone and no changes requested.

github-actions[bot] avatar Dec 16 '25 09:12 github-actions[bot]