doris icon indicating copy to clipboard operation
doris copied to clipboard
verified publisher icon apache

[fix](system-table)add permission check for schema table

Open koarz opened this issue 6 months ago • 32 comments

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • [ ] Regression test
    • [ ] Unit Test
    • [ ] Manual test (add detailed scripts or steps below)
    • [ ] No need to test or manual test. Explain why:
      • [ ] This is a refactor/code format and no logic has been changed.
      • [ ] Previous test can cover this change.
      • [ ] No code files have been changed.
      • [ ] Other reason

  • Behavior changed:

    • [ ] No.
    • [ ] Yes.

  • Does this need documentation?

    • [ ] No.
    • [ ] Yes.

Check List (For Reviewer who merge this PR)

  • [ ] Confirm the release note
  • [ ] Confirm test cases
  • [ ] Confirm document
  • [ ] Add branch pick label

koarz avatar Jun 30 '25 09:06 koarz

run buildall

koarz avatar Jun 30 '25 09:06 koarz

run buildall

koarz avatar Jul 01 '25 04:07 koarz

run buildall

koarz avatar Jul 03 '25 03:07 koarz

run buildall

koarz avatar Jul 03 '25 06:07 koarz

run buildall

koarz avatar Jul 03 '25 07:07 koarz

run buildall

koarz avatar Jul 03 '25 08:07 koarz

run buildall

koarz avatar Jul 03 '25 09:07 koarz

run performance

koarz avatar Jul 04 '25 02:07 koarz

run nonConcurrent

koarz avatar Jul 04 '25 02:07 koarz

TPC-H: Total hot run time: 33542 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 54dc75866b27be62d346090be04d2e33ebf5c890, data reload: false

------ Round 1 ----------------------------------
q1	17585	5170	4986	4986
q2	1969	278	189	189
q3	10797	1346	748	748
q4	10337	1015	506	506
q5	8354	2566	2291	2291
q6	183	160	127	127
q7	910	736	596	596
q8	9289	1294	1071	1071
q9	6871	5028	5092	5028
q10	6910	2395	1954	1954
q11	491	295	271	271
q12	341	348	206	206
q13	17773	3766	3069	3069
q14	227	229	206	206
q15	563	479	480	479
q16	418	414	378	378
q17	602	862	352	352
q18	7709	7046	7015	7015
q19	1497	957	546	546
q20	318	350	220	220
q21	3790	3271	2344	2344
q22	1030	1011	960	960
Total cold run time: 107964 ms
Total hot run time: 33542 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5129	5066	5084	5066
q2	241	325	222	222
q3	2143	2664	2271	2271
q4	1408	1815	1363	1363
q5	4202	4556	4514	4514
q6	219	167	128	128
q7	1989	1976	1759	1759
q8	2648	2581	2607	2581
q9	7393	7322	7207	7207
q10	3165	3336	2824	2824
q11	581	513	491	491
q12	675	778	642	642
q13	3711	4038	3288	3288
q14	280	317	268	268
q15	519	468	479	468
q16	462	649	444	444
q17	1189	1530	1414	1414
q18	8015	7716	7556	7556
q19	806	801	912	801
q20	2048	1973	1799	1799
q21	4770	4398	4402	4398
q22	1044	1020	959	959
Total cold run time: 52637 ms
Total hot run time: 50463 ms

doris-robot avatar Jul 04 '25 03:07 doris-robot

TPC-DS: Total hot run time: 184254 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 54dc75866b27be62d346090be04d2e33ebf5c890, data reload: false

query1	1007	384	376	376
query2	6549	1687	1720	1687
query3	6747	216	217	216
query4	26408	23806	23031	23031
query5	4319	582	428	428
query6	306	221	212	212
query7	4611	488	304	304
query8	285	215	199	199
query9	8599	2607	2620	2607
query10	448	325	257	257
query11	15674	15140	14907	14907
query12	159	105	99	99
query13	1649	534	412	412
query14	8481	5592	5559	5559
query15	204	190	172	172
query16	7133	605	478	478
query17	956	718	578	578
query18	1966	392	292	292
query19	186	189	154	154
query20	117	116	110	110
query21	210	125	112	112
query22	4307	4116	4045	4045
query23	33859	32895	33134	32895
query24	8482	2336	2359	2336
query25	543	478	390	390
query26	1232	271	142	142
query27	2779	514	345	345
query28	4352	2112	2128	2112
query29	787	564	441	441
query30	295	216	189	189
query31	898	794	782	782
query32	70	63	58	58
query33	559	352	303	303
query34	807	840	525	525
query35	785	822	733	733
query36	1006	1002	905	905
query37	117	102	79	79
query38	4137	4129	4084	4084
query39	1519	1418	1424	1418
query40	206	115	104	104
query41	57	54	56	54
query42	132	120	103	103
query43	482	516	484	484
query44	1312	841	816	816
query45	177	174	163	163
query46	846	1007	616	616
query47	1763	1759	1692	1692
query48	390	436	324	324
query49	738	516	393	393
query50	671	688	421	421
query51	4169	4159	4155	4155
query52	114	102	95	95
query53	232	262	184	184
query54	569	572	502	502
query55	83	82	87	82
query56	296	286	275	275
query57	1154	1201	1129	1129
query58	264	252	260	252
query59	2580	2726	2486	2486
query60	327	327	322	322
query61	149	144	141	141
query62	806	726	663	663
query63	225	199	192	192
query64	4463	1082	741	741
query65	4273	4245	4201	4201
query66	1136	413	296	296
query67	15649	15361	15412	15361
query68	7934	881	516	516
query69	474	302	268	268
query70	1187	1111	1104	1104
query71	435	321	302	302
query72	5652	4865	4851	4851
query73	683	644	345	345
query74	9121	9027	8673	8673
query75	3490	3170	2701	2701
query76	3383	1143	709	709
query77	789	396	285	285
query78	9959	10081	9240	9240
query79	2261	814	591	591
query80	653	516	441	441
query81	505	256	217	217
query82	449	127	91	91
query83	264	245	242	242
query84	300	112	91	91
query85	774	352	308	308
query86	377	297	299	297
query87	4393	4461	4323	4323
query88	3770	2300	2273	2273
query89	385	318	285	285
query90	1881	210	215	210
query91	139	141	110	110
query92	76	61	56	56
query93	1899	933	588	588
query94	674	413	282	282
query95	371	297	285	285
query96	501	635	281	281
query97	2714	2783	2629	2629
query98	231	206	199	199
query99	1341	1407	1242	1242
Total cold run time: 272876 ms
Total hot run time: 184254 ms

doris-robot avatar Jul 04 '25 03:07 doris-robot

ClickBench: Total hot run time: 29.07 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 54dc75866b27be62d346090be04d2e33ebf5c890, data reload: false

query1	0.05	0.04	0.03
query2	0.08	0.04	0.04
query3	0.24	0.08	0.08
query4	1.60	0.11	0.11
query5	0.44	0.43	0.43
query6	1.16	0.66	0.65
query7	0.03	0.02	0.01
query8	0.04	0.04	0.03
query9	0.60	0.51	0.52
query10	0.58	0.57	0.58
query11	0.16	0.12	0.11
query12	0.15	0.12	0.12
query13	0.63	0.60	0.60
query14	0.79	0.82	0.82
query15	0.90	0.88	0.88
query16	0.39	0.38	0.39
query17	1.04	1.05	1.08
query18	0.23	0.22	0.22
query19	1.90	1.79	1.84
query20	0.02	0.01	0.01
query21	15.40	0.90	0.56
query22	0.75	1.22	0.61
query23	14.99	1.41	0.61
query24	7.48	0.72	0.30
query25	0.27	0.18	0.14
query26	0.63	0.16	0.13
query27	0.07	0.06	0.05
query28	8.87	0.97	0.45
query29	12.53	3.97	3.31
query30	0.25	0.10	0.06
query31	2.85	0.64	0.39
query32	3.24	0.56	0.47
query33	3.04	3.07	3.13
query34	16.03	5.44	4.80
query35	4.84	4.86	4.85
query36	0.69	0.50	0.50
query37	0.09	0.07	0.07
query38	0.05	0.04	0.04
query39	0.03	0.03	0.02
query40	0.18	0.14	0.13
query41	0.08	0.02	0.02
query42	0.03	0.02	0.03
query43	0.04	0.03	0.03
Total cold run time: 103.46 s
Total hot run time: 29.07 s

doris-robot avatar Jul 04 '25 03:07 doris-robot

PR approved by at least one committer and no changes requested.

github-actions[bot] avatar Jul 08 '25 01:07 github-actions[bot]

PR approved by anyone and no changes requested.

github-actions[bot] avatar Jul 08 '25 01:07 github-actions[bot]

run buildall

koarz avatar Jul 18 '25 10:07 koarz

run buildall

koarz avatar Jul 18 '25 10:07 koarz

Cloud UT Coverage Report

Increment line coverage :tada:

Increment coverage report Complete coverage report

Category Coverage
Function Coverage 80.36% (1297/1614)
Line Coverage 65.79% (21707/32992)
Region Coverage 67.11% (10903/16247)
Branch Coverage 56.71% (5736/10114)

doris-robot avatar Jul 18 '25 11:07 doris-robot

BE UT Coverage Report

Increment line coverage 0.00% (0/14) :tada:

Increment coverage report Complete coverage report

Category Coverage
Function Coverage 57.44% (15771/27457)
Line Coverage 46.19% (141882/307143)
Region Coverage 35.66% (106805/299530)
Branch Coverage 38.16% (47154/123577)

hello-stephen avatar Jul 18 '25 15:07 hello-stephen

run buildall

koarz avatar Jul 20 '25 05:07 koarz

Cloud UT Coverage Report

Increment line coverage :tada:

Increment coverage report Complete coverage report

Category Coverage
Function Coverage 80.36% (1297/1614)
Line Coverage 65.71% (21707/33035)
Region Coverage 67.06% (10915/16276)
Branch Coverage 56.60% (5740/10142)

hello-stephen avatar Jul 20 '25 05:07 hello-stephen

run buildall

koarz avatar Jul 20 '25 08:07 koarz

Cloud UT Coverage Report

Increment line coverage :tada:

Increment coverage report Complete coverage report

Category Coverage
Function Coverage 80.36% (1297/1614)
Line Coverage 65.74% (21717/33035)
Region Coverage 67.09% (10920/16276)
Branch Coverage 56.60% (5740/10142)

hello-stephen avatar Jul 20 '25 09:07 hello-stephen

BE UT Coverage Report

Increment line coverage 0.00% (0/14) :tada:

Increment coverage report Complete coverage report

Category Coverage
Function Coverage 57.42% (15761/27448)
Line Coverage 46.16% (141732/307017)
Region Coverage 35.70% (106881/299414)
Branch Coverage 38.17% (47165/123558)

doris-robot avatar Jul 20 '25 12:07 doris-robot

run buildall

koarz avatar Jul 20 '25 15:07 koarz

Cloud UT Coverage Report

Increment line coverage :tada:

Increment coverage report Complete coverage report

Category Coverage
Function Coverage 80.36% (1297/1614)
Line Coverage 65.74% (21717/33035)
Region Coverage 67.09% (10920/16276)
Branch Coverage 56.62% (5742/10142)

hello-stephen avatar Jul 20 '25 15:07 hello-stephen

FE UT Coverage Report

Increment line coverage 14.29% (1/7) :tada: Increment coverage report Complete coverage report

hello-stephen avatar Jul 20 '25 16:07 hello-stephen

TPC-H: Total hot run time: 34415 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit e5fb92a2171e86e7c0ea7490ecfe2f3a18e5dfbc, data reload: false

------ Round 1 ----------------------------------
q1	17698	5249	5088	5088
q2	1958	299	204	204
q3	10591	1335	722	722
q4	10278	1061	540	540
q5	7954	2502	2365	2365
q6	195	192	140	140
q7	948	765	630	630
q8	9340	1332	1208	1208
q9	7611	5138	5181	5138
q10	6939	2451	1982	1982
q11	490	298	283	283
q12	359	362	222	222
q13	17785	3699	3143	3143
q14	242	249	230	230
q15	572	501	511	501
q16	428	446	373	373
q17	573	897	353	353
q18	7630	7192	7227	7192
q19	1247	999	565	565
q20	362	354	226	226
q21	3743	2561	2333	2333
q22	1094	1027	977	977
Total cold run time: 108037 ms
Total hot run time: 34415 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5156	5118	5097	5097
q2	256	345	228	228
q3	2169	2667	2307	2307
q4	1331	1853	1358	1358
q5	4447	4496	4484	4484
q6	225	179	137	137
q7	1998	2095	1855	1855
q8	2615	2490	2471	2471
q9	7639	7259	7276	7259
q10	3118	3302	2844	2844
q11	587	528	499	499
q12	723	812	690	690
q13	3609	3974	3448	3448
q14	304	306	298	298
q15	547	523	507	507
q16	484	509	481	481
q17	1213	1595	1409	1409
q18	7938	7690	7465	7465
q19	823	851	836	836
q20	2180	2129	1909	1909
q21	5081	4614	4556	4556
q22	1166	1105	1000	1000
Total cold run time: 53609 ms
Total hot run time: 51138 ms

doris-robot avatar Jul 20 '25 16:07 doris-robot

TPC-DS: Total hot run time: 192205 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit e5fb92a2171e86e7c0ea7490ecfe2f3a18e5dfbc, data reload: false

query1	1004	399	439	399
query2	6563	1738	1680	1680
query3	6761	233	227	227
query4	26336	23661	23706	23661
query5	4439	709	603	603
query6	336	254	230	230
query7	4650	521	313	313
query8	375	345	330	330
query9	8646	2958	2957	2957
query10	522	371	314	314
query11	16079	15403	14769	14769
query12	185	136	133	133
query13	1704	583	463	463
query14	9801	5982	5929	5929
query15	215	201	177	177
query16	7669	661	490	490
query17	1209	773	630	630
query18	2047	447	333	333
query19	207	200	181	181
query20	144	139	137	137
query21	238	147	126	126
query22	4421	4808	4486	4486
query23	35072	34204	33742	33742
query24	8164	2359	2378	2359
query25	547	491	418	418
query26	1239	276	168	168
query27	2710	526	366	366
query28	4378	2216	2198	2198
query29	755	592	471	471
query30	298	243	202	202
query31	989	884	801	801
query32	91	83	80	80
query33	580	435	376	376
query34	819	848	542	542
query35	828	841	783	783
query36	968	1010	922	922
query37	128	113	97	97
query38	4299	4317	4145	4145
query39	1519	1482	1647	1482
query40	241	146	133	133
query41	105	100	98	98
query42	134	121	121	121
query43	498	516	490	490
query44	1352	855	867	855
query45	189	184	178	178
query46	854	1021	656	656
query47	1811	1843	1755	1755
query48	416	442	343	343
query49	796	591	465	465
query50	672	754	437	437
query51	5639	5662	5627	5627
query52	127	118	116	116
query53	250	285	212	212
query54	615	618	559	559
query55	95	92	92	92
query56	350	342	341	341
query57	1239	1238	1201	1201
query58	324	310	311	310
query59	2669	2736	2532	2532
query60	378	376	362	362
query61	150	147	203	147
query62	806	722	669	669
query63	246	207	220	207
query64	4365	1077	740	740
query65	4330	4233	4172	4172
query66	1262	591	499	499
query67	15987	15634	15452	15452
query68	9575	913	555	555
query69	511	361	330	330
query70	1274	1143	1141	1141
query71	488	370	352	352
query72	5739	4846	4930	4846
query73	766	689	377	377
query74	9369	9111	9170	9111
query75	4275	3180	2681	2681
query76	4083	1154	770	770
query77	1059	458	400	400
query78	10154	10210	9307	9307
query79	5163	831	595	595
query80	865	600	536	536
query81	478	272	247	247
query82	459	148	115	115
query83	320	288	270	270
query84	315	122	106	106
query85	803	402	361	361
query86	363	348	329	329
query87	4478	4493	4382	4382
query88	2998	2378	2358	2358
query89	459	339	311	311
query90	2099	243	238	238
query91	157	159	197	159
query92	94	85	79	79
query93	3116	973	599	599
query94	688	404	317	317
query95	421	341	337	337
query96	496	610	296	296
query97	2693	2810	2682	2682
query98	252	231	228	228
query99	1458	1435	1301	1301
Total cold run time: 288303 ms
Total hot run time: 192205 ms

doris-robot avatar Jul 20 '25 17:07 doris-robot

ClickBench: Total hot run time: 32.56 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit e5fb92a2171e86e7c0ea7490ecfe2f3a18e5dfbc, data reload: false

query1	0.04	0.03	0.03
query2	0.08	0.04	0.05
query3	0.25	0.08	0.08
query4	1.62	0.11	0.11
query5	0.43	0.43	0.40
query6	1.17	0.65	0.68
query7	0.03	0.02	0.02
query8	0.05	0.04	0.04
query9	0.60	0.52	0.53
query10	0.58	0.58	0.58
query11	0.17	0.11	0.12
query12	0.15	0.12	0.12
query13	0.63	0.62	0.61
query14	0.82	0.82	0.81
query15	0.90	0.87	0.91
query16	0.39	0.40	0.39
query17	1.05	1.06	1.04
query18	0.23	0.21	0.23
query19	2.18	1.86	1.90
query20	0.01	0.01	0.01
query21	15.38	0.93	0.53
query22	0.79	1.14	0.83
query23	14.78	1.40	0.66
query24	6.76	1.61	0.48
query25	0.54	0.12	0.18
query26	0.67	0.17	0.14
query27	0.06	0.05	0.05
query28	9.06	0.96	0.45
query29	12.70	3.96	3.26
query30	3.17	3.14	3.08
query31	2.82	0.59	0.38
query32	3.25	0.55	0.49
query33	3.10	3.08	3.14
query34	16.08	5.50	4.80
query35	4.89	4.88	4.81
query36	0.70	0.51	0.49
query37	0.10	0.08	0.08
query38	0.06	0.05	0.05
query39	0.05	0.04	0.03
query40	0.19	0.15	0.16
query41	0.09	0.04	0.03
query42	0.04	0.03	0.04
query43	0.05	0.05	0.04
Total cold run time: 106.71 s
Total hot run time: 32.56 s

doris-robot avatar Jul 20 '25 17:07 doris-robot

BE UT Coverage Report

Increment line coverage 0.00% (0/14) :tada:

Increment coverage report Complete coverage report

Category Coverage
Function Coverage 57.44% (15890/27663)
Line Coverage 46.25% (142724/308623)
Region Coverage 35.74% (107559/300925)
Branch Coverage 38.23% (47437/124087)

hello-stephen avatar Jul 20 '25 20:07 hello-stephen