doris icon indicating copy to clipboard operation
doris copied to clipboard

[feature](vec) remove reinterpret_cast , use assert_cast

Open Mryange opened this issue 1 year ago • 6 comments

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

Mryange avatar May 27 '24 08:05 Mryange

Thank you for your contribution to Apache Doris. Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website. See Doris Document.

doris-robot avatar May 27 '24 08:05 doris-robot

run buildall

Mryange avatar May 27 '24 08:05 Mryange

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar May 27 '24 08:05 github-actions[bot]

TPC-H: Total hot run time: 41915 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f936bab5dc2304db9c85eb57fe0671665c233d14, data reload: false

------ Round 1 ----------------------------------
q1	17599	5020	4272	4272
q2	2021	189	193	189
q3	10470	1259	1239	1239
q4	10200	814	798	798
q5	7495	2733	2795	2733
q6	222	132	133	132
q7	948	600	611	600
q8	9221	2146	2118	2118
q9	9447	6759	6704	6704
q10	9883	3898	3891	3891
q11	449	245	238	238
q12	498	217	239	217
q13	17331	3201	3285	3201
q14	276	215	216	215
q15	497	476	466	466
q16	490	391	395	391
q17	1005	704	760	704
q18	8409	7744	7890	7744
q19	6077	1514	1574	1514
q20	649	321	315	315
q21	5189	3952	4014	3952
q22	349	284	282	282
Total cold run time: 118725 ms
Total hot run time: 41915 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4592	4436	4361	4361
q2	385	279	261	261
q3	3119	2981	2830	2830
q4	1883	1589	1644	1589
q5	5470	5498	5520	5498
q6	217	121	130	121
q7	2246	1859	1799	1799
q8	3294	3414	3404	3404
q9	8742	8697	8648	8648
q10	3958	3769	3870	3769
q11	590	523	509	509
q12	807	598	609	598
q13	17102	3124	3266	3124
q14	320	266	279	266
q15	534	474	474	474
q16	550	445	420	420
q17	1803	1493	1504	1493
q18	7763	7566	7686	7566
q19	1674	1531	1526	1526
q20	1991	1767	1789	1767
q21	8433	4839	4585	4585
q22	574	507	489	489
Total cold run time: 76047 ms
Total hot run time: 55097 ms

doris-robot avatar May 27 '24 10:05 doris-robot

TPC-DS: Total hot run time: 172530 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit f936bab5dc2304db9c85eb57fe0671665c233d14, data reload: false

query1	915	385	387	385
query2	6429	2638	2414	2414
query3	6647	208	206	206
query4	19209	17329	17437	17329
query5	4099	414	419	414
query6	250	169	151	151
query7	4587	303	296	296
query8	242	179	177	177
query9	8476	2368	2373	2368
query10	450	284	272	272
query11	10649	10055	10177	10055
query12	133	93	89	89
query13	1649	406	365	365
query14	10072	7521	7410	7410
query15	213	168	168	168
query16	7752	273	267	267
query17	1684	528	507	507
query18	1948	280	271	271
query19	203	158	150	150
query20	88	83	83	83
query21	192	140	130	130
query22	4237	4276	4060	4060
query23	33537	33118	33001	33001
query24	6767	2905	2887	2887
query25	462	360	361	360
query26	721	155	155	155
query27	1889	319	324	319
query28	3808	2047	2039	2039
query29	833	610	597	597
query30	226	150	149	149
query31	928	761	738	738
query32	62	52	63	52
query33	517	270	272	270
query34	867	478	475	475
query35	722	588	580	580
query36	1032	940	896	896
query37	103	94	73	73
query38	2930	2779	2765	2765
query39	810	778	804	778
query40	198	126	129	126
query41	47	47	46	46
query42	103	99	97	97
query43	596	560	551	551
query44	1062	735	741	735
query45	179	164	167	164
query46	1058	715	699	699
query47	1832	1830	1800	1800
query48	377	297	313	297
query49	787	388	381	381
query50	768	385	392	385
query51	6869	6820	6726	6726
query52	101	96	86	86
query53	360	286	297	286
query54	534	441	434	434
query55	74	75	71	71
query56	266	269	242	242
query57	1100	1056	1027	1027
query58	223	207	201	201
query59	3399	3084	3345	3084
query60	277	255	267	255
query61	94	88	90	88
query62	540	447	452	447
query63	309	286	288	286
query64	2522	1870	1774	1774
query65	3200	3101	3083	3083
query66	810	328	321	321
query67	15413	15109	14694	14694
query68	4544	531	544	531
query69	441	268	266	266
query70	1133	1141	1136	1136
query71	354	263	269	263
query72	7636	5351	5103	5103
query73	735	321	327	321
query74	5954	5695	5613	5613
query75	3312	2631	2603	2603
query76	2338	1027	960	960
query77	415	262	265	262
query78	10308	9860	9777	9777
query79	2536	512	518	512
query80	1059	430	437	430
query81	513	223	219	219
query82	708	93	91	91
query83	241	173	172	172
query84	247	85	86	85
query85	1234	274	256	256
query86	477	277	291	277
query87	3313	3128	3133	3128
query88	4064	2454	2493	2454
query89	474	396	384	384
query90	2059	195	188	188
query91	126	97	96	96
query92	118	48	47	47
query93	2106	501	488	488
query94	1125	194	183	183
query95	405	313	306	306
query96	602	275	282	275
query97	3211	3026	2991	2991
query98	239	214	208	208
query99	1147	818	854	818
Total cold run time: 252610 ms
Total hot run time: 172530 ms

doris-robot avatar May 27 '24 10:05 doris-robot

ClickBench: Total hot run time: 30.5 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit f936bab5dc2304db9c85eb57fe0671665c233d14, data reload: false

query1	0.04	0.03	0.03
query2	0.08	0.04	0.04
query3	0.24	0.06	0.06
query4	1.64	0.10	0.08
query5	0.52	0.51	0.51
query6	1.13	0.71	0.72
query7	0.02	0.01	0.01
query8	0.04	0.04	0.04
query9	0.54	0.48	0.48
query10	0.53	0.55	0.55
query11	0.17	0.12	0.11
query12	0.16	0.12	0.13
query13	0.60	0.59	0.58
query14	0.76	0.78	0.78
query15	0.84	0.82	0.80
query16	0.37	0.36	0.37
query17	1.02	1.02	0.96
query18	0.21	0.25	0.22
query19	1.91	1.78	1.80
query20	0.02	0.01	0.01
query21	15.42	0.72	0.71
query22	4.60	6.96	1.73
query23	18.48	1.37	1.29
query24	1.84	0.35	0.19
query25	0.15	0.09	0.08
query26	0.26	0.16	0.16
query27	0.08	0.08	0.09
query28	13.29	1.01	1.01
query29	13.27	3.32	3.30
query30	0.24	0.06	0.06
query31	2.86	0.39	0.39
query32	3.28	0.47	0.46
query33	2.86	2.91	2.92
query34	17.01	4.47	4.45
query35	4.53	4.41	4.56
query36	0.66	0.46	0.48
query37	0.16	0.16	0.15
query38	0.15	0.14	0.14
query39	0.05	0.03	0.04
query40	0.17	0.15	0.14
query41	0.09	0.05	0.05
query42	0.05	0.04	0.04
query43	0.03	0.03	0.04
Total cold run time: 110.37 s
Total hot run time: 30.5 s

doris-robot avatar May 27 '24 10:05 doris-robot