doris icon indicating copy to clipboard operation
doris copied to clipboard

[fix](SenderQueue) error memlimt in add/sub _blocks_memory_usage

Open Mryange opened this issue 1 year ago • 10 comments

Proposed changes

Multiple queues will compete for the value of _recvr; here, each queue will maintain its own value instead.

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

Mryange avatar May 27 '24 05:05 Mryange

Thank you for your contribution to Apache Doris. Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website. See Doris Document.

doris-robot avatar May 27 '24 05:05 doris-robot

run buildall

Mryange avatar May 27 '24 05:05 Mryange

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar May 27 '24 05:05 github-actions[bot]

run buildall

Mryange avatar May 27 '24 06:05 Mryange

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar May 27 '24 06:05 github-actions[bot]

TPC-H: Total hot run time: 41673 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit a0f9e50f2ab5ec26ff236bfbda61a604a97207be, data reload: false

------ Round 1 ----------------------------------
q1	18075	4354	4231	4231
q2	2027	183	190	183
q3	10550	1179	1249	1179
q4	10228	825	882	825
q5	7487	2718	2703	2703
q6	221	132	132	132
q7	952	605	598	598
q8	9210	2125	2103	2103
q9	9376	6658	6629	6629
q10	9093	3917	3915	3915
q11	470	248	238	238
q12	457	222	237	222
q13	17199	3322	3221	3221
q14	280	227	238	227
q15	532	485	474	474
q16	510	404	394	394
q17	998	612	660	612
q18	8373	7840	7658	7658
q19	7186	1561	1523	1523
q20	667	329	313	313
q21	5162	4054	4009	4009
q22	352	286	284	284
Total cold run time: 119405 ms
Total hot run time: 41673 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4484	4426	4433	4426
q2	378	270	264	264
q3	3103	2930	2884	2884
q4	1953	1716	1605	1605
q5	5295	5493	5529	5493
q6	221	125	125	125
q7	2174	1869	1822	1822
q8	3252	3373	3397	3373
q9	8647	8618	8668	8618
q10	4029	3879	3764	3764
q11	591	495	475	475
q12	787	647	616	616
q13	17139	3132	3203	3132
q14	310	270	260	260
q15	515	492	494	492
q16	505	453	441	441
q17	1853	1534	1536	1534
q18	7903	7625	7448	7448
q19	1660	1474	1555	1474
q20	2021	1784	1803	1784
q21	11627	4653	4844	4653
q22	554	490	513	490
Total cold run time: 79001 ms
Total hot run time: 55173 ms

doris-robot avatar May 27 '24 06:05 doris-robot

TPC-DS: Total hot run time: 169399 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit a0f9e50f2ab5ec26ff236bfbda61a604a97207be, data reload: false

query1	914	376	367	367
query2	6445	2422	2248	2248
query3	6637	203	200	200
query4	20342	17825	17374	17374
query5	4159	420	417	417
query6	252	171	153	153
query7	4581	300	291	291
query8	238	176	200	176
query9	8479	2370	2348	2348
query10	450	303	269	269
query11	10589	10160	9971	9971
query12	131	93	91	91
query13	1636	362	358	358
query14	10024	7441	7402	7402
query15	203	163	162	162
query16	7740	265	264	264
query17	1511	517	519	517
query18	1943	271	268	268
query19	188	152	154	152
query20	92	84	84	84
query21	196	156	128	128
query22	4234	3813	3976	3813
query23	33637	33060	33065	33060
query24	9038	2837	2836	2836
query25	568	369	354	354
query26	703	159	153	153
query27	2236	309	320	309
query28	5438	2027	2041	2027
query29	862	609	596	596
query30	238	148	155	148
query31	973	786	766	766
query32	92	52	58	52
query33	642	286	275	275
query34	854	470	471	470
query35	752	613	618	613
query36	1069	917	925	917
query37	102	70	71	70
query38	2871	2769	2755	2755
query39	853	769	779	769
query40	197	126	126	126
query41	47	44	47	44
query42	101	94	97	94
query43	587	551	545	545
query44	1081	739	749	739
query45	176	167	168	167
query46	1057	698	708	698
query47	1869	1780	1789	1780
query48	381	294	296	294
query49	852	374	386	374
query50	762	375	388	375
query51	6987	6787	6776	6776
query52	99	92	85	85
query53	349	280	283	280
query54	750	436	432	432
query55	71	71	71	71
query56	269	268	257	257
query57	1106	1076	1041	1041
query58	231	207	228	207
query59	3533	3163	3395	3163
query60	276	267	265	265
query61	89	90	90	90
query62	595	442	462	442
query63	312	281	279	279
query64	8471	2237	1682	1682
query65	3209	3071	3107	3071
query66	782	344	321	321
query67	15261	14713	14694	14694
query68	4546	517	535	517
query69	440	269	265	265
query70	1164	1158	1127	1127
query71	387	277	263	263
query72	7631	5241	2716	2716
query73	714	319	317	317
query74	6040	5557	5576	5557
query75	3378	2642	2631	2631
query76	2315	1005	916	916
query77	397	268	262	262
query78	10139	9783	9659	9659
query79	2479	502	506	502
query80	1064	446	433	433
query81	546	219	219	219
query82	729	92	92	92
query83	263	169	166	166
query84	243	90	85	85
query85	1632	279	275	275
query86	505	319	268	268
query87	3301	3068	3176	3068
query88	4303	2443	2439	2439
query89	469	392	379	379
query90	2021	191	193	191
query91	137	109	107	107
query92	72	50	53	50
query93	2109	503	492	492
query94	1327	188	184	184
query95	399	319	314	314
query96	601	271	266	266
query97	3156	2963	3071	2963
query98	256	216	217	216
query99	1122	855	845	845
Total cold run time: 265297 ms
Total hot run time: 169399 ms

doris-robot avatar May 27 '24 06:05 doris-robot

ClickBench: Total hot run time: 30.04 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit a0f9e50f2ab5ec26ff236bfbda61a604a97207be, data reload: false

query1	0.04	0.04	0.03
query2	0.09	0.04	0.04
query3	0.23	0.05	0.06
query4	1.71	0.07	0.07
query5	0.50	0.49	0.50
query6	1.13	0.71	0.72
query7	0.02	0.02	0.02
query8	0.05	0.04	0.04
query9	0.54	0.48	0.49
query10	0.53	0.56	0.55
query11	0.15	0.12	0.11
query12	0.14	0.12	0.12
query13	0.58	0.59	0.61
query14	0.75	0.80	0.77
query15	0.82	0.83	0.81
query16	0.36	0.37	0.37
query17	0.97	1.03	1.02
query18	0.24	0.24	0.24
query19	1.82	1.67	1.66
query20	0.02	0.01	0.00
query21	15.56	0.65	0.64
query22	4.69	7.43	1.50
query23	18.32	1.42	1.22
query24	1.66	0.23	0.26
query25	0.15	0.08	0.09
query26	0.27	0.17	0.18
query27	0.08	0.08	0.07
query28	13.42	1.02	0.99
query29	13.28	3.33	3.26
query30	0.24	0.06	0.05
query31	2.86	0.38	0.40
query32	3.29	0.47	0.46
query33	2.90	2.93	2.91
query34	17.14	4.39	4.44
query35	4.50	4.48	4.53
query36	0.71	0.47	0.46
query37	0.17	0.15	0.15
query38	0.15	0.14	0.15
query39	0.04	0.04	0.03
query40	0.16	0.15	0.15
query41	0.08	0.05	0.04
query42	0.06	0.04	0.05
query43	0.04	0.03	0.04
Total cold run time: 110.46 s
Total hot run time: 30.04 s

doris-robot avatar May 27 '24 06:05 doris-robot

TeamCity be ut coverage result: Function Coverage: 35.74% (9008/25207) Line Coverage: 27.37% (74565/272461) Region Coverage: 26.59% (38575/145099) Branch Coverage: 23.44% (19669/83900) Coverage Report: http://coverage.selectdb-in.cc/coverage/a0f9e50f2ab5ec26ff236bfbda61a604a97207be_a0f9e50f2ab5ec26ff236bfbda61a604a97207be/report/index.html

doris-robot avatar May 27 '24 07:05 doris-robot

run p0

Mryange avatar May 27 '24 08:05 Mryange

run buildall

Mryange avatar May 28 '24 06:05 Mryange

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar May 28 '24 06:05 github-actions[bot]

run buildall

Mryange avatar May 28 '24 08:05 Mryange

TPC-H: Total hot run time: 40248 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f9e4f14e5d1ae9c829374f79dffa4caf90617470, data reload: false

------ Round 1 ----------------------------------
q1	17919	5521	4447	4447
q2	2520	196	212	196
q3	10880	1214	1187	1187
q4	10522	775	729	729
q5	7493	2718	2698	2698
q6	219	133	133	133
q7	965	648	594	594
q8	9325	2112	2108	2108
q9	9125	6520	6519	6519
q10	8981	3719	3715	3715
q11	447	259	241	241
q12	484	224	221	221
q13	17865	2956	3019	2956
q14	262	216	219	216
q15	510	469	476	469
q16	520	379	377	377
q17	956	723	668	668
q18	8012	7453	7436	7436
q19	5230	1567	1504	1504
q20	677	315	320	315
q21	4973	3932	3242	3242
q22	349	277	279	277
Total cold run time: 118234 ms
Total hot run time: 40248 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4368	4239	4221	4221
q2	378	264	267	264
q3	2985	2774	2769	2769
q4	1900	1626	1561	1561
q5	5258	5310	5290	5290
q6	209	123	123	123
q7	2116	1774	1735	1735
q8	3200	3293	3305	3293
q9	8352	8374	8366	8366
q10	3905	3693	3701	3693
q11	625	492	510	492
q12	760	583	603	583
q13	17222	3040	2996	2996
q14	302	256	267	256
q15	518	476	482	476
q16	482	428	430	428
q17	1794	1512	1470	1470
q18	7655	7697	7357	7357
q19	1711	1553	1573	1553
q20	1980	1747	1778	1747
q21	4878	4875	4761	4761
q22	573	496	491	491
Total cold run time: 71171 ms
Total hot run time: 53925 ms

doris-robot avatar May 28 '24 09:05 doris-robot

TPC-DS: Total hot run time: 172870 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit f9e4f14e5d1ae9c829374f79dffa4caf90617470, data reload: false

query1	931	395	378	378
query2	6449	2424	2443	2424
query3	6655	203	202	202
query4	19746	17371	17201	17201
query5	4131	412	418	412
query6	241	154	174	154
query7	4590	298	289	289
query8	249	181	182	181
query9	8794	2461	2471	2461
query10	450	298	253	253
query11	10618	10049	10110	10049
query12	135	87	92	87
query13	1675	362	368	362
query14	9363	7637	7593	7593
query15	252	176	165	165
query16	8087	258	259	258
query17	1870	515	531	515
query18	1968	290	272	272
query19	203	157	153	153
query20	93	91	84	84
query21	201	137	127	127
query22	4143	4049	4007	4007
query23	33699	32949	32930	32930
query24	12091	2870	2813	2813
query25	638	347	358	347
query26	1732	153	154	153
query27	2974	327	326	326
query28	7592	2074	2083	2074
query29	998	603	588	588
query30	288	147	152	147
query31	968	769	773	769
query32	104	54	55	54
query33	794	268	260	260
query34	1063	468	492	468
query35	734	632	592	592
query36	1098	926	917	917
query37	278	65	65	65
query38	2854	2746	2707	2707
query39	839	793	789	789
query40	276	123	121	121
query41	46	47	45	45
query42	101	98	93	93
query43	597	571	522	522
query44	1235	723	740	723
query45	180	165	157	157
query46	1064	743	733	733
query47	1848	1782	1760	1760
query48	367	292	307	292
query49	1181	417	380	380
query50	775	391	391	391
query51	6745	6818	6769	6769
query52	104	89	87	87
query53	352	286	295	286
query54	1015	455	431	431
query55	71	71	70	70
query56	258	242	239	239
query57	1124	1042	1045	1042
query58	233	214	205	205
query59	3393	3320	3138	3138
query60	282	268	259	259
query61	103	100	137	100
query62	652	443	462	443
query63	307	282	288	282
query64	9790	2201	1748	1748
query65	3199	3121	3134	3121
query66	1346	390	334	334
query67	15282	14953	14806	14806
query68	4459	554	549	549
query69	426	270	269	269
query70	1159	1097	1162	1097
query71	401	270	273	270
query72	7587	5400	5376	5376
query73	721	327	335	327
query74	5901	5586	5584	5584
query75	3376	2662	2606	2606
query76	2737	1037	1075	1037
query77	426	274	269	269
query78	10120	9785	9626	9626
query79	2217	510	509	509
query80	1312	440	431	431
query81	486	219	227	219
query82	743	94	89	89
query83	199	180	198	180
query84	276	90	91	90
query85	1504	272	267	267
query86	411	293	308	293
query87	3343	3061	3092	3061
query88	4206	2433	2455	2433
query89	484	395	382	382
query90	2035	189	187	187
query91	127	98	101	98
query92	60	50	50	50
query93	3483	528	520	520
query94	1158	186	186	186
query95	420	329	318	318
query96	598	275	269	269
query97	3168	3038	3067	3038
query98	244	226	214	214
query99	1246	846	823	823
Total cold run time: 276547 ms
Total hot run time: 172870 ms

doris-robot avatar May 28 '24 09:05 doris-robot

ClickBench: Total hot run time: 30.34 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit f9e4f14e5d1ae9c829374f79dffa4caf90617470, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.04	0.04
query3	0.23	0.05	0.05
query4	1.68	0.08	0.09
query5	0.52	0.48	0.50
query6	1.11	0.73	0.74
query7	0.01	0.01	0.01
query8	0.05	0.04	0.04
query9	0.54	0.49	0.50
query10	0.55	0.54	0.56
query11	0.16	0.11	0.11
query12	0.15	0.12	0.12
query13	0.60	0.59	0.59
query14	0.78	0.81	0.78
query15	0.83	0.81	0.81
query16	0.36	0.35	0.36
query17	0.93	0.96	0.96
query18	0.23	0.22	0.27
query19	1.86	1.70	1.64
query20	0.01	0.01	0.01
query21	15.74	0.66	0.65
query22	5.00	6.72	1.78
query23	18.31	1.38	1.25
query24	1.77	0.26	0.21
query25	0.13	0.10	0.08
query26	0.25	0.17	0.17
query27	0.08	0.08	0.07
query28	13.30	1.01	0.99
query29	13.20	3.26	3.25
query30	0.24	0.06	0.05
query31	2.87	0.38	0.37
query32	3.30	0.48	0.48
query33	2.91	2.93	2.93
query34	16.94	4.40	4.44
query35	4.49	4.55	4.56
query36	0.65	0.45	0.47
query37	0.17	0.16	0.15
query38	0.15	0.15	0.15
query39	0.04	0.04	0.03
query40	0.17	0.13	0.14
query41	0.09	0.04	0.05
query42	0.05	0.05	0.04
query43	0.04	0.04	0.04
Total cold run time: 110.59 s
Total hot run time: 30.34 s

doris-robot avatar May 28 '24 09:05 doris-robot

TeamCity be ut coverage result: Function Coverage: 35.76% (9002/25175) Line Coverage: 27.38% (74536/272182) Region Coverage: 26.61% (38562/144931) Branch Coverage: 23.47% (19662/83784) Coverage Report: http://coverage.selectdb-in.cc/coverage/f9e4f14e5d1ae9c829374f79dffa4caf90617470_f9e4f14e5d1ae9c829374f79dffa4caf90617470/report/index.html

doris-robot avatar May 28 '24 09:05 doris-robot

run cloud_p1

Mryange avatar May 28 '24 12:05 Mryange

PR approved by at least one committer and no changes requested.

github-actions[bot] avatar May 29 '24 08:05 github-actions[bot]

PR approved by anyone and no changes requested.

github-actions[bot] avatar May 29 '24 08:05 github-actions[bot]