[fix](ubsan) fix some Undefined behavior
Proposed changes
Issue Number: close #xxx
Further comments
If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...
Thank you for your contribution to Apache Doris. Don't know what should be done next? See How to process your PR
Since 2024-03-18, the Document has been moved to doris-website. See Doris Document.
run buildall
run buildall
clang-tidy review says "All clean, LGTM! :+1:"
TPC-H: Total hot run time: 42099 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 754c394b582369e2ffaff795fd5166058431028d, data reload: false
------ Round 1 ----------------------------------
q1 17629 4335 4239 4239
q2 2026 193 193 193
q3 10454 1274 1286 1274
q4 10206 842 844 842
q5 7489 2752 2661 2661
q6 224 133 131 131
q7 978 613 622 613
q8 9225 2158 2116 2116
q9 9139 6701 6714 6701
q10 9253 3912 3945 3912
q11 471 249 261 249
q12 478 231 234 231
q13 17256 3389 3131 3131
q14 291 213 226 213
q15 518 466 488 466
q16 494 406 397 397
q17 994 621 715 621
q18 8401 7852 7915 7852
q19 4294 1548 1560 1548
q20 655 330 332 330
q21 5161 4195 4094 4094
q22 371 292 285 285
Total cold run time: 116007 ms
Total hot run time: 42099 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4457 4446 4393 4393
q2 382 280 269 269
q3 3158 2902 2893 2893
q4 2067 1685 1609 1609
q5 5354 5499 5482 5482
q6 218 119 123 119
q7 2232 1838 1796 1796
q8 3207 3435 3405 3405
q9 8627 8632 8669 8632
q10 4056 3800 3679 3679
q11 587 509 490 490
q12 810 622 619 619
q13 16138 3119 3172 3119
q14 316 285 277 277
q15 518 477 463 463
q16 525 447 448 447
q17 1835 1507 1537 1507
q18 7894 7788 7561 7561
q19 1673 1592 1529 1529
q20 1993 1815 1787 1787
q21 5085 4704 4594 4594
q22 563 492 503 492
Total cold run time: 71695 ms
Total hot run time: 55162 ms
TeamCity be ut coverage result: Function Coverage: 35.65% (9017/25294) Line Coverage: 27.32% (74572/272967) Region Coverage: 26.53% (38578/145413) Branch Coverage: 23.39% (19666/84080) Coverage Report: http://coverage.selectdb-in.cc/coverage/754c394b582369e2ffaff795fd5166058431028d_754c394b582369e2ffaff795fd5166058431028d/report/index.html
TPC-DS: Total hot run time: 168014 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 754c394b582369e2ffaff795fd5166058431028d, data reload: false
query1 912 383 367 367
query2 6426 2431 2431 2431
query3 6653 202 205 202
query4 20296 17347 17587 17347
query5 4104 417 420 417
query6 239 173 161 161
query7 4584 299 290 290
query8 241 180 186 180
query9 8689 2402 2378 2378
query10 458 286 272 272
query11 10603 10027 10083 10027
query12 132 86 87 86
query13 1649 357 351 351
query14 9581 6262 8396 6262
query15 211 173 171 171
query16 7511 256 253 253
query17 1343 510 513 510
query18 1937 267 263 263
query19 213 156 158 156
query20 91 88 88 88
query21 191 129 125 125
query22 4320 3861 3863 3861
query23 33597 33074 33133 33074
query24 5097 2713 2846 2713
query25 485 366 365 365
query26 696 154 156 154
query27 1842 304 311 304
query28 3763 2045 2067 2045
query29 828 611 584 584
query30 248 169 188 169
query31 939 742 740 740
query32 60 51 55 51
query33 453 278 277 277
query34 859 483 473 473
query35 734 647 606 606
query36 1055 906 891 891
query37 113 73 74 73
query38 2891 2746 2749 2746
query39 850 787 792 787
query40 194 129 121 121
query41 45 43 42 42
query42 109 94 97 94
query43 562 560 543 543
query44 1106 733 739 733
query45 176 162 163 162
query46 1054 719 722 719
query47 1849 1768 1775 1768
query48 375 296 296 296
query49 764 368 380 368
query50 773 376 384 376
query51 6909 6707 6692 6692
query52 105 89 93 89
query53 344 277 282 277
query54 531 431 413 413
query55 76 72 71 71
query56 289 239 241 239
query57 1099 1065 1025 1025
query58 221 210 232 210
query59 3462 3067 3292 3067
query60 270 247 273 247
query61 93 90 87 87
query62 563 442 440 440
query63 312 279 275 275
query64 2574 1714 1664 1664
query65 3173 3063 3108 3063
query66 729 344 318 318
query67 15023 14598 14895 14598
query68 4550 528 528 528
query69 451 268 266 266
query70 1159 1104 1090 1090
query71 396 267 257 257
query72 7234 2720 2558 2558
query73 702 317 314 314
query74 6001 5616 5702 5616
query75 3298 2586 2608 2586
query76 2249 1001 987 987
query77 396 263 261 261
query78 10256 9910 9719 9719
query79 1609 503 508 503
query80 868 425 422 422
query81 519 243 246 243
query82 791 94 98 94
query83 237 167 168 167
query84 249 85 82 82
query85 848 267 281 267
query86 389 302 322 302
query87 3302 3168 3157 3157
query88 3423 2331 2320 2320
query89 484 382 381 381
query90 2047 190 182 182
query91 123 100 95 95
query92 56 47 49 47
query93 1193 498 498 498
query94 1102 182 183 182
query95 399 304 307 304
query96 573 263 269 263
query97 3221 2998 3031 2998
query98 247 224 217 217
query99 1194 861 874 861
Total cold run time: 247240 ms
Total hot run time: 168014 ms
ClickBench: Total hot run time: 30.54 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 754c394b582369e2ffaff795fd5166058431028d, data reload: false
query1 0.03 0.03 0.03
query2 0.09 0.04 0.04
query3 0.23 0.04 0.05
query4 1.67 0.06 0.06
query5 0.49 0.49 0.50
query6 1.13 0.72 0.72
query7 0.02 0.02 0.01
query8 0.05 0.04 0.04
query9 0.55 0.49 0.49
query10 0.55 0.55 0.54
query11 0.16 0.11 0.11
query12 0.14 0.12 0.12
query13 0.59 0.58 0.60
query14 0.77 0.78 0.78
query15 0.83 0.80 0.81
query16 0.37 0.37 0.36
query17 1.03 0.96 1.04
query18 0.22 0.23 0.26
query19 1.85 1.79 1.71
query20 0.01 0.02 0.01
query21 15.60 0.66 0.67
query22 4.18 7.59 1.94
query23 18.28 1.35 1.30
query24 1.91 0.22 0.22
query25 0.15 0.09 0.08
query26 0.26 0.16 0.17
query27 0.09 0.07 0.08
query28 13.30 1.02 1.02
query29 13.14 3.32 3.24
query30 0.24 0.06 0.06
query31 2.86 0.38 0.38
query32 3.30 0.46 0.47
query33 2.89 2.90 2.90
query34 17.17 4.42 4.42
query35 4.47 4.48 4.56
query36 0.68 0.49 0.46
query37 0.17 0.15 0.16
query38 0.15 0.15 0.14
query39 0.05 0.03 0.04
query40 0.16 0.14 0.15
query41 0.09 0.04 0.04
query42 0.06 0.04 0.05
query43 0.04 0.04 0.03
Total cold run time: 110.02 s
Total hot run time: 30.54 s
run buildall
clang-tidy review says "All clean, LGTM! :+1:"
clang-tidy review says "All clean, LGTM! :+1:"
run buildall
TeamCity be ut coverage result: Function Coverage: 35.74% (9009/25206) Line Coverage: 27.37% (74571/272488) Region Coverage: 26.58% (38568/145121) Branch Coverage: 23.44% (19669/83916) Coverage Report: http://coverage.selectdb-in.cc/coverage/33463a7dc7afc01388f6c232a76005339dee42ac_33463a7dc7afc01388f6c232a76005339dee42ac/report/index.html
run buildall
clang-tidy review says "All clean, LGTM! :+1:"
TPC-H: Total hot run time: 40779 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 522c2d20a99207a1c5549aadd38c200fa8d2cd3f, data reload: false
------ Round 1 ----------------------------------
q1 17928 4455 4482 4455
q2 2502 209 206 206
q3 11512 1283 1199 1199
q4 11119 720 929 720
q5 7806 2764 2700 2700
q6 217 134 136 134
q7 975 610 616 610
q8 9271 2068 2087 2068
q9 9140 6503 6499 6499
q10 8988 3695 3691 3691
q11 456 257 246 246
q12 426 221 218 218
q13 18892 2975 2980 2975
q14 255 223 223 223
q15 516 461 467 461
q16 503 374 385 374
q17 963 670 678 670
q18 8125 7448 7375 7375
q19 5101 1554 1481 1481
q20 655 325 311 311
q21 4952 3892 3905 3892
q22 343 271 281 271
Total cold run time: 120645 ms
Total hot run time: 40779 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4328 4220 4221 4220
q2 387 254 273 254
q3 3010 2750 2716 2716
q4 1877 1610 1577 1577
q5 5233 5256 5264 5256
q6 216 128 124 124
q7 2111 1761 1785 1761
q8 3200 3366 3310 3310
q9 8377 8366 8388 8366
q10 3952 3657 3736 3657
q11 599 505 491 491
q12 780 610 567 567
q13 17298 2966 3003 2966
q14 283 263 253 253
q15 521 468 479 468
q16 485 407 407 407
q17 1797 1493 1482 1482
q18 7689 7523 7468 7468
q19 1660 1540 1551 1540
q20 1965 1793 1799 1793
q21 4714 4698 4724 4698
q22 558 494 483 483
Total cold run time: 71040 ms
Total hot run time: 53857 ms
TeamCity be ut coverage result: Function Coverage: 35.77% (9010/25192) Line Coverage: 27.37% (74584/272482) Region Coverage: 26.59% (38590/145122) Branch Coverage: 23.45% (19672/83898) Coverage Report: http://coverage.selectdb-in.cc/coverage/522c2d20a99207a1c5549aadd38c200fa8d2cd3f_522c2d20a99207a1c5549aadd38c200fa8d2cd3f/report/index.html
TPC-DS: Total hot run time: 171669 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 522c2d20a99207a1c5549aadd38c200fa8d2cd3f, data reload: false
query1 928 385 383 383
query2 6458 2460 2213 2213
query3 6653 212 211 211
query4 19266 17265 17231 17231
query5 4143 423 424 423
query6 253 159 156 156
query7 4600 298 295 295
query8 234 175 183 175
query9 8515 2404 2401 2401
query10 443 285 260 260
query11 10681 9963 10068 9963
query12 137 90 87 87
query13 1636 371 367 367
query14 8465 7798 7068 7068
query15 215 166 167 166
query16 7735 257 256 256
query17 1852 520 503 503
query18 1954 265 265 265
query19 211 159 161 159
query20 89 81 83 81
query21 194 129 137 129
query22 4263 4118 3867 3867
query23 33488 32997 32837 32837
query24 11003 2893 2849 2849
query25 643 359 349 349
query26 1569 158 161 158
query27 3013 317 325 317
query28 7441 2072 2050 2050
query29 994 601 621 601
query30 288 148 150 148
query31 957 750 754 750
query32 95 53 54 53
query33 757 279 261 261
query34 1010 480 483 480
query35 746 602 610 602
query36 1054 913 905 905
query37 130 66 66 66
query38 2874 2748 2760 2748
query39 850 794 810 794
query40 270 129 123 123
query41 47 44 44 44
query42 105 97 102 97
query43 577 569 543 543
query44 1272 737 752 737
query45 175 164 159 159
query46 1063 719 724 719
query47 1833 1775 1754 1754
query48 377 290 301 290
query49 1139 378 379 378
query50 776 387 383 383
query51 6859 6748 6782 6748
query52 101 96 94 94
query53 361 286 289 286
query54 933 429 420 420
query55 80 74 73 73
query56 260 238 245 238
query57 1164 1046 1068 1046
query58 239 218 214 214
query59 3382 3164 3216 3164
query60 290 294 255 255
query61 91 88 91 88
query62 665 457 447 447
query63 315 285 285 285
query64 9878 2206 1738 1738
query65 3185 3089 3130 3089
query66 1422 337 344 337
query67 15297 14870 14936 14870
query68 4530 541 529 529
query69 455 277 343 277
query70 1104 1087 1136 1087
query71 393 271 274 271
query72 7301 5380 5171 5171
query73 735 327 322 322
query74 6013 5642 5557 5557
query75 3388 2655 2581 2581
query76 2650 1014 1011 1011
query77 421 269 276 269
query78 10320 9910 9775 9775
query79 2228 518 526 518
query80 933 442 428 428
query81 513 221 214 214
query82 634 93 88 88
query83 248 168 173 168
query84 233 84 82 82
query85 1855 275 268 268
query86 505 380 298 298
query87 3251 3133 3149 3133
query88 4211 2343 2332 2332
query89 494 409 381 381
query90 2026 188 184 184
query91 126 97 103 97
query92 60 49 50 49
query93 2251 508 491 491
query94 1210 189 181 181
query95 401 309 306 306
query96 590 269 271 269
query97 3191 3028 3073 3028
query98 226 219 222 219
query99 1097 839 840 839
Total cold run time: 271586 ms
Total hot run time: 171669 ms
ClickBench: Total hot run time: 31.02 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 522c2d20a99207a1c5549aadd38c200fa8d2cd3f, data reload: false
query1 0.04 0.04 0.03
query2 0.08 0.04 0.04
query3 0.23 0.05 0.05
query4 1.67 0.08 0.09
query5 0.50 0.49 0.50
query6 1.13 0.71 0.74
query7 0.02 0.02 0.02
query8 0.05 0.04 0.04
query9 0.53 0.50 0.49
query10 0.53 0.53 0.54
query11 0.14 0.11 0.11
query12 0.15 0.12 0.12
query13 0.59 0.59 0.61
query14 0.74 0.78 0.80
query15 0.82 0.82 0.81
query16 0.37 0.36 0.37
query17 1.00 1.02 1.00
query18 0.21 0.25 0.24
query19 1.90 1.71 1.68
query20 0.02 0.01 0.01
query21 15.68 0.65 0.64
query22 4.44 6.25 2.29
query23 18.29 1.33 1.28
query24 1.74 0.28 0.21
query25 0.15 0.08 0.09
query26 0.27 0.16 0.17
query27 0.08 0.09 0.08
query28 13.28 1.01 1.00
query29 13.24 3.32 3.27
query30 0.24 0.05 0.07
query31 2.85 0.39 0.38
query32 3.30 0.48 0.46
query33 2.88 2.90 2.88
query34 17.28 4.45 4.43
query35 4.58 4.56 4.60
query36 0.65 0.47 0.47
query37 0.17 0.17 0.16
query38 0.16 0.14 0.15
query39 0.04 0.04 0.04
query40 0.16 0.14 0.14
query41 0.09 0.05 0.05
query42 0.05 0.05 0.04
query43 0.04 0.03 0.04
Total cold run time: 110.38 s
Total hot run time: 31.02 s
run p0
PR approved by at least one committer and no changes requested.
PR approved by anyone and no changes requested.