doris icon indicating copy to clipboard operation
doris copied to clipboard

[fix](nereids): fix PlanPostProcessor use visitor

Open jackwener opened this issue 9 months ago • 5 comments

Proposed changes

PlanPostProcessor use visitor wrong, fix them

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

jackwener avatar May 23 '24 01:05 jackwener

Thank you for your contribution to Apache Doris. Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website. See Doris Document.

doris-robot avatar May 23 '24 01:05 doris-robot

run buildall

jackwener avatar May 23 '24 01:05 jackwener

TPC-H: Total hot run time: 41346 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit fb0a7edd59621aeddda5bd4071b0f5d812646324, data reload: false

------ Round 1 ----------------------------------
q1	17611	4329	4278	4278
q2	2011	199	192	192
q3	10470	1213	1167	1167
q4	10197	833	822	822
q5	7507	2958	2696	2696
q6	233	133	132	132
q7	968	623	625	623
q8	9254	2136	2121	2121
q9	10379	6715	6668	6668
q10	9522	3894	3919	3894
q11	463	238	245	238
q12	438	232	226	226
q13	17188	3177	3246	3177
q14	271	240	233	233
q15	523	471	467	467
q16	496	387	397	387
q17	986	725	707	707
q18	8440	7832	7884	7832
q19	4362	1540	1549	1540
q20	642	322	334	322
q21	5093	4102	3341	3341
q22	349	283	289	283
Total cold run time: 117403 ms
Total hot run time: 41346 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4505	4458	4442	4442
q2	389	272	278	272
q3	3133	2930	2939	2930
q4	1895	1577	1552	1552
q5	5467	5508	5518	5508
q6	212	123	125	123
q7	2212	1774	1834	1774
q8	3260	3410	3365	3365
q9	8569	8724	8704	8704
q10	4113	3764	3739	3739
q11	587	491	532	491
q12	788	618	614	614
q13	17139	3154	3156	3154
q14	305	269	259	259
q15	533	492	479	479
q16	500	429	438	429
q17	1816	1512	1488	1488
q18	7654	7649	7543	7543
q19	1676	1601	1529	1529
q20	1992	1791	1777	1777
q21	8270	4922	4629	4629
q22	563	472	478	472
Total cold run time: 75578 ms
Total hot run time: 55273 ms

doris-robot avatar May 23 '24 02:05 doris-robot

TPC-DS: Total hot run time: 168827 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit fb0a7edd59621aeddda5bd4071b0f5d812646324, data reload: false

query1	921	375	373	373
query2	6465	2343	2485	2343
query3	6646	210	212	210
query4	20773	17647	17368	17368
query5	4089	421	410	410
query6	265	153	156	153
query7	4594	298	287	287
query8	242	193	180	180
query9	8464	2371	2354	2354
query10	439	284	253	253
query11	10614	10234	10206	10206
query12	134	93	88	88
query13	1647	374	381	374
query14	9363	7015	6133	6133
query15	202	170	170	170
query16	7524	270	265	265
query17	1309	518	531	518
query18	1797	269	268	268
query19	192	153	161	153
query20	93	84	87	84
query21	202	130	123	123
query22	4096	3872	4037	3872
query23	33512	33221	33341	33221
query24	10865	2878	2755	2755
query25	581	354	364	354
query26	705	158	160	158
query27	2237	326	327	326
query28	5834	2038	2069	2038
query29	880	628	613	613
query30	256	174	181	174
query31	961	757	741	741
query32	94	50	52	50
query33	660	278	258	258
query34	876	489	493	489
query35	729	614	635	614
query36	1054	904	897	897
query37	105	71	71	71
query38	2907	2820	2761	2761
query39	842	778	799	778
query40	198	124	121	121
query41	47	44	45	44
query42	109	98	99	98
query43	596	557	553	553
query44	1130	730	741	730
query45	182	166	168	166
query46	1078	734	751	734
query47	1900	1781	1815	1781
query48	362	290	298	290
query49	834	410	399	399
query50	773	391	392	391
query51	6924	6881	6831	6831
query52	101	89	93	89
query53	359	287	281	281
query54	887	422	420	420
query55	78	73	74	73
query56	255	262	238	238
query57	1115	1079	1065	1065
query58	226	203	209	203
query59	3387	3293	3216	3216
query60	303	287	247	247
query61	92	86	87	86
query62	639	432	449	432
query63	312	286	283	283
query64	8482	2232	1754	1754
query65	3199	3064	3094	3064
query66	884	347	341	341
query67	15181	14684	15132	14684
query68	4526	529	546	529
query69	440	267	268	267
query70	1150	1130	1087	1087
query71	407	274	269	269
query72	7520	6041	2703	2703
query73	735	335	324	324
query74	5996	5587	5615	5587
query75	3318	2656	2640	2640
query76	2441	978	874	874
query77	388	268	265	265
query78	10240	9894	9583	9583
query79	2401	526	528	526
query80	987	435	441	435
query81	533	253	241	241
query82	939	97	95	95
query83	237	170	173	170
query84	247	91	91	91
query85	1302	348	257	257
query86	439	310	302	302
query87	3332	3105	3113	3105
query88	4252	2345	2343	2343
query89	462	380	378	378
query90	2041	186	185	185
query91	122	96	95	95
query92	54	48	50	48
query93	1805	514	498	498
query94	1175	192	185	185
query95	410	317	318	317
query96	581	266	269	266
query97	3186	3028	3003	3003
query98	235	221	226	221
query99	1179	855	841	841
Total cold run time: 265882 ms
Total hot run time: 168827 ms

doris-robot avatar May 23 '24 02:05 doris-robot

ClickBench: Total hot run time: 30.8 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit fb0a7edd59621aeddda5bd4071b0f5d812646324, data reload: false

query1	0.04	0.03	0.03
query2	0.08	0.03	0.04
query3	0.22	0.05	0.06
query4	1.66	0.09	0.08
query5	0.50	0.49	0.50
query6	1.13	0.73	0.73
query7	0.02	0.01	0.02
query8	0.05	0.04	0.04
query9	0.54	0.48	0.49
query10	0.55	0.56	0.55
query11	0.16	0.11	0.12
query12	0.15	0.12	0.12
query13	0.59	0.59	0.60
query14	0.75	0.78	0.77
query15	0.83	0.80	0.81
query16	0.35	0.37	0.38
query17	0.98	0.99	0.99
query18	0.22	0.26	0.25
query19	1.80	1.73	1.71
query20	0.01	0.01	0.01
query21	15.48	0.67	0.67
query22	4.40	6.43	2.11
query23	18.32	1.30	1.27
query24	1.94	0.24	0.21
query25	0.14	0.10	0.08
query26	0.27	0.17	0.17
query27	0.07	0.07	0.08
query28	13.30	1.02	0.98
query29	12.72	3.39	3.24
query30	0.24	0.06	0.05
query31	2.87	0.39	0.39
query32	3.28	0.48	0.46
query33	2.93	2.94	2.95
query34	17.20	4.42	4.45
query35	4.52	4.48	4.53
query36	0.69	0.49	0.46
query37	0.17	0.16	0.16
query38	0.15	0.14	0.14
query39	0.05	0.03	0.04
query40	0.16	0.15	0.14
query41	0.09	0.05	0.04
query42	0.05	0.04	0.05
query43	0.04	0.04	0.04
Total cold run time: 109.71 s
Total hot run time: 30.8 s

doris-robot avatar May 23 '24 02:05 doris-robot

PR approved by at least one committer and no changes requested.

github-actions[bot] avatar May 23 '24 03:05 github-actions[bot]

PR approved by anyone and no changes requested.

github-actions[bot] avatar May 23 '24 03:05 github-actions[bot]