doris icon indicating copy to clipboard operation
doris copied to clipboard

[fix](nereids)should use nereids expr's nullable info when call Expr's toThrift method

Open starocean999 opened this issue 9 months ago • 6 comments

Proposed changes

when passing the expr's nullable flag to be, the old code call the expr's isNullable method to get this value. The isNullable method is obsolete and may result in wrong value. So we add a new member nullableFromNereids to let nereids to pass the correct nullable info to be

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

starocean999 avatar May 20 '24 09:05 starocean999

Thank you for your contribution to Apache Doris. Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website. See Doris Document.

doris-robot avatar May 20 '24 09:05 doris-robot

run buildall

starocean999 avatar May 20 '24 09:05 starocean999

add descriptin to explain why need set nullable explicitly

morrySnow avatar May 22 '24 12:05 morrySnow

add descriptin to explain why need set nullable explicitly

morrySnow avatar May 22 '24 12:05 morrySnow

PR approved by at least one committer and no changes requested.

github-actions[bot] avatar May 22 '24 12:05 github-actions[bot]

PR approved by anyone and no changes requested.

github-actions[bot] avatar May 22 '24 12:05 github-actions[bot]