doris icon indicating copy to clipboard operation
doris copied to clipboard

[build](third-party) Support to download specified third-party only

Open gavinchou opened this issue 2 months ago • 5 comments

In the previous implementation, we have to download all third-party packages even if we build a specified third-party dependency, e.g.

sh build-third-party.sh brpc

it would also download all the other irrelevant third-party source files, say ali_sdk and rocskdb. It wastes a lot of time if we only want to update a specific dependency, especially if the network quality is poor.

After this commit, we only need to download the specified third-party source files, it saves a lot of time when we do third-party updates manually.

gavinchou avatar May 02 '24 17:05 gavinchou

Thank you for your contribution to Apache Doris. Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website. See Doris Document.

doris-robot avatar May 02 '24 17:05 doris-robot

run buildall

gavinchou avatar May 02 '24 17:05 gavinchou

sh-checker report

To get the full details, please check in the job output.

shellcheck errors
'shellcheck ' found no issues.

shfmt errors

'shfmt ' returned error 1 finding the following formatting issues:

----------
--- thirdparty/download-thirdparty.sh.orig
+++ thirdparty/download-thirdparty.sh
@@ -499,4 +499,3 @@
     fi
     echo "Finished patching ${KRB5_SOURCE}"
 fi
-
----------

You can reformat the above files to meet shfmt's requirements by typing:

  shfmt  -w filename


github-actions[bot] avatar May 02 '24 17:05 github-actions[bot]

run buildall

gavinchou avatar May 02 '24 17:05 gavinchou

run buildall

gavinchou avatar May 02 '24 17:05 gavinchou

TeamCity be ut coverage result: Function Coverage: 35.66% (8962/25130) Line Coverage: 27.28% (73930/271020) Region Coverage: 26.47% (38193/144289) Branch Coverage: 23.21% (19445/83762) Coverage Report: http://coverage.selectdb-in.cc/coverage/e69a6a362c3fcd84b0c626c8fffdf1c57b966462_e69a6a362c3fcd84b0c626c8fffdf1c57b966462/report/index.html

doris-robot avatar May 02 '24 18:05 doris-robot

TPC-DS: Total hot run time: 188176 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit e69a6a362c3fcd84b0c626c8fffdf1c57b966462, data reload: false

query1	913	362	352	352
query2	6288	2491	2426	2426
query3	6670	207	207	207
query4	23019	21831	21943	21831
query5	3926	432	430	430
query6	253	177	172	172
query7	4591	302	287	287
query8	228	185	177	177
query9	8368	2364	2359	2359
query10	429	266	268	266
query11	15170	14648	14752	14648
query12	121	93	89	89
query13	1700	375	385	375
query14	9999	8755	8305	8305
query15	257	168	173	168
query16	8191	266	270	266
query17	1919	572	557	557
query18	2094	281	270	270
query19	318	154	151	151
query20	92	86	84	84
query21	196	124	132	124
query22	5017	4828	4836	4828
query23	34019	33254	33430	33254
query24	10659	2981	2945	2945
query25	611	380	373	373
query26	1138	154	153	153
query27	2861	323	317	317
query28	7361	1978	1985	1978
query29	879	633	613	613
query30	227	156	156	156
query31	979	736	730	730
query32	93	50	52	50
query33	746	241	240	240
query34	1035	472	473	472
query35	806	664	665	664
query36	1048	910	928	910
query37	140	66	66	66
query38	3142	3060	2961	2961
query39	1616	1535	1574	1535
query40	197	124	125	124
query41	39	38	38	38
query42	104	95	95	95
query43	566	535	510	510
query44	1242	756	761	756
query45	266	248	254	248
query46	1075	706	684	684
query47	1933	1841	1842	1841
query48	384	300	298	298
query49	852	392	393	392
query50	774	384	396	384
query51	6697	6629	6595	6595
query52	99	94	88	88
query53	353	277	281	277
query54	291	233	235	233
query55	79	72	77	72
query56	248	228	234	228
query57	1188	1142	1114	1114
query58	223	194	196	194
query59	3264	3179	3000	3000
query60	247	234	236	234
query61	92	87	88	87
query62	673	459	449	449
query63	312	285	285	285
query64	8656	7231	7220	7220
query65	3105	3089	3060	3060
query66	906	323	330	323
query67	15594	14938	14886	14886
query68	9518	565	550	550
query69	605	308	313	308
query70	1391	1073	1086	1073
query71	530	272	283	272
query72	8298	2572	2360	2360
query73	1603	320	330	320
query74	6549	6146	6109	6109
query75	5202	2678	2622	2622
query76	5936	1031	945	945
query77	789	274	274	274
query78	11061	10295	10310	10295
query79	10755	509	522	509
query80	1089	437	449	437
query81	504	225	228	225
query82	226	94	95	94
query83	198	162	164	162
query84	259	86	87	86
query85	1137	270	263	263
query86	346	297	310	297
query87	3302	3080	3063	3063
query88	5734	2436	2404	2404
query89	511	394	373	373
query90	2380	183	178	178
query91	122	102	102	102
query92	54	47	47	47
query93	6904	519	508	508
query94	1576	183	188	183
query95	396	303	313	303
query96	609	271	264	264
query97	3159	2944	2952	2944
query98	239	223	220	220
query99	1104	917	882	882
Total cold run time: 308664 ms
Total hot run time: 188176 ms

doris-robot avatar May 02 '24 18:05 doris-robot

PR approved by at least one committer and no changes requested.

github-actions[bot] avatar May 04 '24 01:05 github-actions[bot]

PR approved by anyone and no changes requested.

github-actions[bot] avatar May 04 '24 01:05 github-actions[bot]

run buildall

gavinchou avatar May 06 '24 08:05 gavinchou

TeamCity be ut coverage result: Function Coverage: 35.61% (8965/25173) Line Coverage: 27.25% (73975/271494) Region Coverage: 26.46% (38207/144384) Branch Coverage: 23.22% (19459/83796) Coverage Report: http://coverage.selectdb-in.cc/coverage/2209f178a902e571320867615d29d0c3a68d4555_2209f178a902e571320867615d29d0c3a68d4555/report/index.html

doris-robot avatar May 06 '24 08:05 doris-robot

TPC-H: Total hot run time: 40299 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 2209f178a902e571320867615d29d0c3a68d4555, data reload: false

------ Round 1 ----------------------------------
q1	17605	4860	4251	4251
q2	2017	190	204	190
q3	10569	1170	1271	1170
q4	10456	805	804	804
q5	7519	2708	2638	2638
q6	219	135	135	135
q7	1044	632	593	593
q8	9653	2141	2123	2123
q9	9564	6780	6665	6665
q10	9059	3764	3707	3707
q11	443	243	240	240
q12	429	221	218	218
q13	17767	3000	2992	2992
q14	263	223	219	219
q15	504	469	482	469
q16	507	384	376	376
q17	974	653	704	653
q18	8038	7547	7403	7403
q19	1607	1525	1521	1521
q20	647	301	297	297
q21	5183	3355	4080	3355
q22	359	292	280	280
Total cold run time: 114426 ms
Total hot run time: 40299 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4359	4196	4215	4196
q2	375	268	262	262
q3	2987	2782	2734	2734
q4	1876	1609	1582	1582
q5	5286	5291	5304	5291
q6	210	125	127	125
q7	2267	1889	1894	1889
q8	3212	3378	3392	3378
q9	8496	8420	8529	8420
q10	3938	3673	3661	3661
q11	592	496	490	490
q12	762	580	593	580
q13	17325	2997	2985	2985
q14	286	279	256	256
q15	521	479	468	468
q16	460	414	413	413
q17	1773	1516	1467	1467
q18	7609	7583	7473	7473
q19	6192	1555	1590	1555
q20	1987	1783	1751	1751
q21	5169	4914	4788	4788
q22	569	513	508	508
Total cold run time: 76251 ms
Total hot run time: 54272 ms

doris-robot avatar May 06 '24 09:05 doris-robot

TPC-DS: Total hot run time: 185624 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 2209f178a902e571320867615d29d0c3a68d4555, data reload: false

query1	923	372	348	348
query2	6462	2342	2208	2208
query3	6661	208	215	208
query4	23176	21215	21249	21215
query5	4230	413	414	413
query6	259	176	175	175
query7	4590	293	285	285
query8	243	195	191	191
query9	8465	2360	2360	2360
query10	432	244	242	242
query11	14704	14090	14209	14090
query12	139	89	89	89
query13	1633	359	377	359
query14	10522	8137	7682	7682
query15	250	170	164	164
query16	8189	252	250	250
query17	1889	544	541	541
query18	2104	283	269	269
query19	337	153	159	153
query20	93	86	85	85
query21	205	129	126	126
query22	5061	4870	4828	4828
query23	33879	33447	33140	33140
query24	11651	2887	2881	2881
query25	660	387	381	381
query26	1760	152	156	152
query27	2873	325	329	325
query28	7481	2053	2031	2031
query29	1029	633	608	608
query30	299	150	157	150
query31	993	728	743	728
query32	92	52	56	52
query33	754	253	252	252
query34	1059	472	482	472
query35	794	677	662	662
query36	1060	897	886	886
query37	282	69	69	69
query38	3144	3004	2983	2983
query39	1626	1525	1521	1521
query40	282	126	128	126
query41	46	42	43	42
query42	107	98	103	98
query43	567	524	538	524
query44	1194	733	752	733
query45	272	247	253	247
query46	1073	718	719	718
query47	1955	1866	1888	1866
query48	376	304	298	298
query49	1203	404	404	404
query50	782	380	399	380
query51	6683	6607	6589	6589
query52	101	96	93	93
query53	351	288	286	286
query54	327	247	231	231
query55	79	77	79	77
query56	247	225	223	223
query57	1250	1164	1157	1157
query58	232	205	200	200
query59	3535	3184	2888	2888
query60	250	239	226	226
query61	89	85	84	84
query62	650	472	436	436
query63	305	278	277	277
query64	9605	7276	7139	7139
query65	3171	3077	3050	3050
query66	1346	339	332	332
query67	15521	14991	15110	14991
query68	9235	541	554	541
query69	576	296	310	296
query70	1344	1090	1104	1090
query71	507	271	267	267
query72	8527	2563	2365	2365
query73	1601	324	325	324
query74	6487	6048	6197	6048
query75	4502	2658	2638	2638
query76	5794	1021	973	973
query77	665	263	262	262
query78	11162	10115	10175	10115
query79	12004	524	524	524
query80	1927	443	426	426
query81	501	213	218	213
query82	227	95	95	95
query83	209	166	174	166
query84	267	85	88	85
query85	1094	263	288	263
query86	337	296	305	296
query87	3327	3098	3067	3067
query88	5251	2329	2303	2303
query89	511	381	369	369
query90	2007	179	178	178
query91	126	113	98	98
query92	60	47	47	47
query93	6738	513	501	501
query94	1367	184	181	181
query95	391	300	297	297
query96	614	258	255	255
query97	3116	2962	2977	2962
query98	247	219	228	219
query99	1213	880	871	871
Total cold run time: 313536 ms
Total hot run time: 185624 ms

doris-robot avatar May 06 '24 09:05 doris-robot

PR approved by at least one committer and no changes requested.

github-actions[bot] avatar May 06 '24 11:05 github-actions[bot]