doris icon indicating copy to clipboard operation
doris copied to clipboard

[opt](log)password should not be output in log

Open 390008457 opened this issue 9 months ago • 2 comments

Proposed changes

Passwords should not be output to logs in plain text. Instead, use MD5 to protect them.

390008457 avatar Apr 30 '24 02:04 390008457

Thank you for your contribution to Apache Doris. Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website. See Doris Document.

doris-robot avatar Apr 30 '24 02:04 doris-robot

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Apr 30 '24 02:04 github-actions[bot]

run beut: BE UT

390008457 avatar May 17 '24 07:05 390008457

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar May 17 '24 07:05 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar May 17 '24 09:05 github-actions[bot]

run buildall

dataroaring avatar Jun 05 '24 01:06 dataroaring

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Jun 05 '24 01:06 github-actions[bot]

TeamCity be ut coverage result: Function Coverage: 36.41% (8984/24677) Line Coverage: 27.91% (73365/262832) Region Coverage: 27.35% (37995/138898) Branch Coverage: 23.94% (19277/80534) Coverage Report: http://coverage.selectdb-in.cc/coverage/b1479e601fc20f082f5a9cb471f4045f1599f885_b1479e601fc20f082f5a9cb471f4045f1599f885/report/index.html

doris-robot avatar Jun 05 '24 01:06 doris-robot

TPC-H: Total hot run time: 40300 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit b1479e601fc20f082f5a9cb471f4045f1599f885, data reload: false

------ Round 1 ----------------------------------
q1	17607	4425	4245	4245
q2	2017	195	194	194
q3	10439	1235	1011	1011
q4	10193	807	827	807
q5	7474	2724	2738	2724
q6	222	134	136	134
q7	957	615	634	615
q8	9226	2137	2105	2105
q9	9367	6700	6701	6700
q10	9323	3868	3812	3812
q11	461	245	242	242
q12	519	232	240	232
q13	17546	3276	3101	3101
q14	273	219	218	218
q15	516	483	473	473
q16	520	404	391	391
q17	988	600	629	600
q18	8495	7780	7627	7627
q19	6643	1213	1518	1213
q20	640	335	317	317
q21	5145	4032	3209	3209
q22	410	330	344	330
Total cold run time: 118981 ms
Total hot run time: 40300 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4619	4462	4476	4462
q2	395	271	274	271
q3	3163	2888	2933	2888
q4	1865	1642	1607	1607
q5	5441	5497	5487	5487
q6	226	127	126	126
q7	2179	1827	1767	1767
q8	3198	3352	3359	3352
q9	8627	8571	8636	8571
q10	4100	3816	3802	3802
q11	614	484	476	476
q12	775	623	617	617
q13	17195	3286	3207	3207
q14	320	290	270	270
q15	515	487	480	480
q16	482	436	436	436
q17	1863	1505	1497	1497
q18	8352	7472	7330	7330
q19	1763	1572	1551	1551
q20	3029	1778	1785	1778
q21	9297	4579	4632	4579
q22	594	534	567	534
Total cold run time: 78612 ms
Total hot run time: 55088 ms

doris-robot avatar Jun 05 '24 02:06 doris-robot

TPC-DS: Total hot run time: 171298 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit b1479e601fc20f082f5a9cb471f4045f1599f885, data reload: false

query1	915	381	377	377
query2	6443	2299	2371	2299
query3	6643	208	206	206
query4	19390	17302	17324	17302
query5	4135	456	452	452
query6	254	157	153	153
query7	4589	296	292	292
query8	303	292	298	292
query9	8460	2441	2409	2409
query10	440	304	288	288
query11	10579	10002	10074	10002
query12	139	91	87	87
query13	1641	363	361	361
query14	9277	6206	6893	6206
query15	233	192	193	192
query16	7148	288	299	288
query17	954	515	519	515
query18	1732	271	278	271
query19	206	153	162	153
query20	91	89	87	87
query21	202	130	127	127
query22	4280	4191	3969	3969
query23	33476	32956	33004	32956
query24	11163	2802	2782	2782
query25	620	379	364	364
query26	1480	167	163	163
query27	2921	328	321	321
query28	7323	2046	2047	2046
query29	988	620	599	599
query30	267	150	149	149
query31	935	736	717	717
query32	99	52	55	52
query33	767	290	280	280
query34	943	475	491	475
query35	739	604	633	604
query36	1081	932	896	896
query37	159	70	70	70
query38	2893	2758	2756	2756
query39	841	799	783	783
query40	211	128	130	128
query41	56	52	53	52
query42	125	97	98	97
query43	594	561	536	536
query44	1220	732	751	732
query45	200	164	171	164
query46	1066	724	743	724
query47	1818	1788	1802	1788
query48	387	293	295	293
query49	947	410	418	410
query50	782	393	396	393
query51	6862	6768	6808	6768
query52	105	90	94	90
query53	362	288	290	288
query54	901	465	433	433
query55	76	75	75	75
query56	283	290	267	267
query57	1135	1050	1089	1050
query58	262	256	263	256
query59	3400	3162	3144	3144
query60	291	278	272	272
query61	89	88	88	88
query62	619	438	449	438
query63	322	296	299	296
query64	8984	2283	1722	1722
query65	3142	3096	3118	3096
query66	1066	329	346	329
query67	15534	14821	14836	14821
query68	6493	556	545	545
query69	568	350	348	348
query70	1149	1097	1107	1097
query71	428	291	290	290
query72	8152	5111	5740	5111
query73	782	320	320	320
query74	6006	5593	5452	5452
query75	3636	2648	2638	2638
query76	3264	903	980	903
query77	605	294	294	294
query78	10222	9918	9635	9635
query79	2100	518	519	518
query80	762	465	472	465
query81	593	220	216	216
query82	1017	103	105	103
query83	219	174	172	172
query84	271	85	88	85
query85	1323	283	266	266
query86	437	307	318	307
query87	3313	3100	3081	3081
query88	3557	2333	2342	2333
query89	480	404	401	401
query90	1838	195	191	191
query91	125	102	149	102
query92	59	50	48	48
query93	1999	517	494	494
query94	1212	188	185	185
query95	408	324	316	316
query96	589	265	273	265
query97	3202	3001	2975	2975
query98	235	227	230	227
query99	1307	867	824	824
Total cold run time: 271939 ms
Total hot run time: 171298 ms

doris-robot avatar Jun 05 '24 02:06 doris-robot

ClickBench: Total hot run time: 31.19 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit b1479e601fc20f082f5a9cb471f4045f1599f885, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.04	0.04
query3	0.22	0.05	0.06
query4	1.67	0.07	0.07
query5	0.50	0.50	0.50
query6	1.14	0.73	0.72
query7	0.02	0.02	0.02
query8	0.05	0.04	0.04
query9	0.54	0.49	0.50
query10	0.55	0.54	0.56
query11	0.16	0.11	0.12
query12	0.15	0.12	0.12
query13	0.58	0.58	0.61
query14	0.76	0.78	0.80
query15	0.85	0.81	0.80
query16	0.36	0.35	0.35
query17	1.02	0.96	0.99
query18	0.21	0.25	0.22
query19	1.82	1.72	1.73
query20	0.01	0.00	0.01
query21	15.72	0.65	0.64
query22	4.06	6.84	2.50
query23	18.30	1.33	1.22
query24	1.99	0.20	0.20
query25	0.15	0.09	0.08
query26	0.26	0.18	0.17
query27	0.08	0.08	0.07
query28	13.38	1.01	1.00
query29	12.96	3.43	3.42
query30	0.24	0.06	0.06
query31	2.86	0.39	0.39
query32	3.28	0.47	0.47
query33	2.88	2.87	2.85
query34	17.27	4.38	4.42
query35	4.50	4.52	4.51
query36	0.71	0.50	0.50
query37	0.18	0.16	0.16
query38	0.15	0.15	0.14
query39	0.04	0.04	0.03
query40	0.16	0.14	0.15
query41	0.09	0.05	0.05
query42	0.06	0.04	0.04
query43	0.04	0.03	0.04
Total cold run time: 110.07 s
Total hot run time: 31.19 s

doris-robot avatar Jun 05 '24 02:06 doris-robot

PR approved by at least one committer and no changes requested.

github-actions[bot] avatar Jun 26 '24 14:06 github-actions[bot]

PR approved by anyone and no changes requested.

github-actions[bot] avatar Jun 26 '24 14:06 github-actions[bot]