doris
doris copied to clipboard
[chore] rename method name and improve logging and comments
Proposed changes
Issue Number: close #xxx method name, comments and logs improved in be/src folder.
Further comments
If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...
Thank you for your contribution to Apache Doris. Don't know what should be done next? See How to process your PR
Since 2024-03-18, the Document has been moved to doris-website. See Doris Document.
clang-tidy review says "All clean, LGTM! :+1:"
run buildall
TeamCity be ut coverage result: Function Coverage: 35.57% (8934/25115) Line Coverage: 27.21% (73701/270907) Region Coverage: 26.40% (38068/144214) Branch Coverage: 23.17% (19400/83714) Coverage Report: http://coverage.selectdb-in.cc/coverage/64466a07f308dd420c0ccf40f28c67392aa0b267_64466a07f308dd420c0ccf40f28c67392aa0b267/report/index.html
TPC-DS: Total hot run time: 187399 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 64466a07f308dd420c0ccf40f28c67392aa0b267, data reload: false
query1 913 355 338 338
query2 6205 2383 2428 2383
query3 6654 219 215 215
query4 23512 21743 21833 21743
query5 3826 438 423 423
query6 250 177 180 177
query7 4537 297 295 295
query8 236 194 187 187
query9 8556 2480 2468 2468
query10 426 251 259 251
query11 15253 14708 14703 14703
query12 121 84 86 84
query13 1643 375 370 370
query14 9691 8423 8097 8097
query15 256 168 166 166
query16 8230 276 261 261
query17 1774 564 535 535
query18 2088 270 267 267
query19 337 146 151 146
query20 87 81 83 81
query21 188 123 127 123
query22 5051 4804 4835 4804
query23 33864 33221 33048 33048
query24 10650 2895 2914 2895
query25 624 357 364 357
query26 1362 155 146 146
query27 2864 319 312 312
query28 7442 2072 2064 2064
query29 885 602 599 599
query30 250 151 147 147
query31 981 716 735 716
query32 100 54 55 54
query33 738 244 239 239
query34 1042 481 471 471
query35 813 655 654 654
query36 1056 897 917 897
query37 143 65 66 65
query38 3179 2979 3093 2979
query39 1580 1555 1541 1541
query40 250 126 123 123
query41 38 38 36 36
query42 101 95 94 94
query43 570 531 537 531
query44 1218 729 736 729
query45 260 254 250 250
query46 1072 771 710 710
query47 1960 1867 1811 1811
query48 365 293 293 293
query49 866 397 386 386
query50 771 390 378 378
query51 6658 6596 6705 6596
query52 100 91 91 91
query53 353 283 279 279
query54 293 231 225 225
query55 84 76 72 72
query56 239 222 217 217
query57 1256 1112 1109 1109
query58 230 195 201 195
query59 3427 3165 3074 3074
query60 256 229 236 229
query61 89 86 84 84
query62 637 467 459 459
query63 314 286 278 278
query64 9057 7221 7184 7184
query65 3107 3061 3059 3059
query66 1368 338 327 327
query67 15621 15063 14872 14872
query68 5234 549 541 541
query69 484 300 315 300
query70 1159 1152 1130 1130
query71 412 271 274 271
query72 7180 2537 2340 2340
query73 706 331 329 329
query74 6495 6103 6107 6103
query75 3355 2642 2654 2642
query76 3262 914 1007 914
query77 377 268 260 260
query78 10822 10220 10070 10070
query79 6030 527 531 527
query80 1105 434 436 434
query81 494 220 222 220
query82 895 93 97 93
query83 197 175 174 174
query84 264 85 86 85
query85 1342 270 270 270
query86 401 311 294 294
query87 3286 3089 3078 3078
query88 4681 2420 2415 2415
query89 496 380 383 380
query90 2060 179 181 179
query91 121 102 96 96
query92 58 47 46 46
query93 4779 508 500 500
query94 1103 179 181 179
query95 393 300 301 300
query96 601 265 265 265
query97 3192 2888 2953 2888
query98 232 214 216 214
query99 1307 870 879 870
Total cold run time: 290490 ms
Total hot run time: 187399 ms
clang-tidy review says "All clean, LGTM! :+1:"
run buildall
TeamCity be ut coverage result: Function Coverage: 35.70% (9006/25226) Line Coverage: 27.37% (74515/272237) Region Coverage: 26.61% (38529/144770) Branch Coverage: 23.44% (19657/83870) Coverage Report: http://coverage.selectdb-in.cc/coverage/9be4939da1542b88938408ad26262fd9a28b0d7b_9be4939da1542b88938408ad26262fd9a28b0d7b/report/index.html
run buildall
clang-tidy review says "All clean, LGTM! :+1:"
TPC-H: Total hot run time: 40046 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 6c00bd54228ec92b135c25d579c0274ec441ec62, data reload: false
------ Round 1 ----------------------------------
q1 17591 4442 4278 4278
q2 2019 194 205 194
q3 10539 1263 1281 1263
q4 10444 756 807 756
q5 7527 2685 2685 2685
q6 221 137 130 130
q7 975 606 608 606
q8 9326 2150 2076 2076
q9 9481 6639 6612 6612
q10 8992 3773 3679 3679
q11 460 250 232 232
q12 464 217 222 217
q13 17777 3043 2948 2948
q14 265 215 232 215
q15 516 468 466 466
q16 521 374 379 374
q17 979 770 681 681
q18 8152 7533 7290 7290
q19 2676 1571 1525 1525
q20 663 321 311 311
q21 5048 3960 3229 3229
q22 340 279 279 279
Total cold run time: 114976 ms
Total hot run time: 40046 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4356 4188 4217 4188
q2 373 275 264 264
q3 3016 2762 2697 2697
q4 1902 1631 1614 1614
q5 5239 5268 5343 5268
q6 215 123 126 123
q7 2142 1732 1740 1732
q8 3171 3367 3299 3299
q9 8404 8321 8397 8321
q10 3874 3672 3643 3643
q11 598 489 499 489
q12 771 607 607 607
q13 17457 2998 3014 2998
q14 298 262 272 262
q15 532 484 468 468
q16 477 410 413 410
q17 1781 1501 1494 1494
q18 7645 7633 7337 7337
q19 1657 1529 1531 1529
q20 2025 1757 1783 1757
q21 4853 4890 4927 4890
q22 592 489 476 476
Total cold run time: 71378 ms
Total hot run time: 53866 ms
TeamCity be ut coverage result: Function Coverage: 35.78% (9011/25184) Line Coverage: 27.39% (74577/272289) Region Coverage: 26.61% (38586/145027) Branch Coverage: 23.48% (19675/83794) Coverage Report: http://coverage.selectdb-in.cc/coverage/6c00bd54228ec92b135c25d579c0274ec441ec62_6c00bd54228ec92b135c25d579c0274ec441ec62/report/index.html
TPC-DS: Total hot run time: 171283 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 6c00bd54228ec92b135c25d579c0274ec441ec62, data reload: false
query1 945 412 390 390
query2 6468 2463 2240 2240
query3 6654 206 202 202
query4 19966 17480 17374 17374
query5 4185 413 437 413
query6 257 155 151 151
query7 4575 305 295 295
query8 266 183 181 181
query9 8562 2328 2309 2309
query10 454 275 250 250
query11 10609 10247 10227 10227
query12 136 87 95 87
query13 1639 357 359 357
query14 9872 6951 6174 6174
query15 215 164 166 164
query16 7822 262 259 259
query17 1841 518 509 509
query18 1955 297 275 275
query19 201 153 154 153
query20 91 88 82 82
query21 201 144 131 131
query22 4403 4006 3916 3916
query23 33990 33043 33176 33043
query24 12098 2822 2848 2822
query25 656 351 381 351
query26 1821 154 154 154
query27 3090 317 313 313
query28 7594 2025 2038 2025
query29 1139 628 611 611
query30 269 146 155 146
query31 965 762 736 736
query32 94 52 54 52
query33 769 286 259 259
query34 1044 477 470 470
query35 742 605 600 600
query36 1070 944 934 934
query37 275 73 68 68
query38 2918 2752 2741 2741
query39 850 803 792 792
query40 273 130 122 122
query41 48 45 43 43
query42 98 127 94 94
query43 577 548 560 548
query44 1230 723 747 723
query45 185 164 162 162
query46 1070 688 719 688
query47 1826 1742 1775 1742
query48 359 300 298 298
query49 1191 374 386 374
query50 771 391 385 385
query51 6895 6776 6785 6776
query52 103 86 87 86
query53 347 289 288 288
query54 1025 428 428 428
query55 74 69 77 69
query56 258 242 245 242
query57 1129 1026 1091 1026
query58 237 210 208 208
query59 3424 3300 3104 3104
query60 269 255 278 255
query61 139 88 84 84
query62 645 441 445 441
query63 312 281 282 281
query64 9772 2246 1698 1698
query65 3181 3086 3141 3086
query66 1391 335 313 313
query67 15399 14887 14818 14818
query68 4541 534 525 525
query69 445 272 279 272
query70 1144 1104 1075 1075
query71 402 269 268 268
query72 7495 5464 5750 5464
query73 705 318 322 318
query74 6033 5624 5603 5603
query75 3360 2590 2644 2590
query76 2603 995 1022 995
query77 413 263 259 259
query78 10151 9861 9706 9706
query79 2206 512 507 507
query80 945 441 430 430
query81 521 222 222 222
query82 644 90 90 90
query83 248 177 169 169
query84 232 87 83 83
query85 1890 383 261 261
query86 490 313 289 289
query87 3261 3089 3113 3089
query88 4195 2338 2344 2338
query89 477 391 403 391
query90 2023 195 183 183
query91 126 100 97 97
query92 59 48 49 48
query93 2354 515 501 501
query94 1246 191 185 185
query95 410 317 314 314
query96 599 270 267 267
query97 3179 3071 3035 3035
query98 246 229 223 223
query99 1082 848 856 848
Total cold run time: 276654 ms
Total hot run time: 171283 ms
ClickBench: Total hot run time: 30.59 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 6c00bd54228ec92b135c25d579c0274ec441ec62, data reload: false
query1 0.05 0.04 0.03
query2 0.08 0.04 0.04
query3 0.23 0.05 0.05
query4 1.67 0.07 0.07
query5 0.51 0.49 0.52
query6 1.11 0.73 0.73
query7 0.03 0.02 0.02
query8 0.06 0.04 0.04
query9 0.54 0.50 0.50
query10 0.53 0.56 0.56
query11 0.16 0.11 0.11
query12 0.14 0.12 0.12
query13 0.60 0.59 0.61
query14 0.78 0.80 0.76
query15 0.83 0.81 0.80
query16 0.38 0.37 0.36
query17 0.97 0.98 1.01
query18 0.21 0.24 0.25
query19 1.85 1.71 1.64
query20 0.01 0.01 0.01
query21 15.73 0.68 0.66
query22 4.05 7.99 1.90
query23 18.26 1.35 1.28
query24 1.64 0.23 0.27
query25 0.14 0.09 0.09
query26 0.24 0.17 0.16
query27 0.08 0.08 0.08
query28 13.36 1.03 0.99
query29 13.31 3.38 3.34
query30 0.27 0.08 0.08
query31 2.81 0.38 0.38
query32 3.27 0.48 0.48
query33 2.91 2.88 2.82
query34 16.90 4.41 4.40
query35 4.62 4.49 4.50
query36 0.65 0.49 0.46
query37 0.17 0.16 0.16
query38 0.16 0.15 0.15
query39 0.05 0.03 0.03
query40 0.18 0.14 0.14
query41 0.10 0.05 0.05
query42 0.05 0.04 0.05
query43 0.04 0.04 0.04
Total cold run time: 109.73 s
Total hot run time: 30.59 s