doris
doris copied to clipboard
[fix](auth)Stream load not have usage priv for workload group
Proposed changes
Issue Number: close #xxx
When requesting execution plans from FE through RPC, the client IP was previously used and changed to the matching user host. For example, the previous version was' 82.157.43.14 ', and the later version after the modification was' 82.157.43%', FE will directly build userIdentity using the brought IP. Due to the possibility that only user a @'82.157.43.% 'may exist on FE and not a @'82.157.43.14', the user may not have permission.
Further comments
If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...
Thank you for your contribution to Apache Doris. Don't know what should be done next? See How to process your PR
Since 2024-03-18, the Document has been moved to doris-website. See Doris Document.
clang-tidy review says "All clean, LGTM! :+1:"
clang-tidy review says "All clean, LGTM! :+1:"
clang-tidy review says "All clean, LGTM! :+1:"
clang-tidy review says "All clean, LGTM! :+1:"
clang-tidy review says "All clean, LGTM! :+1:"
run buildall
clang-tidy review says "All clean, LGTM! :+1:"
TPC-H: Total hot run time: 41859 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 7a2e86134307c4071f61cf330a35e48812aa61c0, data reload: false
------ Round 1 ----------------------------------
q1 17607 4393 4213 4213
q2 2017 195 187 187
q3 10488 1206 1245 1206
q4 10208 875 840 840
q5 7476 2779 2626 2626
q6 228 136 128 128
q7 1062 628 602 602
q8 9357 2166 2129 2129
q9 9668 6846 6859 6846
q10 9296 4058 3896 3896
q11 446 231 245 231
q12 463 223 233 223
q13 18376 3168 3192 3168
q14 260 218 210 210
q15 525 470 482 470
q16 473 405 397 397
q17 989 640 786 640
q18 8436 7749 7914 7749
q19 1748 1518 1538 1518
q20 654 323 316 316
q21 5271 4318 3991 3991
q22 364 283 273 273
Total cold run time: 115412 ms
Total hot run time: 41859 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4468 4393 4363 4363
q2 378 278 271 271
q3 3178 2995 2771 2771
q4 1889 1641 1692 1641
q5 5552 5504 5483 5483
q6 220 123 121 121
q7 2424 2038 1982 1982
q8 3280 3428 3422 3422
q9 8805 8804 8652 8652
q10 3997 3851 3885 3851
q11 581 496 510 496
q12 825 629 643 629
q13 16119 3180 3142 3142
q14 286 271 274 271
q15 504 468 454 454
q16 473 411 400 400
q17 1748 1485 1457 1457
q18 7793 7688 7360 7360
q19 7476 1633 1531 1531
q20 2007 1758 1779 1758
q21 5033 4821 4787 4787
q22 559 490 484 484
Total cold run time: 77595 ms
Total hot run time: 55326 ms
TPC-DS: Total hot run time: 186216 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 7a2e86134307c4071f61cf330a35e48812aa61c0, data reload: false
query1 900 361 339 339
query2 7387 2279 2298 2279
query3 6652 226 219 219
query4 22945 21277 21160 21160
query5 4106 417 419 417
query6 270 176 172 172
query7 4589 290 286 286
query8 263 191 196 191
query9 8489 2433 2417 2417
query10 441 254 255 254
query11 14623 14120 14151 14120
query12 137 92 86 86
query13 1642 366 395 366
query14 8813 6649 7652 6649
query15 259 164 178 164
query16 8328 256 266 256
query17 1768 570 536 536
query18 2095 269 277 269
query19 226 152 144 144
query20 91 84 84 84
query21 196 128 129 128
query22 5089 4833 4895 4833
query23 33780 33343 33205 33205
query24 6345 2829 2889 2829
query25 565 370 365 365
query26 692 149 150 149
query27 1950 319 329 319
query28 3854 2105 2078 2078
query29 827 591 600 591
query30 231 156 153 153
query31 966 747 722 722
query32 89 54 52 52
query33 483 252 244 244
query34 871 469 480 469
query35 759 682 682 682
query36 1036 914 927 914
query37 102 70 65 65
query38 3213 3011 3014 3011
query39 1580 1539 1533 1533
query40 198 126 126 126
query41 42 40 39 39
query42 107 100 97 97
query43 593 555 541 541
query44 1062 721 745 721
query45 263 260 259 259
query46 1058 718 735 718
query47 1940 1881 1850 1850
query48 373 301 336 301
query49 830 388 394 388
query50 767 398 382 382
query51 6734 6666 6660 6660
query52 107 90 92 90
query53 354 284 295 284
query54 262 234 240 234
query55 81 73 76 73
query56 238 218 216 216
query57 1180 1120 1139 1120
query58 212 192 197 192
query59 3509 3225 3402 3225
query60 264 254 256 254
query61 93 88 88 88
query62 594 467 447 447
query63 303 277 277 277
query64 8246 7217 7199 7199
query65 3099 3018 3003 3003
query66 800 345 338 338
query67 15305 15022 14980 14980
query68 5221 534 531 531
query69 487 301 305 301
query70 1200 1182 1163 1163
query71 375 265 272 265
query72 7604 2533 2318 2318
query73 696 328 322 322
query74 6560 6046 6063 6046
query75 3266 2662 2627 2627
query76 2807 986 960 960
query77 392 324 270 270
query78 10848 10272 10297 10272
query79 3942 525 514 514
query80 1981 426 428 426
query81 535 228 218 218
query82 962 96 95 95
query83 271 167 168 167
query84 271 92 88 88
query85 1810 264 256 256
query86 542 287 292 287
query87 3303 3092 3076 3076
query88 4702 2413 2418 2413
query89 494 388 376 376
query90 2052 185 185 185
query91 123 98 95 95
query92 62 47 47 47
query93 5582 520 504 504
query94 1226 185 177 177
query95 1099 1090 1095 1090
query96 620 262 266 262
query97 3208 2941 2940 2940
query98 246 222 218 218
query99 1221 855 867 855
Total cold run time: 278974 ms
Total hot run time: 186216 ms
TeamCity be ut coverage result: Function Coverage: 35.56% (8932/25115) Line Coverage: 27.20% (73681/270910) Region Coverage: 26.38% (38049/144216) Branch Coverage: 23.17% (19396/83716) Coverage Report: http://coverage.selectdb-in.cc/coverage/7a2e86134307c4071f61cf330a35e48812aa61c0_7a2e86134307c4071f61cf330a35e48812aa61c0/report/index.html
clang-tidy review says "All clean, LGTM! :+1:"
PR approved by at least one committer and no changes requested.
PR approved by anyone and no changes requested.
run buildall
TPC-DS: Total hot run time: 187721 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit be48030c66aa13785b58ee4862ae3dfe4caeae78, data reload: false
query1 905 362 347 347
query2 6802 2343 2379 2343
query3 6663 212 212 212
query4 25346 21925 21943 21925
query5 3776 424 421 421
query6 263 185 174 174
query7 4536 312 293 293
query8 252 196 189 189
query9 8728 2504 2483 2483
query10 424 253 259 253
query11 15381 14916 14801 14801
query12 120 91 87 87
query13 1722 373 380 373
query14 10503 8582 7516 7516
query15 282 179 190 179
query16 8241 277 273 273
query17 1946 554 543 543
query18 2091 270 263 263
query19 312 149 144 144
query20 86 83 84 83
query21 189 128 121 121
query22 5068 4817 4803 4803
query23 33973 33539 33454 33454
query24 10535 2961 2796 2796
query25 596 355 354 354
query26 1122 147 144 144
query27 2616 322 314 314
query28 6818 2066 2061 2061
query29 872 593 576 576
query30 218 148 147 147
query31 976 707 710 707
query32 92 49 52 49
query33 735 239 241 239
query34 1021 484 489 484
query35 780 664 682 664
query36 1032 909 871 871
query37 137 64 68 64
query38 3161 3035 2966 2966
query39 1603 1587 1520 1520
query40 194 121 123 121
query41 40 38 37 37
query42 104 95 97 95
query43 590 549 558 549
query44 1177 735 731 731
query45 261 257 244 244
query46 1071 715 717 715
query47 1926 1826 1863 1826
query48 375 292 291 291
query49 830 383 391 383
query50 777 384 382 382
query51 6689 6644 6665 6644
query52 107 91 95 91
query53 364 279 285 279
query54 304 231 230 230
query55 78 79 75 75
query56 264 222 220 220
query57 1232 1129 1125 1125
query58 220 198 195 195
query59 3504 3238 3118 3118
query60 259 232 234 232
query61 91 86 102 86
query62 639 445 449 445
query63 313 280 288 280
query64 8510 7222 7195 7195
query65 3060 3089 3052 3052
query66 813 336 328 328
query67 15527 14970 14963 14963
query68 5364 548 534 534
query69 491 306 301 301
query70 1185 1135 1069 1069
query71 470 279 269 269
query72 7244 2563 2383 2383
query73 710 327 329 327
query74 6640 6101 6113 6101
query75 3518 2615 2617 2615
query76 3281 944 964 944
query77 446 267 280 267
query78 11067 10238 10316 10238
query79 3566 518 545 518
query80 2102 436 443 436
query81 541 223 217 217
query82 892 93 93 93
query83 282 182 191 182
query84 264 91 91 91
query85 2157 329 290 290
query86 488 308 301 301
query87 3292 3054 3018 3018
query88 4735 2417 2421 2417
query89 499 377 382 377
query90 2102 186 186 186
query91 128 98 97 97
query92 60 47 49 47
query93 5220 504 501 501
query94 1296 184 186 184
query95 398 302 312 302
query96 590 273 271 271
query97 3152 2905 2928 2905
query98 257 223 222 222
query99 1280 891 850 850
Total cold run time: 292959 ms
Total hot run time: 187721 ms
TeamCity be ut coverage result: Function Coverage: 35.61% (8934/25087) Line Coverage: 27.23% (73708/270652) Region Coverage: 26.41% (38064/144117) Branch Coverage: 23.19% (19405/83668) Coverage Report: http://coverage.selectdb-in.cc/coverage/be48030c66aa13785b58ee4862ae3dfe4caeae78_be48030c66aa13785b58ee4862ae3dfe4caeae78/report/index.html
run buildall
clang-tidy review says "All clean, LGTM! :+1:"
TeamCity be ut coverage result: Function Coverage: 35.61% (8934/25087) Line Coverage: 27.22% (73668/270652) Region Coverage: 26.41% (38067/144117) Branch Coverage: 23.19% (19400/83668) Coverage Report: http://coverage.selectdb-in.cc/coverage/13156c53109a29d1d9f50c2e8124ca73adb87e95_13156c53109a29d1d9f50c2e8124ca73adb87e95/report/index.html
TPC-H: Total hot run time: 40603 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 13156c53109a29d1d9f50c2e8124ca73adb87e95, data reload: false
------ Round 1 ----------------------------------
q1 18036 4404 4306 4306
q2 2532 192 192 192
q3 10990 1224 1146 1146
q4 10518 847 834 834
q5 7500 2745 2661 2661
q6 217 133 131 131
q7 1035 617 603 603
q8 9328 2116 2052 2052
q9 9142 6596 6476 6476
q10 8850 3702 3702 3702
q11 463 246 235 235
q12 427 219 222 219
q13 17782 2987 2958 2958
q14 250 214 225 214
q15 536 484 463 463
q16 502 391 382 382
q17 953 663 682 663
q18 8046 7402 7443 7402
q19 4440 1548 1503 1503
q20 636 307 304 304
q21 5044 3878 4062 3878
q22 356 279 292 279
Total cold run time: 117583 ms
Total hot run time: 40603 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4317 4177 4174 4174
q2 370 274 277 274
q3 2952 2816 2720 2720
q4 1858 1564 1613 1564
q5 5267 5222 5324 5222
q6 207 123 124 123
q7 2211 1892 1883 1883
q8 3171 3310 3320 3310
q9 8413 8424 8464 8424
q10 3895 3629 3619 3619
q11 557 484 488 484
q12 745 623 595 595
q13 17384 2928 2942 2928
q14 273 289 254 254
q15 523 463 470 463
q16 473 398 422 398
q17 1747 1475 1461 1461
q18 7628 7527 7291 7291
q19 1682 1570 1559 1559
q20 1953 1759 1812 1759
q21 5046 4908 5014 4908
q22 564 483 472 472
Total cold run time: 71236 ms
Total hot run time: 53885 ms
TPC-DS: Total hot run time: 185106 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 13156c53109a29d1d9f50c2e8124ca73adb87e95, data reload: false
query1 912 355 354 354
query2 6456 2435 2431 2431
query3 6662 212 220 212
query4 22871 21216 21337 21216
query5 4222 415 430 415
query6 268 172 166 166
query7 4591 295 286 286
query8 242 192 183 183
query9 8660 2421 2403 2403
query10 439 248 237 237
query11 14856 14117 14138 14117
query12 138 94 86 86
query13 1634 371 382 371
query14 9712 7498 6566 6566
query15 244 177 168 168
query16 8183 269 267 267
query17 1846 566 550 550
query18 2107 291 276 276
query19 225 156 152 152
query20 91 87 87 87
query21 206 128 128 128
query22 5008 4798 4857 4798
query23 33889 33234 33343 33234
query24 12112 2949 2864 2864
query25 638 358 368 358
query26 1741 156 153 153
query27 3093 320 329 320
query28 7742 2059 2052 2052
query29 1011 611 593 593
query30 296 149 155 149
query31 994 767 710 710
query32 96 50 51 50
query33 745 245 242 242
query34 1079 476 487 476
query35 829 671 668 668
query36 1083 942 910 910
query37 274 69 66 66
query38 3167 2978 2965 2965
query39 1581 1535 1557 1535
query40 274 124 125 124
query41 44 38 40 38
query42 106 96 95 95
query43 572 560 529 529
query44 1194 719 740 719
query45 272 258 261 258
query46 1088 754 693 693
query47 1936 1867 1862 1862
query48 377 299 288 288
query49 1186 387 395 387
query50 773 381 397 381
query51 6645 6566 6663 6566
query52 106 93 93 93
query53 353 278 274 274
query54 311 239 235 235
query55 78 75 72 72
query56 236 214 226 214
query57 1252 1144 1173 1144
query58 217 194 194 194
query59 3356 3461 3173 3173
query60 255 241 232 232
query61 89 85 87 85
query62 663 448 432 432
query63 309 277 274 274
query64 9602 7197 7214 7197
query65 3155 3038 3037 3037
query66 1377 334 337 334
query67 15221 15149 14858 14858
query68 5878 547 541 541
query69 521 357 322 322
query70 1148 1122 1144 1122
query71 461 268 264 264
query72 7980 2547 2335 2335
query73 723 325 319 319
query74 6454 6025 6015 6015
query75 3866 2644 2609 2609
query76 4159 1003 938 938
query77 620 265 261 261
query78 10899 10257 10376 10257
query79 4810 552 528 528
query80 1863 430 426 426
query81 512 221 232 221
query82 1686 99 91 91
query83 339 170 163 163
query84 266 91 83 83
query85 1617 268 268 268
query86 485 310 296 296
query87 3309 3065 3082 3065
query88 4922 2425 2417 2417
query89 487 384 376 376
query90 1979 182 175 175
query91 126 96 99 96
query92 59 48 47 47
query93 5212 518 512 512
query94 1247 184 179 179
query95 386 299 301 299
query96 606 273 265 265
query97 3142 2915 2980 2915
query98 236 218 225 218
query99 1274 881 895 881
Total cold run time: 298262 ms
Total hot run time: 185106 ms