doris icon indicating copy to clipboard operation
doris copied to clipboard

[Chore](hash) split out init_hash_method from node/operator

Open BiteTheDDDDt opened this issue 9 months ago • 12 comments

Proposed changes

split out init_hash_method from node/operator

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

BiteTheDDDDt avatar Apr 29 '24 07:04 BiteTheDDDDt

Thank you for your contribution to Apache Doris. Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website. See Doris Document.

doris-robot avatar Apr 29 '24 07:04 doris-robot

run buildall

BiteTheDDDDt avatar Apr 29 '24 07:04 BiteTheDDDDt

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Apr 29 '24 07:04 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Apr 29 '24 07:04 github-actions[bot]

TeamCity be ut coverage result: Function Coverage: 35.60% (8932/25093) Line Coverage: 27.25% (73651/270288) Region Coverage: 26.44% (38044/143878) Branch Coverage: 23.25% (19387/83372) Coverage Report: http://coverage.selectdb-in.cc/coverage/7e6049dcc7fbe4eca9da4346e1a4a6848bedeb21_7e6049dcc7fbe4eca9da4346e1a4a6848bedeb21/report/index.html

doris-robot avatar Apr 29 '24 08:04 doris-robot

TPC-DS: Total hot run time: 187849 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 7e6049dcc7fbe4eca9da4346e1a4a6848bedeb21, data reload: false

query1	902	358	348	348
query2	6205	2435	2415	2415
query3	6680	221	216	216
query4	24483	21946	21969	21946
query5	3865	427	443	427
query6	268	174	176	174
query7	4542	294	297	294
query8	237	189	183	183
query9	8507	2391	2391	2391
query10	421	259	275	259
query11	15340	14772	14911	14772
query12	123	87	87	87
query13	1618	379	354	354
query14	8733	8655	7459	7459
query15	271	167	165	165
query16	8214	255	255	255
query17	1795	546	528	528
query18	2082	305	264	264
query19	317	159	155	155
query20	85	83	80	80
query21	190	129	118	118
query22	5027	4874	4865	4865
query23	34007	33316	33225	33225
query24	10648	2995	2996	2995
query25	585	370	376	370
query26	783	148	146	146
query27	2224	354	352	352
query28	6198	2004	2022	2004
query29	845	596	604	596
query30	248	150	145	145
query31	932	739	717	717
query32	90	50	54	50
query33	742	256	246	246
query34	1006	469	463	463
query35	840	668	658	658
query36	1077	924	889	889
query37	108	65	66	65
query38	3136	3018	3009	3009
query39	1576	1541	1529	1529
query40	208	121	124	121
query41	39	37	38	37
query42	103	101	94	94
query43	561	552	547	547
query44	1171	722	731	722
query45	291	258	264	258
query46	1062	758	705	705
query47	1924	1855	1884	1855
query48	371	292	291	291
query49	828	393	384	384
query50	756	375	384	375
query51	6906	6790	6799	6790
query52	100	93	87	87
query53	344	280	278	278
query54	309	239	237	237
query55	81	77	74	74
query56	237	219	218	218
query57	1210	1132	1137	1132
query58	217	193	195	193
query59	3287	3143	3143	3143
query60	255	229	232	229
query61	117	89	86	86
query62	654	448	451	448
query63	299	276	285	276
query64	8203	7164	7131	7131
query65	3093	3048	3024	3024
query66	827	335	339	335
query67	15394	14978	14974	14974
query68	5372	523	537	523
query69	492	300	303	300
query70	1167	1128	1136	1128
query71	421	266	269	266
query72	7117	2604	2422	2422
query73	711	313	313	313
query74	6467	6073	6160	6073
query75	3347	2699	2665	2665
query76	3335	1052	989	989
query77	380	267	268	267
query78	10937	10267	10211	10211
query79	6134	525	527	525
query80	1970	433	445	433
query81	555	228	224	224
query82	1759	95	95	95
query83	321	179	171	171
query84	310	83	85	83
query85	1482	265	279	265
query86	477	322	279	279
query87	3333	3089	3149	3089
query88	5192	2326	2326	2326
query89	498	379	373	373
query90	1985	180	184	180
query91	124	98	95	95
query92	61	58	52	52
query93	5351	510	510	510
query94	1147	176	182	176
query95	381	313	302	302
query96	601	263	261	261
query97	3138	2950	2989	2950
query98	237	226	210	210
query99	1230	859	835	835
Total cold run time: 289829 ms
Total hot run time: 187849 ms

doris-robot avatar Apr 29 '24 08:04 doris-robot

run buildall

BiteTheDDDDt avatar Apr 29 '24 08:04 BiteTheDDDDt

TPC-H: Total hot run time: 40301 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 53a0e62f779f610835304d1d6af9c278b6f5e40e, data reload: false

------ Round 1 ----------------------------------
q1	17626	4376	4260	4260
q2	2024	199	196	196
q3	10668	1309	1252	1252
q4	10380	827	736	736
q5	7847	2785	2672	2672
q6	218	132	137	132
q7	1035	655	627	627
q8	9432	2150	2071	2071
q9	9308	6786	6731	6731
q10	9009	3739	3665	3665
q11	457	242	262	242
q12	394	223	224	223
q13	17768	2956	2929	2929
q14	282	227	233	227
q15	518	463	468	463
q16	484	394	383	383
q17	964	659	716	659
q18	8040	7527	7289	7289
q19	1636	1525	1522	1522
q20	657	319	309	309
q21	5091	3951	3440	3440
q22	345	273	281	273
Total cold run time: 114183 ms
Total hot run time: 40301 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4242	4178	4251	4178
q2	360	274	271	271
q3	3019	2791	2740	2740
q4	1842	1641	1600	1600
q5	5277	5281	5326	5281
q6	209	121	126	121
q7	2218	1912	1869	1869
q8	3188	3308	3309	3308
q9	8570	8549	8598	8549
q10	3881	3703	3650	3650
q11	582	478	483	478
q12	729	606	592	592
q13	16802	2931	2929	2929
q14	296	270	284	270
q15	507	474	473	473
q16	488	409	421	409
q17	1764	1487	1465	1465
q18	7580	7461	7414	7414
q19	1627	1583	1480	1480
q20	1980	1782	1739	1739
q21	4798	4843	4674	4674
q22	560	476	491	476
Total cold run time: 70519 ms
Total hot run time: 53966 ms

doris-robot avatar Apr 29 '24 08:04 doris-robot

TeamCity be ut coverage result: Function Coverage: 35.60% (8934/25097) Line Coverage: 27.25% (73666/270311) Region Coverage: 26.45% (38058/143879) Branch Coverage: 23.26% (19392/83370) Coverage Report: http://coverage.selectdb-in.cc/coverage/53a0e62f779f610835304d1d6af9c278b6f5e40e_53a0e62f779f610835304d1d6af9c278b6f5e40e/report/index.html

doris-robot avatar Apr 29 '24 08:04 doris-robot

TPC-DS: Total hot run time: 186566 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 53a0e62f779f610835304d1d6af9c278b6f5e40e, data reload: false

query1	910	368	345	345
query2	6459	2553	2325	2325
query3	6651	210	210	210
query4	24638	21151	21191	21151
query5	4174	431	433	431
query6	277	180	173	173
query7	4597	293	288	288
query8	244	190	181	181
query9	8517	2355	2336	2336
query10	425	239	254	239
query11	14732	14121	14206	14121
query12	138	94	89	89
query13	1642	366	370	366
query14	10349	7387	7415	7387
query15	243	168	169	168
query16	8059	263	259	259
query17	1857	564	533	533
query18	2072	272	263	263
query19	198	151	145	145
query20	93	87	82	82
query21	199	130	126	126
query22	5086	4975	4869	4869
query23	33956	33035	33155	33035
query24	11672	3018	2957	2957
query25	651	365	364	364
query26	1761	154	148	148
query27	2957	313	320	313
query28	7559	2053	2049	2049
query29	1021	609	598	598
query30	297	149	156	149
query31	955	746	708	708
query32	82	51	54	51
query33	736	254	250	250
query34	1064	473	475	473
query35	832	682	688	682
query36	1112	922	930	922
query37	177	69	68	68
query38	3179	3000	3051	3000
query39	1603	1533	1519	1519
query40	266	127	126	126
query41	41	40	39	39
query42	104	99	98	98
query43	576	570	547	547
query44	1201	734	755	734
query45	292	266	286	266
query46	1086	710	749	710
query47	1970	1845	1842	1842
query48	370	301	288	288
query49	1187	399	406	399
query50	770	387	391	387
query51	6684	6717	6662	6662
query52	103	90	91	90
query53	344	276	274	274
query54	313	252	254	252
query55	82	73	71	71
query56	240	223	214	214
query57	1219	1100	1131	1100
query58	228	194	195	194
query59	3556	3222	3046	3046
query60	259	236	240	236
query61	90	103	107	103
query62	644	453	436	436
query63	308	277	281	277
query64	9591	7233	7175	7175
query65	3113	3037	3029	3029
query66	1398	362	345	345
query67	15559	15537	15489	15489
query68	5410	540	539	539
query69	515	303	305	303
query70	1242	1213	1139	1139
query71	423	276	270	270
query72	7986	2726	2535	2535
query73	707	322	326	322
query74	6530	6247	6110	6110
query75	3603	2734	2639	2639
query76	3957	956	937	937
query77	649	271	266	266
query78	10989	10332	10214	10214
query79	11257	558	543	543
query80	1869	444	443	443
query81	551	221	222	221
query82	843	93	91	91
query83	218	169	169	169
query84	269	83	84	83
query85	1464	265	256	256
query86	470	306	305	305
query87	3341	3125	3077	3077
query88	5587	2374	2365	2365
query89	542	387	386	386
query90	1987	189	185	185
query91	128	96	100	96
query92	61	49	47	47
query93	7784	531	507	507
query94	1247	185	183	183
query95	401	304	318	304
query96	611	271	268	268
query97	3163	2933	2934	2933
query98	243	227	215	215
query99	1336	839	813	813
Total cold run time: 308151 ms
Total hot run time: 186566 ms

doris-robot avatar Apr 29 '24 08:04 doris-robot

PR approved by at least one committer and no changes requested.

github-actions[bot] avatar May 02 '24 14:05 github-actions[bot]

PR approved by anyone and no changes requested.

github-actions[bot] avatar May 02 '24 14:05 github-actions[bot]

run buildall

BiteTheDDDDt avatar May 06 '24 06:05 BiteTheDDDDt

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar May 06 '24 06:05 github-actions[bot]

TeamCity be ut coverage result: Function Coverage: 35.61% (8965/25174) Line Coverage: 27.28% (73972/271189) Region Coverage: 26.50% (38214/144183) Branch Coverage: 23.30% (19464/83530) Coverage Report: http://coverage.selectdb-in.cc/coverage/70998b8df87da6bc6c9141da65116c3ebb5b685e_70998b8df87da6bc6c9141da65116c3ebb5b685e/report/index.html

doris-robot avatar May 06 '24 07:05 doris-robot

TPC-DS: Total hot run time: 187775 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 70998b8df87da6bc6c9141da65116c3ebb5b685e, data reload: false

query1	905	352	350	350
query2	6290	2408	2382	2382
query3	6639	205	208	205
query4	22885	21641	22199	21641
query5	3901	442	423	423
query6	271	184	183	183
query7	4569	294	304	294
query8	262	184	182	182
query9	8460	2425	2453	2425
query10	413	256	252	252
query11	15273	14789	14823	14789
query12	120	87	91	87
query13	1639	375	382	375
query14	8636	8758	7621	7621
query15	260	179	169	169
query16	8198	262	269	262
query17	1766	564	561	561
query18	2099	287	270	270
query19	335	158	153	153
query20	90	85	85	85
query21	193	130	126	126
query22	5100	4848	4839	4839
query23	34449	33371	33085	33085
query24	10610	2936	2820	2820
query25	625	374	376	374
query26	1137	156	150	150
query27	2335	316	361	316
query28	7204	2057	2045	2045
query29	856	617	611	611
query30	250	153	149	149
query31	965	727	736	727
query32	97	53	52	52
query33	741	240	241	240
query34	1063	493	473	473
query35	790	679	659	659
query36	1103	920	900	900
query37	136	69	65	65
query38	3190	2990	2996	2990
query39	1591	1548	1528	1528
query40	202	127	121	121
query41	40	38	38	38
query42	106	95	98	95
query43	550	546	508	508
query44	1243	737	739	737
query45	265	249	248	248
query46	1070	704	727	704
query47	1939	1856	1852	1852
query48	366	286	303	286
query49	863	392	381	381
query50	767	387	392	387
query51	6919	6649	6691	6649
query52	106	87	94	87
query53	346	282	284	282
query54	314	233	234	233
query55	77	76	73	73
query56	244	219	221	219
query57	1225	1149	1121	1121
query58	228	201	195	195
query59	3328	3033	3040	3033
query60	250	232	239	232
query61	88	86	88	86
query62	633	458	444	444
query63	308	282	279	279
query64	8644	7196	7166	7166
query65	3115	3049	3055	3049
query66	855	320	324	320
query67	15636	15019	14964	14964
query68	7121	542	547	542
query69	546	343	295	295
query70	1117	1125	1152	1125
query71	516	272	268	268
query72	7758	2542	2374	2374
query73	720	318	322	318
query74	6569	6020	6128	6020
query75	4777	2606	2600	2600
query76	4715	1030	1026	1026
query77	760	276	268	268
query78	10984	10188	10123	10123
query79	8883	516	525	516
query80	1355	430	434	430
query81	511	231	221	221
query82	1432	89	93	89
query83	208	169	165	165
query84	266	85	83	83
query85	1478	265	263	263
query86	471	315	283	283
query87	3259	3074	3053	3053
query88	5123	2333	2324	2324
query89	570	377	371	371
query90	1998	185	180	180
query91	129	99	100	99
query92	59	48	49	48
query93	7464	515	514	514
query94	1210	217	183	183
query95	1098	1085	1081	1081
query96	609	267	266	266
query97	3183	2923	2954	2923
query98	225	224	214	214
query99	1300	863	870	863
Total cold run time: 301587 ms
Total hot run time: 187775 ms

doris-robot avatar May 06 '24 07:05 doris-robot

PR approved by at least one committer and no changes requested.

github-actions[bot] avatar May 06 '24 09:05 github-actions[bot]