doris
doris copied to clipboard
Published
20 hours ago •
apache
apache
[FIX]fix is_ip_address_in_range func with const param
Proposed changes
Issue Number: close #xxx
pr https://github.com/apache/doris/pull/32580 and https://github.com/apache/doris/pull/33968 legacy work.
- before this pr:
mysql> select id, is_ip_address_in_range(addr, '192.168.100.0/24') from test_is_ip_address_in_range_function order by id;
ERROR 1105 (HY000): errCode = 2, detailMessage = (10.214.224.189)[CANCELLED][INVALID_ARGUMENT][E33] Illegal column Const(String) of argument of function is_ip_address_in_range, expected String
0# doris::get_stack_trace(int, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >) at /home/ysj/doris/be/src/util/stack_util.cpp:54
1# doris::Exception::Exception(int, std::basic_string_view<char, std::char_traits<char> > const&) at /home/ysj/doris/be/src/common/exception.cpp:28
2# doris::Exception::E
- after this pr: Execute normally without any errors when input is const param.
Further comments
If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...
Thank you for your contribution to Apache Doris. Don't know what should be done next? See How to process your PR
Since 2024-03-18, the Document has been moved to doris-website. See Doris Document.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
TeamCity be ut coverage result: Function Coverage: 35.51% (8929/25146) Line Coverage: 27.20% (73645/270710) Region Coverage: 26.39% (38036/144154) Branch Coverage: 23.19% (19391/83616) Coverage Report: http://coverage.selectdb-in.cc/coverage/578dcf322120b30aef6c4cd81270fcb92c16432f_578dcf322120b30aef6c4cd81270fcb92c16432f/report/index.html
TPC-DS: Total hot run time: 188352 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 578dcf322120b30aef6c4cd81270fcb92c16432f, data reload: false
query1 904 359 345 345
query2 6151 2485 2499 2485
query3 6674 215 215 215
query4 23938 21810 21886 21810
query5 3779 428 435 428
query6 268 182 197 182
query7 4555 310 293 293
query8 248 198 191 191
query9 8571 2407 2401 2401
query10 403 248 278 248
query11 15510 14940 14831 14831
query12 116 84 89 84
query13 1627 367 363 363
query14 10515 7692 8509 7692
query15 254 178 172 172
query16 8470 277 273 273
query17 1931 603 558 558
query18 2206 272 276 272
query19 324 150 149 149
query20 91 91 95 91
query21 198 128 122 122
query22 5086 4870 4866 4866
query23 33714 33173 33168 33168
query24 10628 2915 2948 2915
query25 582 364 379 364
query26 1113 155 148 148
query27 2320 317 315 315
query28 7165 2057 2033 2033
query29 874 628 631 628
query30 252 150 157 150
query31 952 719 728 719
query32 90 52 55 52
query33 745 250 245 245
query34 982 465 481 465
query35 791 656 646 646
query36 1042 920 895 895
query37 133 67 68 67
query38 3173 3041 3005 3005
query39 1576 1544 1542 1542
query40 198 126 126 126
query41 42 42 40 40
query42 104 96 95 95
query43 577 544 565 544
query44 1246 732 737 732
query45 292 258 265 258
query46 1083 724 723 723
query47 1925 1828 1854 1828
query48 387 291 299 291
query49 846 401 401 401
query50 765 391 377 377
query51 6806 6950 6642 6642
query52 97 97 93 93
query53 372 280 280 280
query54 316 245 261 245
query55 80 76 75 75
query56 259 227 229 227
query57 1233 1124 1146 1124
query58 236 206 208 206
query59 3605 3387 3337 3337
query60 273 255 247 247
query61 109 106 106 106
query62 701 435 449 435
query63 301 279 288 279
query64 8544 7209 7229 7209
query65 3099 3074 3055 3055
query66 831 332 328 328
query67 15587 15159 14902 14902
query68 8159 583 553 553
query69 531 312 311 311
query70 1150 1096 1079 1079
query71 542 270 269 269
query72 7931 2640 2477 2477
query73 740 334 337 334
query74 6614 6052 6142 6052
query75 4747 2682 2773 2682
query76 5185 1020 989 989
query77 744 272 270 270
query78 11046 10283 10138 10138
query79 11259 522 520 520
query80 1505 432 437 432
query81 492 217 226 217
query82 827 90 90 90
query83 208 166 163 163
query84 260 87 87 87
query85 1418 283 273 273
query86 418 323 313 313
query87 3309 3060 3097 3060
query88 5444 2426 2437 2426
query89 523 382 378 378
query90 2005 186 187 186
query91 150 101 101 101
query92 71 46 47 46
query93 7447 524 513 513
query94 1258 180 185 180
query95 395 306 310 306
query96 612 277 271 271
query97 3118 2934 2944 2934
query98 232 217 214 214
query99 1241 871 855 855
Total cold run time: 307446 ms
Total hot run time: 188352 ms
TeamCity be ut coverage result: Function Coverage: 35.71% (8975/25133) Line Coverage: 27.33% (74091/271123) Region Coverage: 26.53% (38301/144350) Branch Coverage: 23.28% (19516/83814) Coverage Report: http://coverage.selectdb-in.cc/coverage/74f9541397961cb5e556391a7e9ceb043c0e4ded_74f9541397961cb5e556391a7e9ceb043c0e4ded/report/index.html
TPC-DS: Total hot run time: 186972 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 74f9541397961cb5e556391a7e9ceb043c0e4ded, data reload: false
query1 913 371 362 362
query2 6194 2357 2296 2296
query3 6652 203 209 203
query4 23049 21767 21877 21767
query5 4063 439 414 414
query6 255 186 169 169
query7 4738 290 293 290
query8 237 174 182 174
query9 8552 2392 2392 2392
query10 417 250 253 250
query11 15582 14981 14824 14824
query12 122 90 85 85
query13 1672 376 381 376
query14 9623 7475 8355 7475
query15 263 166 170 166
query16 8178 263 258 258
query17 1727 563 549 549
query18 2120 289 270 270
query19 314 147 151 147
query20 89 84 83 83
query21 189 126 120 120
query22 4978 4821 4844 4821
query23 33869 33216 33032 33032
query24 10774 2822 2917 2822
query25 609 356 354 354
query26 1258 152 153 152
query27 2900 314 317 314
query28 7243 1984 1993 1984
query29 837 614 627 614
query30 248 152 148 148
query31 946 709 735 709
query32 86 52 52 52
query33 744 243 237 237
query34 1043 476 496 476
query35 813 653 670 653
query36 1036 902 911 902
query37 128 67 65 65
query38 3165 3031 2962 2962
query39 1595 1529 1518 1518
query40 198 126 123 123
query41 39 37 39 37
query42 106 91 98 91
query43 532 531 523 523
query44 1242 742 748 742
query45 262 246 256 246
query46 1068 754 748 748
query47 1926 1863 1871 1863
query48 394 300 305 300
query49 899 391 383 383
query50 766 385 397 385
query51 6868 6626 6577 6577
query52 102 94 85 85
query53 343 282 299 282
query54 299 237 232 232
query55 78 69 70 69
query56 239 215 220 215
query57 1244 1109 1133 1109
query58 232 199 195 195
query59 3250 3120 3046 3046
query60 250 233 237 233
query61 91 88 86 86
query62 650 458 460 458
query63 301 287 286 286
query64 8586 7271 7317 7271
query65 3131 3024 3091 3024
query66 904 344 328 328
query67 15240 14883 14771 14771
query68 5322 533 534 533
query69 530 310 304 304
query70 1201 1112 1075 1075
query71 431 269 266 266
query72 8071 2558 2488 2488
query73 714 321 324 321
query74 6559 6096 6053 6053
query75 3711 2634 2636 2634
query76 3980 1094 968 968
query77 594 267 267 267
query78 10769 10218 10337 10218
query79 7519 552 530 530
query80 1439 460 470 460
query81 508 228 228 228
query82 856 96 94 94
query83 198 167 166 166
query84 268 89 94 89
query85 1412 315 330 315
query86 411 319 284 284
query87 3285 3062 3040 3040
query88 4862 2445 2430 2430
query89 489 382 371 371
query90 2039 201 195 195
query91 135 108 105 105
query92 62 51 50 50
query93 5805 511 503 503
query94 1124 190 191 190
query95 395 313 317 313
query96 624 280 281 280
query97 3108 2959 2935 2935
query98 243 221 221 221
query99 1266 892 853 853
Total cold run time: 294391 ms
Total hot run time: 186972 ms
PR approved by at least one committer and no changes requested.