doris icon indicating copy to clipboard operation
doris copied to clipboard

[BugFix](StoragePolicy) fix modify partition's storage policy with different resource issue succeed with execption

Open GoGoWen opened this issue 10 months ago • 7 comments

Proposed changes

version: 2.0.9

when we try to modify a partition's storage policy which have different resource with the previous one, we get error message "currently do not support change origin storage policy to another one with different resource", but the modification same also succeed!

expect: the modification fail with "currently do not support change origin storage policy to another one with different resource".

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

GoGoWen avatar Apr 28 '24 07:04 GoGoWen

Thank you for your contribution to Apache Doris. Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website. See Doris Document.

doris-robot avatar Apr 28 '24 07:04 doris-robot

run buildall

xiaokang avatar Apr 30 '24 08:04 xiaokang

TPC-H: Total hot run time: 49669 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit e76239f3979c806728d9ea6674e2c978e9092ab8, data reload: false

------ Round 1 ----------------------------------
q1	17603	4449	4436	4436
q2	2055	153	150	150
q3	10329	1867	1933	1867
q4	10399	1201	1300	1201
q5	8453	3875	3890	3875
q6	228	124	122	122
q7	2012	1607	1579	1579
q8	9527	2685	2684	2684
q9	12673	10349	10179	10179
q10	8618	3485	3493	3485
q11	419	245	242	242
q12	457	302	313	302
q13	18320	3988	4079	3988
q14	360	329	324	324
q15	502	493	454	454
q16	658	568	563	563
q17	1110	955	956	955
q18	7370	6919	6929	6919
q19	1685	1561	1536	1536
q20	509	312	312	312
q21	4432	4112	4115	4112
q22	494	384	398	384
Total cold run time: 118213 ms
Total hot run time: 49669 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4369	4293	4373	4293
q2	321	218	224	218
q3	4213	4154	4130	4130
q4	2771	2770	2753	2753
q5	7219	7143	7177	7143
q6	235	119	118	118
q7	3241	2866	2861	2861
q8	4525	4658	4619	4619
q9	17256	17159	16915	16915
q10	4245	4300	4325	4300
q11	757	685	688	685
q12	1016	859	866	859
q13	7655	3761	3714	3714
q14	453	417	429	417
q15	488	458	460	458
q16	737	701	681	681
q17	3822	3852	3882	3852
q18	8774	8839	8789	8789
q19	1685	1697	1685	1685
q20	2411	2168	2085	2085
q21	8469	8471	8506	8471
q22	1059	906	992	906
Total cold run time: 85721 ms
Total hot run time: 79952 ms

doris-robot avatar Apr 30 '24 08:04 doris-robot

TPC-DS: Total hot run time: 203684 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit e76239f3979c806728d9ea6674e2c978e9092ab8, data reload: false

query1	925	403	395	395
query2	6556	2878	2583	2583
query3	6928	204	193	193
query4	20037	18060	17971	17971
query5	19713	6610	6565	6565
query6	280	215	230	215
query7	4148	302	312	302
query8	251	269	244	244
query9	3097	2666	2604	2604
query10	410	311	302	302
query11	11302	10830	10685	10685
query12	130	80	75	75
query13	5575	680	716	680
query14	18254	13617	13956	13617
query15	382	212	239	212
query16	5673	266	252	252
query17	1557	1476	871	871
query18	2288	408	409	408
query19	190	148	147	147
query20	76	75	77	75
query21	186	97	91	91
query22	5147	4997	4912	4912
query23	32523	31992	32181	31992
query24	7021	6591	6514	6514
query25	518	422	426	422
query26	562	167	164	164
query27	1922	299	302	299
query28	6184	2353	2323	2323
query29	2964	2672	2709	2672
query30	248	168	164	164
query31	899	740	747	740
query32	65	58	61	58
query33	402	267	245	245
query34	878	472	497	472
query35	1111	932	912	912
query36	1422	1258	1096	1096
query37	92	60	60	60
query38	3103	2905	2933	2905
query39	1373	1325	1328	1325
query40	198	100	106	100
query41	38	35	34	34
query42	91	84	81	81
query43	841	732	717	717
query44	1149	733	717	717
query45	244	234	227	227
query46	1237	999	990	990
query47	2030	1816	1884	1816
query48	1038	744	713	713
query49	608	375	374	374
query50	875	608	591	591
query51	4783	4638	4626	4626
query52	94	85	77	77
query53	446	312	311	311
query54	2675	2502	2494	2494
query55	86	75	70	70
query56	218	208	194	194
query57	1198	1137	1141	1137
query58	226	200	188	188
query59	4246	4308	3943	3943
query60	205	188	214	188
query61	88	81	82	81
query62	796	480	464	464
query63	480	337	343	337
query64	2285	1498	1388	1388
query65	3718	3610	3584	3584
query66	793	369	386	369
query67	16634	15596	15443	15443
query68	8861	654	683	654
query69	570	338	350	338
query70	1796	1371	1431	1371
query71	390	327	306	306
query72	6570	3417	3435	3417
query73	729	318	317	317
query74	6258	5806	5810	5806
query75	5395	3759	3814	3759
query76	5457	1141	1205	1141
query77	917	252	254	252
query78	12602	11555	11663	11555
query79	7683	653	654	653
query80	1139	405	399	399
query81	489	235	237	235
query82	1591	103	95	95
query83	174	135	127	127
query84	251	68	69	68
query85	842	301	298	298
query86	333	313	324	313
query87	3265	3002	3016	3002
query88	4926	2299	2304	2299
query89	377	298	300	298
query90	1911	211	209	209
query91	169	131	147	131
query92	59	53	53	53
query93	5169	588	603	588
query94	701	208	202	202
query95	1125	1075	1074	1074
query96	657	323	320	320
query97	6474	6393	6423	6393
query98	190	173	163	163
query99	2728	832	834	832
Total cold run time: 311510 ms
Total hot run time: 203684 ms

doris-robot avatar Apr 30 '24 08:04 doris-robot

ClickBench: Total hot run time: 30.4 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit e76239f3979c806728d9ea6674e2c978e9092ab8, data reload: false

query1	0.02	0.02	0.02
query2	0.07	0.02	0.02
query3	0.26	0.05	0.05
query4	1.77	0.06	0.06
query5	0.53	0.52	0.52
query6	1.24	0.62	0.62
query7	0.02	0.01	0.01
query8	0.03	0.02	0.03
query9	0.51	0.48	0.47
query10	0.53	0.53	0.53
query11	0.12	0.09	0.08
query12	0.12	0.10	0.09
query13	0.62	0.61	0.60
query14	0.80	0.76	0.78
query15	0.79	0.76	0.77
query16	0.36	0.36	0.35
query17	1.01	0.98	1.02
query18	0.23	0.27	0.24
query19	1.92	1.84	1.86
query20	0.02	0.01	0.01
query21	15.48	0.57	0.56
query22	1.93	2.65	1.64
query23	17.28	1.09	0.92
query24	8.46	0.94	0.56
query25	0.32	0.13	0.05
query26	0.81	0.16	0.15
query27	0.05	0.03	0.05
query28	5.24	0.78	0.80
query29	12.63	2.22	2.36
query30	0.61	0.53	0.51
query31	2.87	0.41	0.38
query32	3.90	0.52	0.50
query33	3.12	3.16	3.22
query34	15.29	4.78	4.79
query35	4.86	4.85	4.84
query36	1.04	1.03	1.03
query37	0.06	0.05	0.04
query38	0.03	0.02	0.02
query39	0.02	0.02	0.01
query40	0.16	0.14	0.14
query41	0.06	0.01	0.01
query42	0.02	0.02	0.02
query43	0.03	0.02	0.02
Total cold run time: 105.24 s
Total hot run time: 30.4 s

doris-robot avatar Apr 30 '24 08:04 doris-robot

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit e76239f3979c806728d9ea6674e2c978e9092ab8 with default session variables
Stream load json:         20 seconds loaded 2358488459 Bytes, about 112 MB/s
Stream load orc:          58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet:      32 seconds loaded 861443392 Bytes, about 25 MB/s
Insert into select:       21.4 seconds inserted 10000000 Rows, about 467K ops/s

doris-robot avatar Apr 30 '24 08:04 doris-robot

@GoGoWen pls add testcase add submit another PR to master

xiaokang avatar May 01 '24 13:05 xiaokang