doris
doris copied to clipboard
[Feature][external catalog/lakesoul] support lakesoul catalog
Proposed changes
Issue Number: close #32163
Further comments
If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...
Thank you for your contribution to Apache Doris. Don't know what should be done next? See How to process your PR
sh-checker report
To get the full details, please check in the job output.
shellcheck errors
'shellcheck ' found no issues.
shfmt errors
'shfmt ' returned error 1 finding the following formatting issues:
----------
--- thirdparty/build-thirdparty.sh.orig
+++ thirdparty/build-thirdparty.sh
@@ -821,7 +821,7 @@
"${CMAKE_CMD}" -G "${GENERATOR}" -DBUILD_SHARED_LIBS=ON -DWITH_GLOG=ON -DCMAKE_INSTALL_PREFIX="${TP_INSTALL_DIR}" \
-DCMAKE_LIBRARY_PATH="${TP_INSTALL_DIR}/lib64" -DCMAKE_INCLUDE_PATH="${TP_INSTALL_DIR}/include" \
-DBUILD_BRPC_TOOLS=OFF \
- -DWITH_SNAPPY=ON \
+ -DWITH_SNAPPY=ON \
-DPROTOBUF_PROTOC_EXECUTABLE="${TP_INSTALL_DIR}/bin/protoc" ..
"${BUILD_SYSTEM}" -j "${PARALLEL}"
----------
You can reformat the above files to meet shfmt's requirements by typing:
shfmt -w filename
sh-checker report
To get the full details, please check in the job output.
shellcheck errors
'shellcheck ' found no issues.
shfmt errors
'shfmt ' returned error 1 finding the following formatting issues:
----------
--- thirdparty/build-thirdparty.sh.orig
+++ thirdparty/build-thirdparty.sh
@@ -821,7 +821,7 @@
"${CMAKE_CMD}" -G "${GENERATOR}" -DBUILD_SHARED_LIBS=ON -DWITH_GLOG=ON -DCMAKE_INSTALL_PREFIX="${TP_INSTALL_DIR}" \
-DCMAKE_LIBRARY_PATH="${TP_INSTALL_DIR}/lib64" -DCMAKE_INCLUDE_PATH="${TP_INSTALL_DIR}/include" \
-DBUILD_BRPC_TOOLS=OFF \
- -DWITH_SNAPPY=ON \
+ -DWITH_SNAPPY=ON \
-DPROTOBUF_PROTOC_EXECUTABLE="${TP_INSTALL_DIR}/bin/protoc" ..
"${BUILD_SYSTEM}" -j "${PARALLEL}"
----------
You can reformat the above files to meet shfmt's requirements by typing:
shfmt -w filename
sh-checker report
To get the full details, please check in the job output.
shellcheck errors
'shellcheck ' found no issues.
shfmt errors
'shfmt ' returned error 1 finding the following formatting issues:
----------
--- thirdparty/build-thirdparty.sh.orig
+++ thirdparty/build-thirdparty.sh
@@ -821,7 +821,7 @@
"${CMAKE_CMD}" -G "${GENERATOR}" -DBUILD_SHARED_LIBS=ON -DWITH_GLOG=ON -DCMAKE_INSTALL_PREFIX="${TP_INSTALL_DIR}" \
-DCMAKE_LIBRARY_PATH="${TP_INSTALL_DIR}/lib64" -DCMAKE_INCLUDE_PATH="${TP_INSTALL_DIR}/include" \
-DBUILD_BRPC_TOOLS=OFF \
- -DWITH_SNAPPY=ON \
+ -DWITH_SNAPPY=ON \
-DPROTOBUF_PROTOC_EXECUTABLE="${TP_INSTALL_DIR}/bin/protoc" ..
"${BUILD_SYSTEM}" -j "${PARALLEL}"
----------
You can reformat the above files to meet shfmt's requirements by typing:
shfmt -w filename
sh-checker report
To get the full details, please check in the job output.
shellcheck errors
'shellcheck ' found no issues.
shfmt errors
'shfmt ' returned error 1 finding the following formatting issues:
----------
--- thirdparty/build-thirdparty.sh.orig
+++ thirdparty/build-thirdparty.sh
@@ -821,7 +821,7 @@
"${CMAKE_CMD}" -G "${GENERATOR}" -DBUILD_SHARED_LIBS=ON -DWITH_GLOG=ON -DCMAKE_INSTALL_PREFIX="${TP_INSTALL_DIR}" \
-DCMAKE_LIBRARY_PATH="${TP_INSTALL_DIR}/lib64" -DCMAKE_INCLUDE_PATH="${TP_INSTALL_DIR}/include" \
-DBUILD_BRPC_TOOLS=OFF \
- -DWITH_SNAPPY=ON \
+ -DWITH_SNAPPY=ON \
-DPROTOBUF_PROTOC_EXECUTABLE="${TP_INSTALL_DIR}/bin/protoc" ..
"${BUILD_SYSTEM}" -j "${PARALLEL}"
----------
You can reformat the above files to meet shfmt's requirements by typing:
shfmt -w filename
sh-checker report
To get the full details, please check in the job output.
shellcheck errors
'shellcheck ' found no issues.
shfmt errors
'shfmt ' returned error 1 finding the following formatting issues:
----------
--- thirdparty/build-thirdparty.sh.orig
+++ thirdparty/build-thirdparty.sh
@@ -821,7 +821,7 @@
"${CMAKE_CMD}" -G "${GENERATOR}" -DBUILD_SHARED_LIBS=ON -DWITH_GLOG=ON -DCMAKE_INSTALL_PREFIX="${TP_INSTALL_DIR}" \
-DCMAKE_LIBRARY_PATH="${TP_INSTALL_DIR}/lib64" -DCMAKE_INCLUDE_PATH="${TP_INSTALL_DIR}/include" \
-DBUILD_BRPC_TOOLS=OFF \
- -DWITH_SNAPPY=ON \
+ -DWITH_SNAPPY=ON \
-DPROTOBUF_PROTOC_EXECUTABLE="${TP_INSTALL_DIR}/bin/protoc" ..
"${BUILD_SYSTEM}" -j "${PARALLEL}"
----------
You can reformat the above files to meet shfmt's requirements by typing:
shfmt -w filename
sh-checker report
To get the full details, please check in the job output.
shellcheck errors
'shellcheck ' found no issues.
shfmt errors
'shfmt ' returned error 1 finding the following formatting issues:
----------
--- thirdparty/build-thirdparty.sh.orig
+++ thirdparty/build-thirdparty.sh
@@ -821,7 +821,7 @@
"${CMAKE_CMD}" -G "${GENERATOR}" -DBUILD_SHARED_LIBS=ON -DWITH_GLOG=ON -DCMAKE_INSTALL_PREFIX="${TP_INSTALL_DIR}" \
-DCMAKE_LIBRARY_PATH="${TP_INSTALL_DIR}/lib64" -DCMAKE_INCLUDE_PATH="${TP_INSTALL_DIR}/include" \
-DBUILD_BRPC_TOOLS=OFF \
- -DWITH_SNAPPY=ON \
+ -DWITH_SNAPPY=ON \
-DPROTOBUF_PROTOC_EXECUTABLE="${TP_INSTALL_DIR}/bin/protoc" ..
"${BUILD_SYSTEM}" -j "${PARALLEL}"
----------
You can reformat the above files to meet shfmt's requirements by typing:
shfmt -w filename
clang-tidy review says "All clean, LGTM! :+1:"
clang-tidy review says "All clean, LGTM! :+1:"
clang-tidy review says "All clean, LGTM! :+1:"
clang-tidy review says "All clean, LGTM! :+1:"
clang-tidy review says "All clean, LGTM! :+1:"
run buildall
TeamCity be ut coverage result: Function Coverage: 35.69% (8983/25173) Line Coverage: 27.35% (74211/271372) Region Coverage: 26.59% (38362/144248) Branch Coverage: 23.40% (19567/83604) Coverage Report: http://coverage.selectdb-in.cc/coverage/992062071f23a9da166d52ced07aee5a14f60190_992062071f23a9da166d52ced07aee5a14f60190/report/index.html
run buildall
clang-tidy review says "All clean, LGTM! :+1:"
clang-tidy review says "All clean, LGTM! :+1:"
TeamCity be ut coverage result: Function Coverage: 35.65% (8986/25206) Line Coverage: 27.32% (74275/271909) Region Coverage: 26.55% (38392/144592) Branch Coverage: 23.37% (19576/83776) Coverage Report: http://coverage.selectdb-in.cc/coverage/49a3a9082cb6ae5bf5d066cf945ee3ebb0f5f575_49a3a9082cb6ae5bf5d066cf945ee3ebb0f5f575/report/index.html
clang-tidy review says "All clean, LGTM! :+1:"
clang-tidy review says "All clean, LGTM! :+1:"
clang-tidy review says "All clean, LGTM! :+1:"
run buildall
TeamCity be ut coverage result: Function Coverage: 35.70% (8997/25204) Line Coverage: 27.37% (74457/271994) Region Coverage: 26.61% (38491/144633) Branch Coverage: 23.43% (19635/83814) Coverage Report: http://coverage.selectdb-in.cc/coverage/e316fb353da5c99282ce5e910ab02d5457b6eb17_e316fb353da5c99282ce5e910ab02d5457b6eb17/report/index.html
clang-tidy review says "All clean, LGTM! :+1:"
clang-tidy review says "All clean, LGTM! :+1:"
clang-tidy review says "All clean, LGTM! :+1:"
clang-tidy review says "All clean, LGTM! :+1:"
run buildall
clang-tidy review says "All clean, LGTM! :+1:"
TeamCity be ut coverage result: Function Coverage: 35.69% (9003/25224) Line Coverage: 27.36% (74475/272188) Region Coverage: 26.60% (38491/144724) Branch Coverage: 23.42% (19636/83846) Coverage Report: http://coverage.selectdb-in.cc/coverage/5f5f921ebb3e6f78a1d96bf7deb1322277d258da_5f5f921ebb3e6f78a1d96bf7deb1322277d258da/report/index.html