doris
doris copied to clipboard
Published
20 hours ago •
apache
apache
[Fix](fe-common) Fix the Pair.java code about the hidden danger of NullPointException
Proposed changes
Issue Number: close #31370
add code in toString method and equals method of Pair.java to avoid the null point exception situation
Further comments
If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...
Thank you for your contribution to Apache Doris. Don't know what should be done next? See How to process your PR
PR approved by at least one committer and no changes requested.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
TPC-H: Total hot run time: 40692 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit cbe5da3b3a067c19e6d4471aea8b7c4c33239ad6, data reload: false
------ Round 1 ----------------------------------
q1 17629 4926 4877 4877
q2 2053 136 131 131
q3 10584 983 977 977
q4 4650 949 958 949
q5 7612 3087 3167 3087
q6 187 136 130 130
q7 1254 770 764 764
q8 9235 2042 2018 2018
q9 7458 6560 6534 6534
q10 8298 2649 2636 2636
q11 420 216 207 207
q12 766 341 328 328
q13 17930 3634 3593 3593
q14 296 252 258 252
q15 622 511 492 492
q16 460 405 401 401
q17 917 796 711 711
q18 7455 6671 6807 6671
q19 1544 1484 1495 1484
q20 547 265 259 259
q21 6338 3865 3929 3865
q22 856 338 326 326
Total cold run time: 107111 ms
Total hot run time: 40692 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4835 4835 4875 4835
q2 293 177 180 177
q3 3598 3568 3581 3568
q4 2524 2521 2499 2499
q5 5744 5729 5736 5729
q6 215 126 125 125
q7 2240 1634 1633 1633
q8 3031 3090 3087 3087
q9 8687 8656 8736 8656
q10 6756 4224 4236 4224
q11 506 356 369 356
q12 765 536 525 525
q13 5000 3369 3409 3369
q14 253 242 222 222
q15 590 508 502 502
q16 476 469 448 448
q17 1619 1600 1594 1594
q18 8290 7637 7595 7595
q19 1623 1633 1621 1621
q20 2102 1818 1824 1818
q21 6500 6130 6104 6104
q22 562 492 504 492
Total cold run time: 66209 ms
Total hot run time: 59179 ms
TPC-DS: Total hot run time: 176253 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit cbe5da3b3a067c19e6d4471aea8b7c4c33239ad6, data reload: false
query1 923 346 340 340
query2 6536 1780 1760 1760
query3 6699 209 203 203
query4 22944 21047 21092 21047
query5 4254 371 371 371
query6 272 184 165 165
query7 4603 296 293 293
query8 244 202 214 202
query9 8431 2749 2726 2726
query10 415 227 224 224
query11 15058 14466 14454 14454
query12 137 82 82 82
query13 1690 413 414 413
query14 9120 7542 7501 7501
query15 215 184 189 184
query16 7657 248 259 248
query17 1408 546 522 522
query18 1940 267 263 263
query19 196 142 143 142
query20 84 81 80 80
query21 181 118 121 118
query22 5055 4747 4760 4747
query23 32405 31457 31564 31457
query24 12745 3453 3384 3384
query25 646 362 359 359
query26 1893 149 156 149
query27 3062 312 320 312
query28 6564 1832 1806 1806
query29 1144 618 608 608
query30 274 133 149 133
query31 965 763 751 751
query32 97 58 53 53
query33 718 235 216 216
query34 1078 478 502 478
query35 948 828 817 817
query36 1012 864 899 864
query37 176 64 62 62
query38 3278 3121 3195 3121
query39 1381 1303 1310 1303
query40 289 105 106 105
query41 38 36 36 36
query42 106 96 102 96
query43 465 455 446 446
query44 1070 683 696 683
query45 196 175 176 175
query46 1034 752 761 752
query47 1656 1613 1589 1589
query48 416 341 349 341
query49 1216 304 305 304
query50 767 373 369 369
query51 4401 4355 4297 4297
query52 106 91 97 91
query53 388 304 305 304
query54 289 222 226 222
query55 84 79 83 79
query56 219 203 215 203
query57 1028 951 933 933
query58 209 191 193 191
query59 2254 2186 2235 2186
query60 238 215 206 206
query61 87 83 88 83
query62 597 380 367 367
query63 318 278 281 278
query64 6247 3082 3087 3082
query65 3251 3270 3256 3256
query66 1359 331 317 317
query67 14473 14444 14334 14334
query68 5163 551 546 546
query69 501 351 354 351
query70 1212 1236 1252 1236
query71 432 248 244 244
query72 6373 2762 2610 2610
query73 685 308 308 308
query74 6872 6452 6423 6423
query75 3203 2596 2547 2547
query76 3321 1110 1195 1110
query77 356 237 236 236
query78 9472 8753 8753 8753
query79 957 499 513 499
query80 506 348 332 332
query81 435 205 201 201
query82 169 85 85 85
query83 144 122 117 117
query84 232 78 78 78
query85 1026 342 331 331
query86 294 314 299 299
query87 3450 3290 3286 3286
query88 2682 2304 2290 2290
query89 434 367 358 358
query90 1924 168 162 162
query91 150 127 124 124
query92 54 48 53 48
query93 1002 505 505 505
query94 1130 179 179 179
query95 431 335 343 335
query96 569 265 267 265
query97 4415 4247 4251 4247
query98 220 207 194 194
query99 1085 671 749 671
Total cold run time: 268148 ms
Total hot run time: 176253 ms
ClickBench: Total hot run time: 30.85 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit cbe5da3b3a067c19e6d4471aea8b7c4c33239ad6, data reload: false
query1 0.02 0.02 0.02
query2 0.07 0.02 0.02
query3 0.23 0.07 0.07
query4 1.66 0.06 0.09
query5 0.48 0.49 0.49
query6 1.39 0.62 0.63
query7 0.02 0.01 0.01
query8 0.03 0.03 0.02
query9 0.51 0.46 0.44
query10 0.48 0.48 0.50
query11 0.13 0.09 0.09
query12 0.12 0.10 0.11
query13 0.58 0.59 0.59
query14 0.75 0.79 0.78
query15 0.82 0.79 0.78
query16 0.35 0.34 0.33
query17 0.90 0.90 0.90
query18 0.17 0.15 0.17
query19 1.76 1.61 1.65
query20 0.01 0.01 0.01
query21 15.40 0.62 0.58
query22 2.97 3.51 2.63
query23 17.35 0.92 0.99
query24 1.99 0.58 0.21
query25 0.64 0.06 0.06
query26 0.17 0.13 0.13
query27 0.05 0.04 0.04
query28 12.24 0.81 0.82
query29 12.57 3.27 3.26
query30 0.55 0.49 0.51
query31 2.78 0.37 0.36
query32 3.34 0.48 0.47
query33 3.14 3.14 3.09
query34 15.37 4.55 4.53
query35 4.52 4.49 4.51
query36 1.07 0.93 0.96
query37 0.07 0.05 0.05
query38 0.04 0.03 0.03
query39 0.02 0.02 0.02
query40 0.18 0.14 0.14
query41 0.08 0.01 0.02
query42 0.02 0.01 0.01
query43 0.03 0.02 0.02
Total cold run time: 105.07 s
Total hot run time: 30.85 s
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
Load test result on commit cbe5da3b3a067c19e6d4471aea8b7c4c33239ad6 with default session variables
Stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc: 60 seconds loaded 1101869774 Bytes, about 17 MB/s
Stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
Insert into select: 16.8 seconds inserted 10000000 Rows, about 595K ops/s