doris icon indicating copy to clipboard operation
doris copied to clipboard

[fix](datetime) fix hour 24 on be

Open zhiqiang-hhhh opened this issue 1 year ago • 26 comments

zhiqiang-hhhh avatar Feb 23 '24 03:02 zhiqiang-hhhh

Thank you for your contribution to Apache Doris. Don't know what should be done next? See How to process your PR

doris-robot avatar Feb 23 '24 03:02 doris-robot

sh-checker report

To get the full details, please check in the job output.

shellcheck errors

'shellcheck ' returned error 1 finding the following syntactical issues:

----------

In build.sh line 598:
    NPM='npm'
    ^-------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In build.sh line 599:
    if ! ${NPM} --version; then
    ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
         ^--------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In build.sh line 600:
        echo "Error: npm is not found"
        ^----------------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In build.sh line 601:
        exit 1
        ^----^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In build.sh line 603:
    if [[ -n "${CUSTOM_NPM_REGISTRY}" ]]; then
    ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
       ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In build.sh line 604:
        "${NPM}" config set registry "${CUSTOM_NPM_REGISTRY}"
        ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In build.sh line 605:
        npm_reg="$("${NPM}" get registry)"
        ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
                   ^-------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In build.sh line 606:
        echo "NPM registry: ${npm_reg}"
        ^-----------------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In build.sh line 609:
    echo "Build Frontend UI"
    ^----------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In build.sh line 610:
    ui_dist="${DORIS_HOME}/ui/dist"
    ^-----------------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In build.sh line 611:
    if [[ -n "${CUSTOM_UI_DIST}" ]]; then
    ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
       ^--------------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In build.sh line 612:
        ui_dist="${CUSTOM_UI_DIST}"
        ^-------------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In build.sh line 614:
        cd "${DORIS_HOME}/ui"
        ^-------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In build.sh line 615:
        "${NPM}" cache clean --force
        ^--------------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In build.sh line 616:
        "${NPM}" install --legacy-peer-deps
        ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In build.sh line 617:
        "${NPM}" run build
        ^----------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In build.sh line 619:
    echo "ui dist: ${ui_dist}"
    ^------------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In build.sh line 620:
    rm -rf "${DORIS_HOME}/fe/fe-core/src/main/resources/static"
    ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In build.sh line 621:
    mkdir -p "${DORIS_HOME}/fe/fe-core/src/main/resources/static"
    ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In build.sh line 622:
    cp -r "${ui_dist}"/* "${DORIS_HOME}/fe/fe-core/src/main/resources/static"/
    ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).

For more information:
  https://www.shellcheck.net/wiki/SC2317 -- Command appears to be unreachable...
----------

You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
  # shellcheck disable=NNNN
above the line that contains the issue, where NNNN is the error code;
3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.



shfmt errors

'shfmt ' returned error 1 finding the following formatting issues:

----------
--- build.sh.orig
+++ build.sh
@@ -543,9 +543,9 @@
         -DDORIS_JAVA_HOME="${JAVA_HOME}" \
         "${DORIS_HOME}/be"
 
-        "${BUILD_SYSTEM}" -j "${PARALLEL}"    
-        # 不要 install,这样确保 workspace 的 debug 跟 release 可以使用软连接到不同的二进制
-        # "${BUILD_SYSTEM}" install
+    "${BUILD_SYSTEM}" -j "${PARALLEL}"
+    # 不要 install,这样确保 workspace 的 debug 跟 release 可以使用软连接到不同的二进制
+    # "${BUILD_SYSTEM}" install
 
     cd "${DORIS_HOME}"
 fi
----------

You can reformat the above files to meet shfmt's requirements by typing:

  shfmt  -w filename


github-actions[bot] avatar Feb 23 '24 03:02 github-actions[bot]

run buildall

zhiqiang-hhhh avatar Feb 23 '24 03:02 zhiqiang-hhhh

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Feb 23 '24 03:02 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Feb 23 '24 03:02 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Feb 23 '24 03:02 github-actions[bot]

run buildall

zhiqiang-hhhh avatar Feb 23 '24 03:02 zhiqiang-hhhh

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Feb 23 '24 03:02 github-actions[bot]

TeamCity be ut coverage result: Function Coverage: 35.71% (8548/23936) Line Coverage: 27.54% (69377/251944) Region Coverage: 26.69% (35984/134833) Branch Coverage: 23.49% (18392/78296) Coverage Report: http://coverage.selectdb-in.cc/coverage/db8d7e1d8c989621a00562d073c938eede4a71c5_db8d7e1d8c989621a00562d073c938eede4a71c5/report/index.html

doris-robot avatar Feb 23 '24 04:02 doris-robot

PR approved by anyone and no changes requested.

github-actions[bot] avatar Feb 23 '24 04:02 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Feb 23 '24 05:02 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Feb 23 '24 11:02 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Feb 23 '24 11:02 github-actions[bot]

PR approved by at least one committer and no changes requested.

github-actions[bot] avatar Feb 23 '24 11:02 github-actions[bot]

run buildall

zhiqiang-hhhh avatar Feb 23 '24 11:02 zhiqiang-hhhh

run buildall

zhiqiang-hhhh avatar Feb 23 '24 11:02 zhiqiang-hhhh

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Feb 23 '24 11:02 github-actions[bot]

TeamCity be ut coverage result: Function Coverage: 35.71% (8547/23935) Line Coverage: 27.54% (69370/251901) Region Coverage: 26.69% (35981/134795) Branch Coverage: 23.50% (18391/78272) Coverage Report: http://coverage.selectdb-in.cc/coverage/c8fb0ede6d7b215f15b188eab91e852502b82a03_c8fb0ede6d7b215f15b188eab91e852502b82a03/report/index.html

doris-robot avatar Feb 23 '24 11:02 doris-robot

run buildall

zhiqiang-hhhh avatar Feb 23 '24 12:02 zhiqiang-hhhh

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Feb 23 '24 12:02 github-actions[bot]

TPC-H: Total hot run time: 41377 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 4ffd8a1c23aeb9b0f7f9ed7eea79995b328b4625, data reload: false

------ Round 1 ----------------------------------
q1	17622	5045	4896	4896
q2	2052	141	133	133
q3	6613	1027	1033	1027
q4	4397	988	982	982
q5	7645	3210	3211	3210
q6	201	138	137	137
q7	1254	782	766	766
q8	9379	2088	2063	2063
q9	7652	6598	6623	6598
q10	8374	2663	2652	2652
q11	414	212	210	210
q12	769	326	335	326
q13	17731	3637	3648	3637
q14	289	259	259	259
q15	588	513	509	509
q16	509	409	421	409
q17	929	872	856	856
q18	7459	6705	6682	6682
q19	1548	1487	1494	1487
q20	477	282	277	277
q21	5875	3923	3977	3923
q22	428	341	338	338
Total cold run time: 102205 ms
Total hot run time: 41377 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5076	4873	4843	4843
q2	295	182	190	182
q3	3630	3610	3603	3603
q4	2538	2571	2544	2544
q5	5789	5788	5790	5788
q6	213	124	134	124
q7	2260	1669	1640	1640
q8	3044	3112	3147	3112
q9	8771	8785	8784	8784
q10	4150	4222	4260	4222
q11	523	366	387	366
q12	780	553	562	553
q13	4249	3439	3384	3384
q14	264	238	229	229
q15	593	505	495	495
q16	488	448	450	448
q17	1702	1614	1654	1614
q18	8349	7534	7619	7534
q19	1640	1644	1637	1637
q20	2113	1852	1840	1840
q21	6594	6238	6189	6189
q22	562	532	535	532
Total cold run time: 63623 ms
Total hot run time: 59663 ms

doris-robot avatar Feb 23 '24 13:02 doris-robot

TPC-DS: Total hot run time: 177057 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 4ffd8a1c23aeb9b0f7f9ed7eea79995b328b4625, data reload: false

query1	926	351	356	351
query2	6504	1900	1821	1821
query3	6699	208	201	201
query4	23301	21188	21159	21159
query5	4293	378	379	378
query6	254	170	167	167
query7	4616	296	292	292
query8	251	199	194	194
query9	8443	2811	2803	2803
query10	411	219	223	219
query11	15117	14609	14512	14512
query12	139	82	81	81
query13	1690	403	413	403
query14	9070	7775	7789	7775
query15	213	189	194	189
query16	7395	256	251	251
query17	1409	549	541	541
query18	1956	283	272	272
query19	203	148	147	147
query20	92	85	85	85
query21	185	125	129	125
query22	4973	4814	4782	4782
query23	32475	31462	31373	31373
query24	12714	3394	3382	3382
query25	650	361	357	357
query26	1889	153	165	153
query27	3051	322	312	312
query28	6736	1833	1826	1826
query29	1168	610	618	610
query30	286	142	148	142
query31	933	751	778	751
query32	100	57	58	57
query33	720	229	237	229
query34	1072	494	492	492
query35	948	817	821	817
query36	1012	888	880	880
query37	181	60	62	60
query38	3297	3171	3250	3171
query39	1372	1329	1313	1313
query40	287	105	113	105
query41	36	36	35	35
query42	106	100	104	100
query43	491	481	460	460
query44	1077	688	699	688
query45	196	181	177	177
query46	1053	786	743	743
query47	1667	1532	1541	1532
query48	420	355	352	352
query49	1212	308	303	303
query50	769	362	380	362
query51	4401	4290	4326	4290
query52	113	94	97	94
query53	404	296	307	296
query54	296	213	228	213
query55	84	79	91	79
query56	222	215	202	202
query57	1092	964	913	913
query58	218	203	204	203
query59	2279	2234	2263	2234
query60	246	210	220	210
query61	85	85	82	82
query62	603	389	386	386
query63	341	305	298	298
query64	6491	3038	3107	3038
query65	3285	3237	3270	3237
query66	1341	334	323	323
query67	14688	14242	14356	14242
query68	5011	571	551	551
query69	518	372	351	351
query70	1294	1282	1198	1198
query71	387	262	258	258
query72	6407	2783	2596	2596
query73	702	310	326	310
query74	6863	6556	6498	6498
query75	3207	2580	2562	2562
query76	3258	1100	1198	1100
query77	359	245	247	245
query78	9423	8825	8779	8779
query79	971	512	507	507
query80	516	353	348	348
query81	434	203	205	203
query82	162	85	91	85
query83	140	130	124	124
query84	223	78	78	78
query85	1033	352	345	345
query86	295	315	306	306
query87	3483	3411	3295	3295
query88	2685	2285	2291	2285
query89	442	367	364	364
query90	1927	168	161	161
query91	150	127	125	125
query92	56	52	48	48
query93	1001	528	508	508
query94	1111	184	176	176
query95	430	344	331	331
query96	571	264	263	263
query97	4465	4323	4255	4255
query98	217	211	198	198
query99	1067	751	734	734
Total cold run time: 269055 ms
Total hot run time: 177057 ms

doris-robot avatar Feb 23 '24 13:02 doris-robot

ClickBench: Total hot run time: 31.1 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 4ffd8a1c23aeb9b0f7f9ed7eea79995b328b4625, data reload: false

query1	0.04	0.03	0.02
query2	0.06	0.02	0.02
query3	0.23	0.07	0.08
query4	1.65	0.10	0.08
query5	0.50	0.48	0.49
query6	1.33	0.60	0.61
query7	0.01	0.01	0.01
query8	0.04	0.03	0.03
query9	0.54	0.45	0.45
query10	0.50	0.48	0.49
query11	0.13	0.10	0.09
query12	0.12	0.10	0.10
query13	0.60	0.58	0.60
query14	0.74	0.80	0.79
query15	0.82	0.80	0.79
query16	0.33	0.33	0.33
query17	0.89	0.91	0.90
query18	0.17	0.17	0.16
query19	1.77	1.64	1.72
query20	0.01	0.01	0.02
query21	15.44	0.62	0.59
query22	2.87	4.12	2.68
query23	17.53	1.10	0.99
query24	1.99	0.38	0.19
query25	0.64	0.05	0.05
query26	0.15	0.13	0.14
query27	0.07	0.05	0.04
query28	12.42	0.84	0.82
query29	12.55	3.38	3.33
query30	0.53	0.49	0.49
query31	2.77	0.36	0.36
query32	3.37	0.47	0.48
query33	3.15	3.14	3.16
query34	15.36	4.51	4.50
query35	4.49	4.46	4.48
query36	1.08	0.95	0.97
query37	0.07	0.05	0.05
query38	0.04	0.03	0.03
query39	0.02	0.02	0.01
query40	0.17	0.14	0.14
query41	0.07	0.02	0.02
query42	0.02	0.02	0.01
query43	0.03	0.02	0.02
Total cold run time: 105.31 s
Total hot run time: 31.1 s

doris-robot avatar Feb 23 '24 13:02 doris-robot

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit 4ffd8a1c23aeb9b0f7f9ed7eea79995b328b4625 with default session variables
Stream load json:         20 seconds loaded 2358488459 Bytes, about 112 MB/s
Stream load orc:          60 seconds loaded 1101869774 Bytes, about 17 MB/s
Stream load parquet:      32 seconds loaded 861443392 Bytes, about 25 MB/s
Insert into select:       14.0 seconds inserted 10000000 Rows, about 714K ops/s

doris-robot avatar Feb 23 '24 13:02 doris-robot

TeamCity be ut coverage result: Function Coverage: 35.70% (8546/23937) Line Coverage: 27.52% (69348/251995) Region Coverage: 26.68% (35973/134838) Branch Coverage: 23.49% (18390/78296) Coverage Report: http://coverage.selectdb-in.cc/coverage/4ffd8a1c23aeb9b0f7f9ed7eea79995b328b4625_4ffd8a1c23aeb9b0f7f9ed7eea79995b328b4625/report/index.html

doris-robot avatar Feb 23 '24 13:02 doris-robot

PR approved by at least one committer and no changes requested.

github-actions[bot] avatar Feb 24 '24 13:02 github-actions[bot]