doris icon indicating copy to clipboard operation
doris copied to clipboard

Published 20 hours ago • verified publisher icon apache

[refactor-wip](FS) Use golang-like generator to replace FS's list interface

Open ByteYue opened this issue 1 year ago • 19 comments

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

ByteYue avatar Feb 21 '24 08:02 ByteYue

Thank you for your contribution to Apache Doris. Don't know what should be done next? See How to process your PR

doris-robot avatar Feb 21 '24 08:02 doris-robot

Any benifits for this refactor?

yiguolei avatar Feb 21 '24 09:02 yiguolei

run buildall

ByteYue avatar Feb 21 '24 12:02 ByteYue

run buildall

ByteYue avatar Feb 21 '24 13:02 ByteYue

TeamCity be ut coverage result: Function Coverage: 35.72% (8565/23978) Line Coverage: 27.60% (69499/251765) Region Coverage: 26.73% (36062/134893) Branch Coverage: 23.54% (18437/78306) Coverage Report: http://coverage.selectdb-in.cc/coverage/0d1e41eab442f30b77c8d523881264a3b70348e8_0d1e41eab442f30b77c8d523881264a3b70348e8/report/index.html

doris-robot avatar Feb 21 '24 13:02 doris-robot

run buildall

ByteYue avatar Feb 22 '24 10:02 ByteYue

TeamCity be ut coverage result: Function Coverage: 35.74% (8553/23928) Line Coverage: 27.55% (69379/251858) Region Coverage: 26.70% (36000/134823) Branch Coverage: 23.50% (18398/78276) Coverage Report: http://coverage.selectdb-in.cc/coverage/5a9eef7e0dc87718b1ebd2d6fa872715c1064bd3_5a9eef7e0dc87718b1ebd2d6fa872715c1064bd3/report/index.html

doris-robot avatar Feb 22 '24 11:02 doris-robot

run buildall

ByteYue avatar Feb 22 '24 14:02 ByteYue

TeamCity be ut coverage result: Function Coverage: 35.71% (8552/23951) Line Coverage: 27.52% (69371/252107) Region Coverage: 26.66% (35984/134949) Branch Coverage: 23.47% (18391/78344) Coverage Report: http://coverage.selectdb-in.cc/coverage/b6eaa503e79e8c47de3258dc0676da57db526b8f_b6eaa503e79e8c47de3258dc0676da57db526b8f/report/index.html

doris-robot avatar Feb 22 '24 15:02 doris-robot

run buildall

ByteYue avatar Feb 23 '24 07:02 ByteYue

TeamCity be ut coverage result: Function Coverage: 35.71% (8555/23955) Line Coverage: 27.53% (69397/252089) Region Coverage: 26.68% (35999/134923) Branch Coverage: 23.49% (18395/78324) Coverage Report: http://coverage.selectdb-in.cc/coverage/08dbd691e6a9389429c3759515c8eed6d8590221_08dbd691e6a9389429c3759515c8eed6d8590221/report/index.html

doris-robot avatar Feb 23 '24 08:02 doris-robot

run buildall

ByteYue avatar Feb 24 '24 11:02 ByteYue

run buildall

ByteYue avatar Feb 24 '24 11:02 ByteYue

run buildall

ByteYue avatar Feb 24 '24 12:02 ByteYue

run buildall

ByteYue avatar Feb 24 '24 12:02 ByteYue

run buildall

ByteYue avatar Feb 24 '24 12:02 ByteYue

run buildall

ByteYue avatar Feb 25 '24 06:02 ByteYue

run buildall

ByteYue avatar Feb 25 '24 06:02 ByteYue

TeamCity be ut coverage result: Function Coverage: 35.72% (8558/23959) Line Coverage: 27.53% (69413/252181) Region Coverage: 26.69% (36053/135069) Branch Coverage: 23.49% (18426/78440) Coverage Report: http://coverage.selectdb-in.cc/coverage/6411777afb6ddccf33947fb6d0dea1f1068353e3_6411777afb6ddccf33947fb6d0dea1f1068353e3/report/index.html

doris-robot avatar Feb 25 '24 06:02 doris-robot

run p0

hello-stephen avatar Feb 26 '24 03:02 hello-stephen

run buildall

ByteYue avatar Feb 26 '24 08:02 ByteYue

TeamCity be ut coverage result: Function Coverage: 35.74% (8559/23945) Line Coverage: 27.53% (69402/252121) Region Coverage: 26.68% (36039/135066) Branch Coverage: 23.48% (18416/78446) Coverage Report: http://coverage.selectdb-in.cc/coverage/6411777afb6ddccf33947fb6d0dea1f1068353e3_6411777afb6ddccf33947fb6d0dea1f1068353e3/report/index.html

doris-robot avatar Feb 26 '24 09:02 doris-robot