doris icon indicating copy to clipboard operation
doris copied to clipboard

[Feature](agg-state) support write_column_to_pb from DataTypeFixedLengthObjectSerDe

Open BiteTheDDDDt opened this issue 1 year ago • 18 comments

Proposed changes

support write_column_to_pb from DataTypeFixedLengthObjectSerDe

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

BiteTheDDDDt avatar Feb 20 '24 12:02 BiteTheDDDDt

Thank you for your contribution to Apache Doris. Don't know what should be done next? See How to process your PR

doris-robot avatar Feb 20 '24 12:02 doris-robot

run buildall

BiteTheDDDDt avatar Feb 20 '24 12:02 BiteTheDDDDt

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Feb 20 '24 12:02 github-actions[bot]

TeamCity be ut coverage result: Function Coverage: 35.77% (8558/23927) Line Coverage: 27.71% (69406/250431) Region Coverage: 26.83% (36010/134228) Branch Coverage: 23.64% (18420/77910) Coverage Report: http://coverage.selectdb-in.cc/coverage/cf9aab292c9581a6abba73f0d1410aa0c1ef2436_cf9aab292c9581a6abba73f0d1410aa0c1ef2436/report/index.html

doris-robot avatar Feb 20 '24 12:02 doris-robot

TPC-H: Total hot run time: 41939 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit cf9aab292c9581a6abba73f0d1410aa0c1ef2436, data reload: false

------ Round 1 ----------------------------------
q1	18157	5288	5201	5201
q2	3022	144	139	139
q3	11251	1071	1044	1044
q4	5299	1032	1032	1032
q5	8109	3407	3269	3269
q6	200	132	128	128
q7	1268	798	777	777
q8	9387	2099	2086	2086
q9	7585	6688	6689	6688
q10	8315	2650	2643	2643
q11	421	222	212	212
q12	756	330	333	330
q13	17995	3628	3677	3628
q14	294	253	258	253
q15	593	512	512	512
q16	472	402	421	402
q17	923	839	840	839
q18	7387	6818	6592	6592
q19	1580	1503	1500	1500
q20	569	347	329	329
q21	6073	4017	3991	3991
q22	726	348	344	344
Total cold run time: 110382 ms
Total hot run time: 41939 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4867	4879	4850	4850
q2	296	183	182	182
q3	3615	3594	3588	3588
q4	2538	2539	2549	2539
q5	5762	5782	5771	5771
q6	213	129	128	128
q7	2241	1628	1653	1628
q8	3039	3081	3118	3081
q9	8735	8728	8722	8722
q10	5691	4262	4231	4231
q11	510	367	367	367
q12	760	535	545	535
q13	4186	3405	3401	3401
q14	279	245	240	240
q15	595	506	505	505
q16	474	430	427	427
q17	1700	1628	1623	1623
q18	8369	7726	7716	7716
q19	1642	1646	1624	1624
q20	2119	1837	1807	1807
q21	6591	6199	6188	6188
q22	570	510	516	510
Total cold run time: 64792 ms
Total hot run time: 59663 ms

doris-robot avatar Feb 20 '24 12:02 doris-robot

TPC-DS: Total hot run time: 177428 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit cf9aab292c9581a6abba73f0d1410aa0c1ef2436, data reload: false

query1	910	351	341	341
query2	6517	1741	1870	1741
query3	6697	208	203	203
query4	23246	21095	21141	21095
query5	4266	370	365	365
query6	265	162	171	162
query7	4608	289	287	287
query8	246	195	200	195
query9	8424	2806	2800	2800
query10	411	217	221	217
query11	15089	14612	14378	14378
query12	138	88	86	86
query13	1710	431	409	409
query14	9042	7556	7561	7556
query15	213	178	191	178
query16	7291	252	255	252
query17	1419	548	530	530
query18	1967	269	261	261
query19	191	145	146	145
query20	86	81	91	81
query21	192	126	117	117
query22	4805	4891	4855	4855
query23	32490	31486	31574	31486
query24	12701	3385	3364	3364
query25	651	369	355	355
query26	1861	157	158	157
query27	3052	311	311	311
query28	6671	1851	1853	1851
query29	1173	605	604	604
query30	283	136	142	136
query31	961	743	769	743
query32	97	60	55	55
query33	717	233	240	233
query34	1093	486	497	486
query35	946	837	839	837
query36	983	954	874	874
query37	152	58	63	58
query38	3315	3186	3196	3186
query39	1375	1314	1319	1314
query40	289	107	104	104
query41	39	36	36	36
query42	113	97	101	97
query43	486	459	460	459
query44	1060	693	700	693
query45	197	181	177	177
query46	1043	780	726	726
query47	1704	1541	1620	1541
query48	405	340	345	340
query49	1221	306	297	297
query50	770	371	377	371
query51	5326	5231	5173	5173
query52	108	92	91	91
query53	386	304	288	288
query54	290	213	223	213
query55	83	80	78	78
query56	227	193	206	193
query57	1062	920	992	920
query58	224	197	197	197
query59	2462	2224	2398	2224
query60	251	213	217	213
query61	83	85	90	85
query62	598	375	383	375
query63	332	284	279	279
query64	6461	3063	3105	3063
query65	3278	3260	3253	3253
query66	1365	331	316	316
query67	14760	14487	14291	14291
query68	5198	540	559	540
query69	522	353	355	353
query70	1287	1239	1171	1171
query71	381	249	257	249
query72	6390	2769	2626	2626
query73	704	311	311	311
query74	6924	6384	6466	6384
query75	3217	2573	2539	2539
query76	3057	1153	1174	1153
query77	355	238	233	233
query78	9561	8833	8823	8823
query79	965	510	502	502
query80	513	342	361	342
query81	440	199	207	199
query82	161	88	83	83
query83	147	119	122	119
query84	224	81	77	77
query85	1028	349	332	332
query86	291	314	303	303
query87	3440	3359	3249	3249
query88	2681	2281	2255	2255
query89	440	342	342	342
query90	1966	166	163	163
query91	157	129	131	129
query92	51	49	47	47
query93	976	486	475	475
query94	1137	187	184	184
query95	484	378	359	359
query96	569	264	259	259
query97	4491	4306	4275	4275
query98	224	212	198	198
query99	1072	757	781	757
Total cold run time: 269930 ms
Total hot run time: 177428 ms

doris-robot avatar Feb 20 '24 12:02 doris-robot

ClickBench: Total hot run time: 31.17 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit cf9aab292c9581a6abba73f0d1410aa0c1ef2436, data reload: false

query1	0.03	0.02	0.02
query2	0.07	0.02	0.02
query3	0.22	0.07	0.07
query4	1.64	0.08	0.08
query5	0.50	0.49	0.48
query6	1.38	0.61	0.62
query7	0.02	0.02	0.01
query8	0.05	0.03	0.03
query9	0.52	0.44	0.45
query10	0.50	0.50	0.48
query11	0.12	0.10	0.09
query12	0.12	0.10	0.10
query13	0.59	0.60	0.59
query14	0.76	0.79	0.80
query15	0.82	0.79	0.80
query16	0.35	0.32	0.33
query17	0.89	0.89	0.93
query18	0.18	0.18	0.20
query19	1.76	1.65	1.69
query20	0.02	0.01	0.01
query21	15.78	0.67	0.61
query22	3.23	4.42	2.79
query23	17.34	1.08	0.95
query24	2.16	0.59	0.12
query25	0.50	0.07	0.05
query26	0.16	0.15	0.15
query27	0.05	0.04	0.05
query28	12.09	0.85	0.84
query29	12.62	3.34	3.37
query30	0.54	0.50	0.49
query31	2.78	0.36	0.38
query32	3.31	0.48	0.47
query33	3.14	3.12	3.20
query34	15.39	4.47	4.48
query35	4.53	4.51	4.50
query36	1.08	0.95	0.94
query37	0.08	0.05	0.05
query38	0.04	0.03	0.03
query39	0.03	0.02	0.02
query40	0.17	0.15	0.14
query41	0.07	0.02	0.01
query42	0.03	0.02	0.01
query43	0.03	0.02	0.02
Total cold run time: 105.69 s
Total hot run time: 31.17 s

doris-robot avatar Feb 20 '24 13:02 doris-robot

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit cf9aab292c9581a6abba73f0d1410aa0c1ef2436 with default session variables
Stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc:          60 seconds loaded 1101869774 Bytes, about 17 MB/s
Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select:       13.7 seconds inserted 10000000 Rows, about 729K ops/s

doris-robot avatar Feb 20 '24 13:02 doris-robot

run buildall

BiteTheDDDDt avatar Feb 21 '24 04:02 BiteTheDDDDt

TPC-H: Total hot run time: 41933 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 702bab382bbe165696202eca6795d03c222e5bb6, data reload: false

------ Round 1 ----------------------------------
q1	17636	5083	4944	4944
q2	2042	145	138	138
q3	10673	1057	1031	1031
q4	4693	996	1001	996
q5	7726	3280	3302	3280
q6	195	140	136	136
q7	1257	793	777	777
q8	9332	2115	2090	2090
q9	8143	6763	6733	6733
q10	8322	2630	2655	2630
q11	410	222	225	222
q12	742	336	335	335
q13	18000	3700	3697	3697
q14	297	266	262	262
q15	578	509	521	509
q16	482	408	417	408
q17	942	848	845	845
q18	7308	6702	6702	6702
q19	1577	1515	1500	1500
q20	649	388	364	364
q21	6249	3987	4021	3987
q22	882	347	349	347
Total cold run time: 108135 ms
Total hot run time: 41933 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4885	4855	4869	4855
q2	299	189	192	189
q3	3615	3629	3599	3599
q4	2533	2545	2520	2520
q5	5788	5792	5781	5781
q6	211	130	128	128
q7	2251	1639	1661	1639
q8	3026	3097	3097	3097
q9	8769	8753	8741	8741
q10	6865	4249	4245	4245
q11	555	398	417	398
q12	783	554	542	542
q13	4338	3424	3441	3424
q14	268	240	228	228
q15	622	513	522	513
q16	491	432	449	432
q17	1722	1645	1625	1625
q18	8495	7626	7668	7626
q19	1646	1652	1641	1641
q20	2135	1871	1841	1841
q21	6688	6295	6296	6295
q22	572	515	514	514
Total cold run time: 66557 ms
Total hot run time: 59873 ms

doris-robot avatar Feb 21 '24 05:02 doris-robot

TeamCity be ut coverage result: Function Coverage: 35.74% (8561/23952) Line Coverage: 27.60% (69424/251515) Region Coverage: 26.74% (36029/134745) Branch Coverage: 23.55% (18428/78242) Coverage Report: http://coverage.selectdb-in.cc/coverage/702bab382bbe165696202eca6795d03c222e5bb6_702bab382bbe165696202eca6795d03c222e5bb6/report/index.html

doris-robot avatar Feb 21 '24 06:02 doris-robot

run buildall

BiteTheDDDDt avatar Feb 21 '24 07:02 BiteTheDDDDt

TPC-H: Total hot run time: 41555 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 635c81742ec06b2ddac86c9fb20509950cdc626b, data reload: false

------ Round 1 ----------------------------------
q1	17710	4967	4884	4884
q2	2055	141	140	140
q3	10570	1007	1007	1007
q4	4652	962	988	962
q5	7656	3257	3294	3257
q6	192	135	135	135
q7	1263	782	776	776
q8	9237	2105	2092	2092
q9	7628	6715	6679	6679
q10	8311	2642	2629	2629
q11	419	223	202	202
q12	739	329	325	325
q13	17992	3681	3661	3661
q14	289	255	260	255
q15	588	536	529	529
q16	478	414	425	414
q17	937	873	818	818
q18	7555	6697	6641	6641
q19	1557	1509	1500	1500
q20	630	347	365	347
q21	6795	3971	3965	3965
q22	874	343	337	337
Total cold run time: 108127 ms
Total hot run time: 41555 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4845	4853	4852	4852
q2	298	179	180	179
q3	3589	3585	3576	3576
q4	2526	2527	2510	2510
q5	5757	5742	5765	5742
q6	211	124	126	124
q7	2248	1671	1625	1625
q8	3051	3119	3116	3116
q9	8705	8742	8691	8691
q10	6786	4227	4231	4227
q11	530	373	361	361
q12	782	545	553	545
q13	4395	3446	3390	3390
q14	265	234	229	229
q15	624	513	500	500
q16	472	435	432	432
q17	1713	1628	1639	1628
q18	8325	7648	7690	7648
q19	1647	1646	1636	1636
q20	2119	1840	1853	1840
q21	6601	6230	6129	6129
q22	565	516	506	506
Total cold run time: 66054 ms
Total hot run time: 59486 ms

doris-robot avatar Feb 21 '24 07:02 doris-robot

TeamCity be ut coverage result: Function Coverage: 35.74% (8559/23951) Line Coverage: 27.60% (69425/251506) Region Coverage: 26.74% (36032/134745) Branch Coverage: 23.55% (18429/78240) Coverage Report: http://coverage.selectdb-in.cc/coverage/635c81742ec06b2ddac86c9fb20509950cdc626b_635c81742ec06b2ddac86c9fb20509950cdc626b/report/index.html

doris-robot avatar Feb 21 '24 08:02 doris-robot

run buildall

BiteTheDDDDt avatar Feb 22 '24 12:02 BiteTheDDDDt

TeamCity be ut coverage result: Function Coverage: 35.73% (8545/23917) Line Coverage: 27.53% (69330/251870) Region Coverage: 26.68% (35962/134808) Branch Coverage: 23.48% (18385/78292) Coverage Report: http://coverage.selectdb-in.cc/coverage/d55bf4a8597f7b32a019ff882b7d35e4626197a4_d55bf4a8597f7b32a019ff882b7d35e4626197a4/report/index.html

doris-robot avatar Feb 22 '24 13:02 doris-robot

PR approved by at least one committer and no changes requested.

github-actions[bot] avatar Feb 25 '24 02:02 github-actions[bot]

PR approved by anyone and no changes requested.

github-actions[bot] avatar Feb 25 '24 02:02 github-actions[bot]