doris icon indicating copy to clipboard operation
doris copied to clipboard

[enhancement](stream load pipe) using queryid or load id to identify stream load pipe instead of fragment instance id

Open yiguolei opened this issue 2 years ago • 12 comments

Proposed changes

NewLoadStreamMgr already has pipe and other info. Do not need save the pipe into fragment state. and FragmentState should be more clear.

But this pr will change the behaviour of BE. I will pick the pr to doris 1.2.3 and add the load id to FE support. The user could upgrade from 1.2.3 to 2.x

Problem summary

Describe your changes.

Checklist(Required)

  • [ ] Does it affect the original behavior
  • [ ] Has unit tests been added
  • [ ] Has document been added or modified
  • [ ] Does it need to update dependencies
  • [ ] Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

yiguolei avatar Mar 02 '23 13:03 yiguolei

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Mar 02 '23 13:03 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Mar 02 '23 13:03 github-actions[bot]

./run buildall

yiguolei avatar Mar 02 '23 14:03 yiguolei

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Mar 02 '23 14:03 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Mar 03 '23 03:03 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Mar 03 '23 07:03 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Mar 03 '23 07:03 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Mar 03 '23 09:03 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Mar 03 '23 09:03 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Mar 03 '23 09:03 github-actions[bot]

./run buildall

yiguolei avatar Mar 03 '23 11:03 yiguolei

./run p0

yiguolei avatar Mar 03 '23 12:03 yiguolei

./run buildall

yiguolei avatar Mar 04 '23 00:03 yiguolei

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Mar 04 '23 00:03 github-actions[bot]

PR approved by at least one committer and no changes requested.

github-actions[bot] avatar Mar 04 '23 07:03 github-actions[bot]

PR approved by anyone and no changes requested.

github-actions[bot] avatar Mar 04 '23 07:03 github-actions[bot]