[enhancement](timeout) replace query timeout with exec timeout

Open Hastyshell opened this issue 2 years ago • 11 comments

Proposed changes

introduce: #16343

Problem summary

pr #16343 made an api-change, use execution_timeout to enrich the semantics of original query_timeout, and execution_timeout got a more general semantics than query_timeout. When I was working with MasterOpExecutor, I found that when forwarding to master, the timeout used for controlling the connection is still query_timeout.

Therefore, I made some updates related to this feature.

Checklist(Required)

[ ] Does it affect the original behavior
[ ] Has unit tests been added
[ ] Has document been added or modified
[ ] Does it need to update dependencies
[x] Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

Mar 02 '23 13:03 Hastyshell

run buildall

Mar 02 '23 13:03 Hastyshell

run p0

Mar 02 '23 13:03 Hastyshell

PR approved by at least one committer and no changes requested.

Mar 02 '23 13:03 github-actions[bot]

PR approved by anyone and no changes requested.

Mar 02 '23 13:03 github-actions[bot]

run p0

Mar 02 '23 14:03 Hastyshell

run p0

Mar 03 '23 04:03 Hastyshell

run buildall

Mar 03 '23 12:03 Hastyshell

run p0

Mar 03 '23 12:03 Hastyshell

run buildall

Mar 04 '23 06:03 Hastyshell

run p0

Mar 04 '23 07:03 Hastyshell

run arm

Mar 04 '23 09:03 Hastyshell