doris icon indicating copy to clipboard operation
doris copied to clipboard

[function](vec)use const_col to opt current functions.

Open zclllyybb opened this issue 1 year ago • 12 comments

Proposed Changes

before:

mysql [ssb]>select count(now()) from lineorder;
+--------------+
| count(now()) |
+--------------+
|    600037902 |
+--------------+
1 row in set (0.96 sec)
mysql [ssb]>select count(curdate()) from lineorder;
+------------------+
| count(curdate()) |
+------------------+
|        600037902 |
+------------------+
1 row in set (0.95 sec)

after:

mysql [ssb]>select count(now()) from lineorder;
+--------------+
| count(now()) |
+--------------+
|    600037902 |
+--------------+
1 row in set (0.85 sec)
mysql [ssb]>select count(curdate()) from lineorder;
+------------------+
| count(curdate()) |
+------------------+
|        600037902 |
+------------------+
1 row in set (0.88 sec)

Problem Summary

The changes are like https://github.com/apache/doris/pull/16953 , apply to CurrentDate and CurrentDateTime.

Checklist(Required)

  • [ ] Does it affect the original behavior
  • [ ] Has unit tests been added
  • [ ] Has document been added or modified
  • [ ] Does it need to update dependencies
  • [x] Is this PR support rollback (If NO, please explain WHY)

zclllyybb avatar Mar 02 '23 05:03 zclllyybb

run buildall

zclllyybb avatar Mar 02 '23 05:03 zclllyybb

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Mar 02 '23 05:03 github-actions[bot]

run p0

zclllyybb avatar Mar 02 '23 09:03 zclllyybb

Could you also give some results before and after, like pr https://github.com/apache/doris/pull/16953

cambyzju avatar Mar 02 '23 09:03 cambyzju

run p0

zclllyybb avatar Mar 02 '23 13:03 zclllyybb

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Mar 03 '23 02:03 github-actions[bot]

run buildall

zclllyybb avatar Mar 03 '23 05:03 zclllyybb

run p0

zclllyybb avatar Mar 03 '23 07:03 zclllyybb

run p0

zclllyybb avatar Mar 03 '23 10:03 zclllyybb

run p0

zclllyybb avatar Mar 03 '23 11:03 zclllyybb

run buildall

zclllyybb avatar Mar 04 '23 12:03 zclllyybb

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Mar 04 '23 12:03 github-actions[bot]

PR approved by at least one committer and no changes requested.

github-actions[bot] avatar Mar 05 '23 10:03 github-actions[bot]

PR approved by anyone and no changes requested.

github-actions[bot] avatar Mar 05 '23 10:03 github-actions[bot]