doris icon indicating copy to clipboard operation
doris copied to clipboard

[fix](nereids)fix first_value/lead/lag window function bug in nereids

Open starocean999 opened this issue 1 year ago • 9 comments

Proposed changes

Issue Number: close #xxx

Problem summary

  1. first_value should be converted to last_value in some case like old planner
  2. make the 3rd parameter of lead/lag function support a nullable value in nereids.

Checklist(Required)

  • [ ] Does it affect the original behavior
  • [ ] Has unit tests been added
  • [ ] Has document been added or modified
  • [ ] Does it need to update dependencies
  • [ ] Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

starocean999 avatar Mar 02 '23 02:03 starocean999

run buildall

starocean999 avatar Mar 02 '23 02:03 starocean999

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Mar 02 '23 02:03 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Mar 02 '23 04:03 github-actions[bot]

TeamCity pipeline, clickbench performance test result: the sum of best hot time: 33.63 seconds stream load tsv: 473 seconds loaded 74807831229 Bytes, about 150 MB/s stream load json: 40 seconds loaded 2358488459 Bytes, about 56 MB/s stream load orc: 74 seconds loaded 1101869774 Bytes, about 14 MB/s stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230308092959_clickbench_pr_110700.html

hello-stephen avatar Mar 02 '23 04:03 hello-stephen

run buildall

starocean999 avatar Mar 02 '23 04:03 starocean999

run buildall

starocean999 avatar Mar 02 '23 08:03 starocean999

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Mar 02 '23 08:03 github-actions[bot]

run buildall

starocean999 avatar Mar 03 '23 07:03 starocean999

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Mar 03 '23 07:03 github-actions[bot]

run buildall

starocean999 avatar Mar 07 '23 08:03 starocean999

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Mar 07 '23 08:03 github-actions[bot]

run buildall

starocean999 avatar Mar 08 '23 09:03 starocean999

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Mar 08 '23 09:03 github-actions[bot]

LGTM

englefly avatar Mar 09 '23 01:03 englefly

PR approved by at least one committer and no changes requested.

github-actions[bot] avatar Mar 09 '23 01:03 github-actions[bot]

PR approved by anyone and no changes requested.

github-actions[bot] avatar Mar 09 '23 01:03 github-actions[bot]