doris icon indicating copy to clipboard operation
doris copied to clipboard

[vectorized](bug) fix some open enable_fold_constant_by_be failed cases

Open zhangstar333 opened this issue 1 year ago • 6 comments

Proposed changes

when set enable_fold_constant_by_be = true some cases of P0 will be failed, this pr fix some about BE, eg: SELECT CAST('null' AS JSONB) select cast ('2022-12-02 22:23:24.999999' as datetimev2(3)) SELECT repeat(\"a\", 3) select version() select cast(19888.8999999 as decimal(12,2))

Issue Number: close #xxx

Problem summary

Describe your changes.

Checklist(Required)

  • [ ] Does it affect the original behavior
  • [ ] Has unit tests been added
  • [ ] Has document been added or modified
  • [ ] Does it need to update dependencies
  • [ ] Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

zhangstar333 avatar Feb 28 '23 09:02 zhangstar333

run p0

zhangstar333 avatar Feb 28 '23 09:02 zhangstar333

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Feb 28 '23 10:02 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Feb 28 '23 12:02 github-actions[bot]

run buildall

zhangstar333 avatar Mar 01 '23 06:03 zhangstar333

run buildall

zhangstar333 avatar Mar 02 '23 02:03 zhangstar333

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Mar 02 '23 02:03 github-actions[bot]

PR approved by at least one committer and no changes requested.

github-actions[bot] avatar Mar 03 '23 01:03 github-actions[bot]

PR approved by anyone and no changes requested.

github-actions[bot] avatar Mar 03 '23 01:03 github-actions[bot]