doris icon indicating copy to clipboard operation
doris copied to clipboard

[fix](alter) support alter table ENABLE FEATURE SEQUENCE_LOAD WITH PROPERTIES ( function_column.sequence_col = col_name)

Open nextdreamblue opened this issue 2 years ago • 13 comments

…OPERTIES ( function_column.sequence_col = col_name)

Proposed changes

Issue Number: close #16899

Problem summary

Describe your changes.

Checklist(Required)

  • [ ] Does it affect the original behavior
  • [ ] Has unit tests been added
  • [ ] Has document been added or modified
  • [ ] Does it need to update dependencies
  • [ ] Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

nextdreamblue avatar Feb 20 '23 12:02 nextdreamblue

run p0

nextdreamblue avatar Feb 21 '23 02:02 nextdreamblue

run clickbench

nextdreamblue avatar Feb 21 '23 02:02 nextdreamblue

run buildall

nextdreamblue avatar Feb 21 '23 02:02 nextdreamblue

TeamCity pipeline, clickbench performance test result: the sum of best hot time: 34.65 seconds stream load tsv: 470 seconds loaded 74807831229 Bytes, about 151 MB/s stream load json: 37 seconds loaded 2358488459 Bytes, about 60 MB/s stream load orc: 67 seconds loaded 1101869774 Bytes, about 15 MB/s stream load parquet: 27 seconds loaded 861443392 Bytes, about 30 MB/s https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230226023946_clickbench_pr_104485.html

hello-stephen avatar Feb 21 '23 04:02 hello-stephen

run p0

nextdreamblue avatar Feb 22 '23 09:02 nextdreamblue

run beut

nextdreamblue avatar Feb 23 '23 07:02 nextdreamblue

run feut

nextdreamblue avatar Feb 23 '23 07:02 nextdreamblue

run feut

nextdreamblue avatar Feb 23 '23 15:02 nextdreamblue

run feut

nextdreamblue avatar Feb 24 '23 02:02 nextdreamblue

run buildall

nextdreamblue avatar Feb 26 '23 01:02 nextdreamblue

run buildall

nextdreamblue avatar Feb 26 '23 02:02 nextdreamblue

This property should not support schema change. We have a hidden sequence column, it's value is copied from specified column. If we want the new added sequence column works correctly, we should rewrite the value of hidden sequence column of all old data.

zhannngchen avatar Mar 01 '23 12:03 zhannngchen

This property should not support schema change. We have a hidden sequence column, it's value is copied from specified column. If we want the new added sequence column works correctly, we should rewrite the value of hidden sequence column of all old data.

ok, this pr will close

nextdreamblue avatar Mar 02 '23 02:03 nextdreamblue