doris
doris copied to clipboard
apache
[fix](fold_constant) add defer in fold constant to close
Proposed changes
when set this.enableFoldConstantByBe = true; and doing prepare work will return error for some reason, eg: can't find function in BE. so will return directly without call close function.
Issue Number: close #xxx
Problem summary
Describe your changes.
Checklist(Required)
- Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
- Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
- Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
- Does it need to update dependencies:
- [ ] Yes
- [ ] No
- Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
Further comments
If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
PR approved by at least one committer and no changes requested.
TeamCity pipeline, clickbench performance test result: the sum of best hot time: 34.08 seconds stream load tsv: 483 seconds loaded 74807831229 Bytes, about 147 MB/s stream load json: 39 seconds loaded 2358488459 Bytes, about 57 MB/s stream load orc: 68 seconds loaded 1101869774 Bytes, about 15 MB/s stream load parquet: 28 seconds loaded 861443392 Bytes, about 29 MB/s https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230217132406_clickbench_pr_99153.html
