doris icon indicating copy to clipboard operation
doris copied to clipboard

[Enhancement] auditloader plugin always discard audit log when clsuter is busy

Open dutyu opened this issue 2 years ago • 0 comments

Search before asking

  • [X] I had searched in the issues and found no similar issues.

Description

I've installed the auditloader plugin, i found that when cluster is busy (users submit many sqls to the cluster), the doris_audit_tbl__ table is always missing some audit log where i can find in fe.audit.log. I've reviewed the code and found that AuditLoaderPlugin use a LinkedBlockingDeque which the capacity is 1, if users submit many sqls, the AuditLoaderPlugin.exec method is always failed cause of the queue is full. Maybe use a configuration to control the capacity of the queue is an elegant way to handle this problem.

Solution

Use a configuration to control the capacity of the queue.

Are you willing to submit PR?

  • [X] Yes I am willing to submit a PR!

Code of Conduct

dutyu avatar Sep 22 '22 12:09 dutyu