doris icon indicating copy to clipboard operation
doris copied to clipboard

[fix](function)fix string split function buffer overflow

Open starocean999 opened this issue 2 years ago • 3 comments

Proposed changes

Issue Number: close #xxx

Problem summary

Describe your changes.

Checklist(Required)

  1. Does it affect the original behavior:
    • [ ] Yes
    • [x] No
    • [ ] I don't know
  2. Has unit tests been added:
    • [ ] Yes
    • [x] No
    • [ ] No Need
  3. Has document been added or modified:
    • [ ] Yes
    • [x] No
    • [ ] No Need
  4. Does it need to update dependencies:
    • [ ] Yes
    • [x] No
  5. Are there any changes that cannot be rolled back:
    • [ ] Yes (If Yes, please explain WHY)
    • [x] No

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

starocean999 avatar Sep 21 '22 13:09 starocean999

please add test case

morningman avatar Sep 22 '22 01:09 morningman

PR approved by at least one committer and no changes requested.

github-actions[bot] avatar Sep 22 '22 01:09 github-actions[bot]

PR approved by anyone and no changes requested.

github-actions[bot] avatar Sep 22 '22 01:09 github-actions[bot]

PR approved by at least one committer and no changes requested.

github-actions[bot] avatar Sep 24 '22 03:09 github-actions[bot]

please add test case

I discussed it with @starocean999 , it is a problem due to memory overflow, it is difficult to find a simple case can cover it and the test pipeline is blocked, so i merged it.

dataroaring avatar Sep 24 '22 09:09 dataroaring