doris icon indicating copy to clipboard operation
doris copied to clipboard

[fix](streamload&sink) release and allocate memory in the same tracker

Open dataroaring opened this issue 2 years ago • 3 comments

  1. HttpServer threads allocate bytebuffer and put them into streamload pipe, but scanner thread release them with query tracker.

  2. We can assume brpc allocate memory in doris thread.

Above problems leads to wrong result of memtracker.

Proposed changes

Issue Number: close #xxx

Problem summary

Describe your changes.

Checklist(Required)

  1. Does it affect the original behavior:
    • [ ] Yes
    • [ ] No
    • [ ] I don't know
  2. Has unit tests been added:
    • [ ] Yes
    • [ ] No
    • [ ] No Need
  3. Has document been added or modified:
    • [ ] Yes
    • [ ] No
    • [ ] No Need
  4. Does it need to update dependencies:
    • [ ] Yes
    • [ ] No
  5. Are there any changes that cannot be rolled back:
    • [ ] Yes (If Yes, please explain WHY)
    • [ ] No

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

dataroaring avatar Sep 21 '22 10:09 dataroaring

PR approved by at least one committer and no changes requested.

github-actions[bot] avatar Sep 22 '22 02:09 github-actions[bot]

PR approved by anyone and no changes requested.

github-actions[bot] avatar Sep 22 '22 02:09 github-actions[bot]

PR approved by at least one committer and no changes requested.

github-actions[bot] avatar Sep 22 '22 20:09 github-actions[bot]