doris icon indicating copy to clipboard operation
doris copied to clipboard

[fix](profile) close eof scanner before transfer done

Open dataroaring opened this issue 2 years ago • 0 comments

We should close eof scanners before transfer done, otherwise, they are closed until scannode is closed. Because plan is closed after the plan is finished, so query profile would leak stats from scanners closed by scannode::close. e.g. SegmentTotalNum in profile is less.

Proposed changes

Issue Number: close #xxx

Problem summary

Describe your changes.

Checklist(Required)

  1. Does it affect the original behavior:
    • [ ] Yes
    • [ ] No
    • [ ] I don't know
  2. Has unit tests been added:
    • [ ] Yes
    • [ ] No
    • [ ] No Need
  3. Has document been added or modified:
    • [ ] Yes
    • [ ] No
    • [ ] No Need
  4. Does it need to update dependencies:
    • [ ] Yes
    • [ ] No
  5. Are there any changes that cannot be rolled back:
    • [ ] Yes (If Yes, please explain WHY)
    • [ ] No

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

dataroaring avatar Aug 11 '22 16:08 dataroaring