doris icon indicating copy to clipboard operation
doris copied to clipboard

[enhancement](Nereids)refactor sort plan in nereids

Open morrySnow opened this issue 3 years ago • 3 comments

Proposed changes

  • rename PhysicalHeapSort to PhysicalQuickSort
  • add LogicalTopN and PhysicalTopN
  • add implementation rule for LogicalTopN
  • add a interface Sort for both logical and physical sort
  • add a interface TopN for both logical and physical top-n
  • add a AbstractPhysicalSort as super class of PhysicalQuickSort and PhysicalTopN

Checklist(Required)

  1. Does it affect the original behavior:
    • [ ] Yes
    • [x] No
    • [ ] I don't know
  2. Has unit tests been added:
    • [ ] Yes
    • [x] No
    • [ ] No Need
  3. Has document been added or modified:
    • [ ] Yes
    • [ ] No
    • [x] No Need
  4. Does it need to update dependencies:
    • [ ] Yes
    • [x] No
  5. Are there any changes that cannot be rolled back:
    • [ ] Yes (If Yes, please explain WHY)
    • [x] No

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

morrySnow avatar Aug 11 '22 05:08 morrySnow

@englefly @jackwener PTAL

morrySnow avatar Aug 11 '22 06:08 morrySnow

PR approved by anyone and no changes requested.

github-actions[bot] avatar Aug 11 '22 07:08 github-actions[bot]

@924060929 PTAL

morrySnow avatar Aug 11 '22 07:08 morrySnow