doris icon indicating copy to clipboard operation
doris copied to clipboard

[refactor](ddl) Encapsulate table's properties

Open adonis0147 opened this issue 3 years ago • 1 comments

Proposed changes

~~Issue Number: close #xxx~~

Problem summary

There are so many properties for a olap table which makes the logic of creating olap table too complex. This pr aims at simplifying it.

Checklist(Required)

  1. Does it affect the original behavior:
    • [ ] Yes
    • [x] No
    • [ ] I don't know
  2. Has unit tests been added:
    • [ ] Yes
    • [ ] No
    • [x] No Need
  3. Has document been added or modified:
    • [ ] Yes
    • [ ] No
    • [x] No Need
  4. Does it need to update dependencies:
    • [ ] Yes
    • [x] No
  5. Are there any changes that cannot be rolled back:
    • [ ] Yes (If Yes, please explain WHY)
    • [x] No

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

adonis0147 avatar Aug 05 '22 09:08 adonis0147

Actually we had a class named TableProperty yet. Is there any different?

Oops, it seems that I can merge these two classes. I will update this pr.

adonis0147 avatar Aug 07 '22 06:08 adonis0147

We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. If you'd like to revive this PR, please reopen it and feel free a maintainer to remove the Stale tag!

github-actions[bot] avatar Feb 04 '23 00:02 github-actions[bot]