doris-spark-connector icon indicating copy to clipboard operation
doris-spark-connector copied to clipboard

[improvement] set streamLoad prop num_as_string default true to avoid…

Open lxwcodemonkey opened this issue 1 year ago • 2 comments

… loss of floating point precision

Proposed changes

Issue Number: close #xxx

Problem Summary:

Describe the overview of changes.

Checklist(Required)

  1. Does it affect the original behavior: (Yes/No/I Don't know)
  2. Has unit tests been added: (Yes/No/No Need)
  3. Has document been added or modified: (Yes/No/No Need)
  4. Does it need to update dependencies: (Yes/No)
  5. Are there any changes that cannot be rolled back: (Yes/No)

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

lxwcodemonkey avatar Aug 14 '23 06:08 lxwcodemonkey

@JNSimba Could you help me to have a look? thanks!

lxwcodemonkey avatar Aug 17 '23 01:08 lxwcodemonkey

Thank you for your contribution. Is it better to modify the default value directly on the streamload side?

JNSimba avatar Aug 17 '23 07:08 JNSimba