doris-flink-connector icon indicating copy to clipboard operation
doris-flink-connector copied to clipboard

[Fix] fix deserialization error for QueryPlan exception

Open link3280 opened this issue 2 years ago • 3 comments

Proposed changes

Issue Number: close #65

Problem Summary:

Deserialization error on QueryPlan with exceptions.

Checklist(Required)

  1. Does it affect the original behavior: (No)
  2. Has unit tests been added: (No Need)
  3. Has document been added or modified: (No Need)
  4. Does it need to update dependencies: (No)
  5. Are there any changes that cannot be rolled back: (No)

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

link3280 avatar Sep 25 '22 05:09 link3280

Thank you for your pr, is it also possible to add @JsonIgnoreProperties(ignoreUnknown = true) directly to the entity class of QueryPlan ?

JNSimba avatar Sep 26 '22 02:09 JNSimba

Yes. Do you mean adding the annotation alone or also with the exception field? I think the exception msg is helpful and should be exposed to users properly.

link3280 avatar Sep 26 '22 03:09 link3280

However, the response of queryPlan has been judged in RestService.getQueryPlan, and an exception is also thrown when an error occurs, so is there no need to record the exception in queryPlan?

JNSimba avatar Sep 27 '22 09:09 JNSimba