dolphinscheduler icon indicating copy to clipboard operation
dolphinscheduler copied to clipboard

Published 20 hours ago • verified publisher icon apache

[DSIP-90][plugin] Introduce new task plugin for Flink materialized table

Open hackergin opened this issue 6 months ago • 4 comments

Purpose of the pull request

Add a new task plugin for refresh flink materialized table.

close https://github.com/apache/dolphinscheduler/issues/17086

Brief change log

Verify this pull request

  • Added dolphinscheduler flink materialized table end to end test

hackergin avatar May 22 '25 05:05 hackergin

Thanks for opening this pull request! Please check out our contributing guidelines. (https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md)

boring-cyborg[bot] avatar May 22 '25 05:05 boring-cyborg[bot]

Hi, @ruanwenjun, @SbloodyS can you help review this pr?

lsyldliu avatar May 22 '25 06:05 lsyldliu

Please check the failed CI. @hackergin

SbloodyS avatar May 22 '25 09:05 SbloodyS

Quality Gate Failed Quality Gate failed

Failed conditions
53.8% Coverage on New Code (required ≥ 60%)

See analysis details on SonarQube Cloud

sonarqubecloud[bot] avatar Jun 17 '25 15:06 sonarqubecloud[bot]

Two CI issues:

  1. dependency check is failing with Cannot construct instance of ModifiedCiaType, problem: SAFETY - seems like a tool compatibility issue with new NVD data, not related to my changes.

  2. Code coverage is below threshold. Not sure if this is required since I noticed other similar tasks don't seem to have corresponding tests either.

@SbloodyS Should I address the coverage issue or is it OK to proceed as-is?

hackergin avatar Jun 24 '25 01:06 hackergin

  1. You can ignore OWASP Dependentcy Check for now.

Code coverage is below threshold. Not sure if this is required since I noticed other similar tasks don't seem to have corresponding tests either.

Yes.

SbloodyS avatar Jun 30 '25 01:06 SbloodyS