dolphinscheduler
dolphinscheduler copied to clipboard
[Improvement-17169][service] unify preTasks and depList to predecessors in TaskNode, to avoid type conversion
Purpose of the pull request
fix #17169 , unify depList and preTasks to predecessors in TaskNode, to avoid type conversion
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
Pull Request Notice
If your pull request contains incompatible change, you should also add it to docs/docs/en/guide/upgrade/incompatible.md
Thanks for opening this pull request! Please check out our contributing guidelines. (https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md)
Why not unify this in front-end and back-end, we can only keep one field in TaskNode.
good idea, let me try it
I think TaskNode just used in back-end when workflow running, in front-end it use taskDefinitionJson to represent task node in dag. And I searched ui module and not found TaskNode to use.
could you approval this workflow? @ruanwenjun @SbloodyS thx~
could you approval this workflow? @ruanwenjun @SbloodyS thx~
Done.
could you have a time to review this pr? thx~ @SbloodyS @ruanwenjun
And I would like to use predecessors to represent the upstream node, depList is confused with dependent node.
And I would like to use
predecessorsto represent the upstream node,depListis confused with dependent node.
Done. Could you approval this workflow? thx~ @ruanwenjun @SbloodyS
Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
26.3% Coverage on New Code
0.0% Duplication on New Code
Do you have any suggestions? thank you @ruanwenjun @SbloodyS
Do you have any suggestions? thank you @ruanwenjun @SbloodyS
You can check comments https://github.com/apache/dolphinscheduler/pull/17170#discussion_r2094967232