dolphinscheduler icon indicating copy to clipboard operation
dolphinscheduler copied to clipboard

[Improvement-17169][service] unify preTasks and depList to predecessors in TaskNode, to avoid type conversion

Open unigof opened this issue 6 months ago • 11 comments

Purpose of the pull request

fix #17169 , unify depList and preTasks to predecessors in TaskNode, to avoid type conversion

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

Pull Request Notice

Pull Request Notice

If your pull request contains incompatible change, you should also add it to docs/docs/en/guide/upgrade/incompatible.md

unigof avatar May 09 '25 14:05 unigof

Thanks for opening this pull request! Please check out our contributing guidelines. (https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md)

boring-cyborg[bot] avatar May 09 '25 14:05 boring-cyborg[bot]

Why not unify this in front-end and back-end, we can only keep one field in TaskNode.

good idea, let me try it

unigof avatar May 12 '25 16:05 unigof

I think TaskNode just used in back-end when workflow running, in front-end it use taskDefinitionJson to represent task node in dag. And I searched ui module and not found TaskNode to use.

unigof avatar May 13 '25 03:05 unigof

could you approval this workflow? @ruanwenjun @SbloodyS thx~

unigof avatar May 15 '25 01:05 unigof

could you approval this workflow? @ruanwenjun @SbloodyS thx~

Done.

SbloodyS avatar May 15 '25 03:05 SbloodyS

could you have a time to review this pr? thx~ @SbloodyS @ruanwenjun

unigof avatar May 15 '25 11:05 unigof

And I would like to use predecessors to represent the upstream node, depList is confused with dependent node.

ruanwenjun avatar May 15 '25 12:05 ruanwenjun

And I would like to use predecessors to represent the upstream node, depList is confused with dependent node.

Done. Could you approval this workflow? thx~ @ruanwenjun @SbloodyS

unigof avatar May 15 '25 12:05 unigof

Do you have any suggestions? thank you @ruanwenjun @SbloodyS

unigof avatar May 20 '25 00:05 unigof

Do you have any suggestions? thank you @ruanwenjun @SbloodyS

You can check comments https://github.com/apache/dolphinscheduler/pull/17170#discussion_r2094967232

SbloodyS avatar May 20 '25 03:05 SbloodyS