dolphinscheduler icon indicating copy to clipboard operation
dolphinscheduler copied to clipboard

[DSIP-66][k8s] Support User-customized K8s YAML Pod

Open Mighten opened this issue 1 year ago • 5 comments

Purpose of the pull request

This pull request adds user-customized YAML support for Kubernetes Pod task, and aims to close: #16482

  • #16482

Brief change log

  • Added YamlUtils with jackson-dataformat-yaml(new dependency in pom.xml)
  • Updated K8sUtils with default namespace injection
  • Added user-customized YAML task mode, with frontend and backend

Verify this pull request

This change added tests and can be verified as follows:

  • Added YamlUtilsTest to verify YamlUtils

  • Added K8sUtilsTest to verify updates for K8sUtils

  • Manually verified the user-customized YAML task mode using both the web page and IDE output:

    1. Switch on the Custom Template mode, and paste Kubernetes YAML file content:

      1-enable-yaml-mode

      Conclusion: The user-customized YAML mode works correctly in the frontend.

    2. Online, Start the current workflow and review the log of the current task instance:

      2-view-pod-log

      Conclusion: The user-customized YAML mode works correctly in the backend.

    3. Review the pod output parameters parsed from the log in the IDE console (these are not listed in the task instance log window):

      3-get-pod-output-params

      Conclusion: The user-customized YAML mode correctly parses the output values from the log.

Mighten avatar Aug 16 '24 14:08 Mighten

Thanks for opening this pull request! Please check out our contributing guidelines. (https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md)

boring-cyborg[bot] avatar Aug 16 '24 14:08 boring-cyborg[bot]

First you need to create a DSIP.

Gallardot avatar Aug 16 '24 15:08 Gallardot

First you need to create a DSIP.

Yes you need to create a DSIP, and provide detailed design, rather then directly submit a PR.

ruanwenjun avatar Aug 17 '24 04:08 ruanwenjun

@Mighten Please modify the associated issue number

fuchanghai avatar Aug 18 '24 11:08 fuchanghai

Quality Gate Failed Quality Gate failed

Failed conditions
36.1% Coverage on New Code (required ≥ 60%)

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Aug 21 '24 02:08 sonarqubecloud[bot]

Closing for no plans to do this.

SbloodyS avatar Sep 26 '24 13:09 SbloodyS