dolphinscheduler icon indicating copy to clipboard operation
dolphinscheduler copied to clipboard

Rename variable QUEUE_MAX_SIZE to QUEUE_INITIAL_SIZE

Open shilei-ly opened this issue 1 year ago • 1 comments

Purpose of the pull request

fix #16039 Modify the name of the variable, reduce the ambiguity

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

shilei-ly avatar May 20 '24 11:05 shilei-ly

It's better to remove the initialize size, most workflow doesn't have 3000 tasks.

Sure,3000 is too big。Now I have removed the initial capacity

shilei-ly avatar May 21 '24 10:05 shilei-ly

LGTM, @alei1206 please run 'mvn spotless:apply' to fix the code style

@rickchengx Thank you for reminding. Code has been submitted again

shilei-ly avatar May 22 '24 11:05 shilei-ly

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 40.65%. Comparing base (f754611) to head (aeb4fd7).

:exclamation: Current head aeb4fd7 differs from pull request most recent head 6be6cf8

Please upload reports for the commit 6be6cf8 to get more accurate results.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #16040      +/-   ##
============================================
- Coverage     40.67%   40.65%   -0.02%     
+ Complexity     5226     5224       -2     
============================================
  Files          1380     1380              
  Lines         46011    46009       -2     
  Branches       4919     4919              
============================================
- Hits          18713    18706       -7     
- Misses        25373    25378       +5     
  Partials       1925     1925              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar May 24 '24 06:05 codecov-commenter

Quality Gate Failed Quality Gate failed

Failed conditions
14.2% Coverage on New Code (required ≥ 60%)

See analysis details on SonarCloud

sonarqubecloud[bot] avatar May 24 '24 08:05 sonarqubecloud[bot]