dolphinscheduler icon indicating copy to clipboard operation
dolphinscheduler copied to clipboard

[Improvement][Flink] Change Flink command into FLINK_HOME

Open pegasas opened this issue 1 year ago • 7 comments

Purpose of the pull request

fix: https://github.com/apache/dolphinscheduler/issues/16003

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

pegasas avatar May 15 '24 10:05 pegasas

Hi @pegasas, please fix UT.

Radeity avatar May 15 '24 11:05 Radeity

Hi @pegasas, please fix UT.

Thanks, Done. image

pegasas avatar May 15 '24 12:05 pegasas

Please run mvn spotless:apply @pegasas

Radeity avatar May 15 '24 13:05 Radeity

Please run mvn spotless:apply @pegasas

Weired, it seems my change has not been posted. Thanks image

pegasas avatar May 15 '24 13:05 pegasas

LGTM, please fix the UT

image image

Sorry I missed test in flink-stream. Done and pass spotless check on my local machine.

pegasas avatar May 16 '24 03:05 pegasas

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 40.66%. Comparing base (ec01df1) to head (b1f938d). Report is 1 commits behind head on dev.

:exclamation: Current head b1f938d differs from pull request most recent head 081f834

Please upload reports for the commit 081f834 to get more accurate results.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #16004      +/-   ##
============================================
- Coverage     40.67%   40.66%   -0.01%     
+ Complexity     5238     5237       -1     
============================================
  Files          1382     1382              
  Lines         46023    46023              
  Branches       4922     4922              
============================================
- Hits          18719    18716       -3     
- Misses        25379    25381       +2     
- Partials       1925     1926       +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar May 16 '24 09:05 codecov-commenter