dolphinscheduler icon indicating copy to clipboard operation
dolphinscheduler copied to clipboard

[Feature]Supports dinky tasks to accept Prepare Params passed within a task or from a previous task

Open gaoyan1998 opened this issue 9 months ago • 7 comments

Purpose of the pull request

Supports dinky tasks to accept variables passed within a task or from a previous task

Brief change log

Verify this pull request

gaoyan1998 avatar May 06 '24 03:05 gaoyan1998

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 41.15%. Comparing base (565a917) to head (345b2aa). Report is 4 commits behind head on dev.

:exclamation: Current head 345b2aa differs from pull request most recent head 427a368

Please upload reports for the commit 427a368 to get more accurate results.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #15947      +/-   ##
============================================
- Coverage     41.17%   41.15%   -0.03%     
+ Complexity     5093     5091       -2     
============================================
  Files          1391     1391              
  Lines         43803    43803              
  Branches       4645     4645              
============================================
- Hits          18038    18028      -10     
- Misses        23997    24006       +9     
- Partials       1768     1769       +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar May 06 '24 08:05 codecov-commenter

Please supplement the document. @gaoyan1998

@SbloodyS PTAL, Supplement the documentation done.

gaoyan1998 avatar May 07 '24 08:05 gaoyan1998

Please run mvn spotless:apply to format the code. @gaoyan1998

SbloodyS avatar May 08 '24 01:05 SbloodyS

Please run mvn spotless:apply to format the code. @gaoyan1998

I have resolved it,please review it,thanks. @SbloodyS

gaoyan1998 avatar May 09 '24 02:05 gaoyan1998

Quality Gate Failed Quality Gate failed

Failed conditions
36.4% Coverage on New Code (required ≥ 60%)

See analysis details on SonarCloud

sonarqubecloud[bot] avatar May 09 '24 10:05 sonarqubecloud[bot]

@ruanwenjun Thanks for your suggestion, I have finished the revision

gaoyan1998 avatar May 13 '24 09:05 gaoyan1998

hi @ruanwenjun PTAL ,please approval workflows

gaoyan1998 avatar May 27 '24 02:05 gaoyan1998

Please create an issue and link to it. @gaoyan1998

@SbloodyS Sorry for the missing issue, it has now been created and the title changed

gaoyan1998 avatar Jul 03 '24 15:07 gaoyan1998

Quality Gate Failed Quality Gate failed

Failed conditions
45.8% Coverage on New Code (required ≥ 60%)

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Jul 04 '24 01:07 sonarqubecloud[bot]

Awesome work, congrats on your first merged pull request!

boring-cyborg[bot] avatar Jul 04 '24 01:07 boring-cyborg[bot]